Re: RFR [8030878] JConsole issues meaningless message if SSL connection fails

Looks good! Thanks, /Staffan On 13 jan 2014, at 19:18, Ivan Gerasimov wrote: > Hello! > > This is a 7u-dev fix only. The issue doesn't exist in 8 nor in 9. > > Currently when the Jconsole app fails to establish a secured connection it > displays a message box with two lines: > ConnectionFai

Re: RFR [8030878] JConsole issues meaningless message if SSL connection fails

Looks okay to me. Mandy On 1/13/2014 10:18 AM, Ivan Gerasimov wrote: Hello! This is a 7u-dev fix only. The issue doesn't exist in 8 nor in 9. Currently when the Jconsole app fails to establish a secured connection it displays a message box with two lines: ConnectionFailedSSL1 ConnectionFai

RFR [8030878] JConsole issues meaningless message if SSL connection fails

Hello! This is a 7u-dev fix only. The issue doesn't exist in 8 nor in 9. Currently when the Jconsole app fails to establish a secured connection it displays a message box with two lines: ConnectionFailedSSL1 ConnectionFailedSSL2 which have a little sense. The fix is to place the correct line

Re: RFR(S): JDK-8031304 : Add dcmd to print all loaded dynamic libraries

The code looks good to me (not an official reviewer). However, I'm surprised this command doesn't require the java.lang.management.ManagementPermission("monitor") when invoked from the DiagnosticCommandMBean. Has this topic been discussed during the CCC review or with the security team? Regards,

hg: jdk8/tl/jaxws: 8027908: serialVersionUID of javax.xml.bind.TypeConstraintException accidently changed

Changeset: bd943bdbce05 Author:alanb Date: 2014-01-13 16:17 + URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/bd943bdbce05 8027908: serialVersionUID of javax.xml.bind.TypeConstraintException accidently changed Reviewed-by: alanb Contributed-by: iaroslav.savyts...@oracle.com

Re: RFR (S): 6380601: MISC_REGRESSION tests need to be more resilient to ps cmd problems

On 01/13/2014 03:13 PM, Alan Bateman wrote: On 13/01/2014 13:57, Yekaterina Kantserova wrote: Sorry, I've not explained in more details. I have sun/tools tests in the same project in Eclipse and there I get a compilation error if I have 2 classes with the same name. I've used this standard f

Re: RFR (S): 6380601: MISC_REGRESSION tests need to be more resilient to ps cmd problems

On 13/01/2014 13:57, Yekaterina Kantserova wrote: Sorry, I've not explained in more details. I have sun/tools tests in the same project in Eclipse and there I get a compilation error if I have 2 classes with the same name. I've used this standard for several fixes, for example sun/tools/jsta

Re: RFR (S): 6380601: MISC_REGRESSION tests need to be more resilient to ps cmd problems

On 13.1.2014 14:57, Yekaterina Kantserova wrote: On 01/13/2014 02:29 PM, Alan Bateman wrote: On 13/01/2014 13:17, Yekaterina Kantserova wrote: Thank you for reviewing this! Unfortunantely I can't use Basic.java since we don't use packages for jtreg tests. It is true that we use the unnamed pa

Re: RFR(S): JDK-8031304 : Add dcmd to print all loaded dynamic libraries

Looks good to me. On 2014-01-13 17:17, Fredrik Arvidsson wrote: > Hi > > Please help me review the following small enhancement: > > Webrev: http://cr.openjdk.java.net/~farvidsson/8031304/webrev.00/ > > Jira: https://bugs.openjdk.java

Re: RFR (S): 6380601: MISC_REGRESSION tests need to be more resilient to ps cmd problems

On 01/13/2014 02:29 PM, Alan Bateman wrote: On 13/01/2014 13:17, Yekaterina Kantserova wrote: Thank you for reviewing this! Unfortunantely I can't use Basic.java since we don't use packages for jtreg tests. It is true that we use the unnamed package in most of the tests but that shouldn't be

Re: RFR (S): 6380601: MISC_REGRESSION tests need to be more resilient to ps cmd problems

On 13/01/2014 13:17, Yekaterina Kantserova wrote: Thank you for reviewing this! Unfortunantely I can't use Basic.java since we don't use packages for jtreg tests. It is true that we use the unnamed package in most of the tests but that shouldn't be an issue because the location is unique.

RFR(S): JDK-8031304 : Add dcmd to print all loaded dynamic libraries

Hi Please help me review the following small enhancement: Webrev: http://cr.openjdk.java.net/~farvidsson/8031304/webrev.00/ Jira: https://bugs.openjdk.java.net/browse/JDK-8031304 /Fredrik

Re: RFR (S): 6380601: MISC_REGRESSION tests need to be more resilient to ps cmd problems

Thank you for reviewing this! Unfortunantely I can't use Basic.java since we don't use packages for jtreg tests. Should I use "2005 - 2014" instead of "2005, 2011, 2014"? Thanks, Katja On 01/13/2014 12:33 PM, Alan Bateman wrote: On 13/01/2014 10:40, Yekaterina Kantserova wrote: Hi, Coul

Re: RFR (S): 6380601: MISC_REGRESSION tests need to be more resilient to ps cmd problems

Thank you for reviewing this! Yes, I completely agree the tests are *very* basic, but I've decided it's more important to fix them as they are for the moment. I can open en enhancement that sun tools need more tests. Thanks, Katja On 01/13/2014 12:31 PM, Staffan Larsen wrote: The changes l

Re: RFR 8028623: SA: hash codes in SymbolTable mismatching java_lang_String::hash_code for extended characters.

Looks good! Thanks for taking the time to re-write the test in Java. Thanks, /Staffan On 8 jan 2014, at 15:59, Kevin Walls wrote: > > Hi Staffan - > > http://cr.openjdk.java.net/~kevinw/8028623/webrev.01/ > > Yes it's better now, getting pid and launching a tool etc have been previous > rea

Re: [PATCH] 7142035 assert in j.l.instrument agents during shutdown when daemon thread is running

On 8 jan 2014, at 16:48, Chan, Sunny wrote: > In terms of the bug fix itself does it look fine? Yes, it does. Thanks, /Staffan

Re: RFR (S): 7185591: jcmd-big-script.sh ERROR: could not find app's Java pid.

Katja, test/lib/testlibrary/jdk/testlibrary/JcmdBase.java 68 * Run jcmd standalone I think you should expand a bit on what “standalone” means here. It took me a while to understand the difference. test/lib/testlibrary/jdk/testlibrary/OutputAnalyzer.java 423 public int indexOf(String p

Re: RFR(M): 8030812 : Change the solaris DTrace implementation to use USDT2 instead of USDT1

Staffan, Looks good for me. -Dmitry On 2014-01-13 14:30, Staffan Larsen wrote: > I’m still looking for a Review of this change (I know it’s nobody’s favorite > code…). > > Thanks, > /Staffan > > On 20 dec 2013, at 12:58, Staffan Larsen wrote: > >> The DTrace static probe implementation in H

Re: RFR (S): 6380601: MISC_REGRESSION tests need to be more resilient to ps cmd problems

On 13/01/2014 10:40, Yekaterina Kantserova wrote: Hi, Could I please have a review of this fix. I've rewritten the shell tests sun/tools/jstack and sun/tools/jmap in pure Java to get rid of environmental problems. The com/sun/tools/attach tests has already been fixed. Webrev: http://cr.ope

Re: RFR (S): 6380601: MISC_REGRESSION tests need to be more resilient to ps cmd problems

The changes look good, although the tests are *very* basic. Probably does not make sense to improve the tests as part of this change, though. /Staffan On 13 jan 2014, at 11:40, Yekaterina Kantserova wrote: > Hi, > > Could I please have a review of this fix. > > I've rewritten the shell test

RFR (S): 6380601: MISC_REGRESSION tests need to be more resilient to ps cmd problems

Hi, Could I please have a review of this fix. I've rewritten the shell tests sun/tools/jstack and sun/tools/jmap in pure Java to get rid of environmental problems. The com/sun/tools/attach tests has already been fixed. Webrev: http://cr.openjdk.java.net/~ykantser/6380601/webrev.00/ Bug: ht

Re: RFR(M): 8030812 : Change the solaris DTrace implementation to use USDT2 instead of USDT1

I’m still looking for a Review of this change (I know it’s nobody’s favorite code…). Thanks, /Staffan On 20 dec 2013, at 12:58, Staffan Larsen wrote: > The DTrace static probe implementation in Hotspot was written with an earlier > version of DTrace. With newer versions, DTrace can create a h