Hi Serguei,
On 28/02/2014 1:50 PM, serguei.spit...@oracle.com wrote:
Please, review the fix for:
https://bugs.openjdk.java.net/browse/JDK-6471769
Open webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2014/hotspot/6471769-JVMTI-DEPTH.3
Summary:
It is another attempt to fix the JTRE
Please, review the fix for:
https://bugs.openjdk.java.net/browse/JDK-6471769
Open webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2014/hotspot/6471769-JVMTI-DEPTH.3
Summary:
It is another attempt to fix the JTREG com/sun/jdi tests regression
discovered in the first round change.
T
On 2/27/14 9:20 AM, Pavel Punegov wrote:
Please review the fix for:
https://bugs.openjdk.java.net/browse/JDK-6946101
webrev:
http://cr.openjdk.java.net/~iignatyev/ppunegov/6946101/webrev.00/
test/com/sun/jdi/ShellScaffold.sh
line 531: # allows JDB to exit"
stray double-quote
On 2/27/14 1:03 PM, serguei.spit...@oracle.com wrote:
On 2/27/14 12:28 PM, serguei.spit...@oracle.com wrote:
Dan,
Thank you a lot for reviewing this!
On 2/27/14 11:09 AM, Daniel D. Daugherty wrote:
On 2/27/14 1:25 AM, serguei.spit...@oracle.com wrote:
Please, review the fix for:
https://bu
On 2/27/14 12:28 PM, serguei.spit...@oracle.com wrote:
Dan,
Thank you a lot for reviewing this!
On 2/27/14 11:09 AM, Daniel D. Daugherty wrote:
On 2/27/14 1:25 AM, serguei.spit...@oracle.com wrote:
Please, review the fix for:
https://bugs.openjdk.java.net/browse/JDK-6471769
Open webrev:
h
Looks okay to me.
Mandy
On 2/27/14 7:34 AM, roger riggs wrote:
Hi Mandy,
I updated the webrev:
http://cr.openjdk.java.net/~rriggs/webrev-testlibrary-asserts-8035889/
Alan suggested copying serviceability-dev so they have a chance to
review if desired.
I want to investigate if it is possibl
Dan,
Thank you a lot for reviewing this!
On 2/27/14 11:09 AM, Daniel D. Daugherty wrote:
On 2/27/14 1:25 AM, serguei.spit...@oracle.com wrote:
Please, review the fix for:
https://bugs.openjdk.java.net/browse/JDK-6471769
Open webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2014/hotspot
On 2/27/14 1:25 AM, serguei.spit...@oracle.com wrote:
Please, review the fix for:
https://bugs.openjdk.java.net/browse/JDK-6471769
Open webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2014/hotspot/6471769-JVMTI-DEPTH.2
src/share/vm/runtime/vm_operations.hpp
No comments.
src/shar
Please review the fix for:
https://bugs.openjdk.java.net/browse/JDK-6946101
webrev:
http://cr.openjdk.java.net/~iignatyev/ppunegov/6946101/webrev.00/
This change fixes two issues with the tests:
1. Fix incorrect 'quit' command sending to JDB when JDB process was finished.
2. Improve JDB
Mattias Tobiasson wrote:
Hi, thanks for the fast reviews.
I did think about stop calling loadNext() after the flag has been set. The main
reason for not doing that was just because I wanted to change as little as
possible. Now the test works as originally intended.
I prefer to do like this
Hi Mandy,
I updated the webrev:
http://cr.openjdk.java.net/~rriggs/webrev-testlibrary-asserts-8035889/
Alan suggested copying serviceability-dev so they have a chance to
review if desired.
I want to investigate if it is possible to use the TestNG Assert classes
without
the TestNG execution
Please, review the addition of the jstat related test.
Issue : https://bugs.openjdk.java.net/browse/JDK-8035668
Webrev: http://cr.openjdk.java.net/~jbachorik/8035668/webrev.00/
The test logic is simple - first the application to be monitored is
started. When the application is ready jstat is la
Still waiting for review.
On 2014-02-21 20:08, Dmitry Samersoff wrote:
> On 2014-02-14 18:52, Dmitry Samersoff wrote:
>> Hi Everyone,
>>
>> Please, review the changes.
>>
>> http://cr.openjdk.java.net/~dsamersoff/JDK-7189721/webrev.01/
>>
>> Summary:
>>
>> If for some reason elf section with secti
Hi, thanks for the fast reviews.
I did think about stop calling loadNext() after the flag has been set. The main
reason for not doing that was just because I wanted to change as little as
possible. Now the test works as originally intended.
I do not mind removing the calls to loadNext(), but the
Daniel Fuchs wrote:
On 2/27/14 11:43 AM, Mattias Tobiasson wrote:
Hi,
Could you please review this test fix.
The test verifies that MemoryPoolMXBean sends a notification when
used memory has reached the threshold.
The flag thresholdExceeded marks if we have reached the memory
threshold. When
On 27 feb 2014, at 12:39, taras ledkov wrote:
> Staffan, Excuse me.
No problem.
> I didn't know about that.
> I looked at the http://openjdk.java.net/census#serviceability.
In this case the relevant project is jdk9 since that is where the change should
happen: http://openjdk.java.net/census#
On 2/27/14 11:43 AM, Mattias Tobiasson wrote:
Hi,
Could you please review this test fix.
The test verifies that MemoryPoolMXBean sends a notification when used memory
has reached the threshold.
The flag thresholdExceeded marks if we have reached the memory threshold. When
the flag is set, the
On 27.2.2014 12:39, taras ledkov wrote:
Staffan, Excuse me.
I didn't know about that.
I looked at the http://openjdk.java.net/census#serviceability.
Now I'm in need of the second review.
You only need one Reviewer to approve. The other approvals may come from
non-Reviewers.
-JB-
On 26.02
Staffan, Excuse me.
I didn't know about that.
I looked at the http://openjdk.java.net/census#serviceability.
Now I'm in need of the second review.
On 26.02.2014 18:36, Staffan Larsen wrote:
On 26 feb 2014, at 15:24, taras ledkov wrote:
Hi,
Alan, Mandy could you please review the fix:
http
Looks good!
Thanks,
/Staffan
On 27 feb 2014, at 11:43, Mattias Tobiasson
wrote:
> Hi,
> Could you please review this test fix.
>
> The test verifies that MemoryPoolMXBean sends a notification when used memory
> has reached the threshold.
> The flag thresholdExceeded marks if we have reached
Hi,
Could you please review this test fix.
The test verifies that MemoryPoolMXBean sends a notification when used memory
has reached the threshold.
The flag thresholdExceeded marks if we have reached the memory threshold. When
the flag is set, the test slows down to give time for the notificatio
Please, review the fix for:
https://bugs.openjdk.java.net/browse/JDK-6471769
Open webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2014/hotspot/6471769-JVMTI-DEPTH.2
Summary:
It is the 2-nd round of review because the JTREG com/sun/jdi tests
discovered a regression
in the first roun
22 matches
Mail list logo