Re: 3-nd round RFR 6471769: Error: assert(_cur_stack_depth == count_frames(), "cur_stack_depth out of sync")

2014-02-27 Thread David Holmes
Hi Serguei, On 28/02/2014 1:50 PM, serguei.spit...@oracle.com wrote: Please, review the fix for: https://bugs.openjdk.java.net/browse/JDK-6471769 Open webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2014/hotspot/6471769-JVMTI-DEPTH.3 Summary: It is another attempt to fix the JTRE

3-nd round RFR 6471769: Error: assert(_cur_stack_depth == count_frames(), "cur_stack_depth out of sync")

2014-02-27 Thread serguei.spit...@oracle.com
Please, review the fix for: https://bugs.openjdk.java.net/browse/JDK-6471769 Open webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2014/hotspot/6471769-JVMTI-DEPTH.3 Summary: It is another attempt to fix the JTREG com/sun/jdi tests regression discovered in the first round change. T

Re: RFR 6946101: ShellScaffold.sh based tests can issue "write error: Broken pipe" messages

2014-02-27 Thread Daniel D. Daugherty
On 2/27/14 9:20 AM, Pavel Punegov wrote: Please review the fix for: https://bugs.openjdk.java.net/browse/JDK-6946101 webrev: http://cr.openjdk.java.net/~iignatyev/ppunegov/6946101/webrev.00/ test/com/sun/jdi/ShellScaffold.sh line 531: # allows JDB to exit" stray double-quote

Re: 2-nd round RFR 6471769: Error: assert(_cur_stack_depth == count_frames(), "cur_stack_depth out of sync")

2014-02-27 Thread serguei.spit...@oracle.com
On 2/27/14 1:03 PM, serguei.spit...@oracle.com wrote: On 2/27/14 12:28 PM, serguei.spit...@oracle.com wrote: Dan, Thank you a lot for reviewing this! On 2/27/14 11:09 AM, Daniel D. Daugherty wrote: On 2/27/14 1:25 AM, serguei.spit...@oracle.com wrote: Please, review the fix for: https://bu

Re: 2-nd round RFR 6471769: Error: assert(_cur_stack_depth == count_frames(), "cur_stack_depth out of sync")

2014-02-27 Thread serguei.spit...@oracle.com
On 2/27/14 12:28 PM, serguei.spit...@oracle.com wrote: Dan, Thank you a lot for reviewing this! On 2/27/14 11:09 AM, Daniel D. Daugherty wrote: On 2/27/14 1:25 AM, serguei.spit...@oracle.com wrote: Please, review the fix for: https://bugs.openjdk.java.net/browse/JDK-6471769 Open webrev: h

Re: RFR 9: 8035889: jdk testlibrary - add printing of values of failed assertions

2014-02-27 Thread Mandy Chung
Looks okay to me. Mandy On 2/27/14 7:34 AM, roger riggs wrote: Hi Mandy, I updated the webrev: http://cr.openjdk.java.net/~rriggs/webrev-testlibrary-asserts-8035889/ Alan suggested copying serviceability-dev so they have a chance to review if desired. I want to investigate if it is possibl

Re: 2-nd round RFR 6471769: Error: assert(_cur_stack_depth == count_frames(), "cur_stack_depth out of sync")

2014-02-27 Thread serguei.spit...@oracle.com
Dan, Thank you a lot for reviewing this! On 2/27/14 11:09 AM, Daniel D. Daugherty wrote: On 2/27/14 1:25 AM, serguei.spit...@oracle.com wrote: Please, review the fix for: https://bugs.openjdk.java.net/browse/JDK-6471769 Open webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2014/hotspot

Re: 2-nd round RFR 6471769: Error: assert(_cur_stack_depth == count_frames(), "cur_stack_depth out of sync")

2014-02-27 Thread Daniel D. Daugherty
On 2/27/14 1:25 AM, serguei.spit...@oracle.com wrote: Please, review the fix for: https://bugs.openjdk.java.net/browse/JDK-6471769 Open webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2014/hotspot/6471769-JVMTI-DEPTH.2 src/share/vm/runtime/vm_operations.hpp No comments. src/shar

RFR 6946101: ShellScaffold.sh based tests can issue "write error: Broken pipe" messages

2014-02-27 Thread Pavel Punegov
Please review the fix for: https://bugs.openjdk.java.net/browse/JDK-6946101 webrev: http://cr.openjdk.java.net/~iignatyev/ppunegov/6946101/webrev.00/ This change fixes two issues with the tests: 1. Fix incorrect 'quit' command sending to JDB when JDB process was finished. 2. Improve JDB

Re: RFR(XS) 8031065: LowMemoryTest2.sh fails: OutOfMemoryError: Metaspace

2014-02-27 Thread shanliang
Mattias Tobiasson wrote: Hi, thanks for the fast reviews. I did think about stop calling loadNext() after the flag has been set. The main reason for not doing that was just because I wanted to change as little as possible. Now the test works as originally intended. I prefer to do like this

Re: RFR 9: 8035889: jdk testlibrary - add printing of values of failed assertions

2014-02-27 Thread roger riggs
Hi Mandy, I updated the webrev: http://cr.openjdk.java.net/~rriggs/webrev-testlibrary-asserts-8035889/ Alan suggested copying serviceability-dev so they have a chance to review if desired. I want to investigate if it is possible to use the TestNG Assert classes without the TestNG execution

RFR 8035668: [test] Check that jstat does not cause problems when monitored application exits before jstat finishes its work

2014-02-27 Thread Jaroslav Bachorik
Please, review the addition of the jstat related test. Issue : https://bugs.openjdk.java.net/browse/JDK-8035668 Webrev: http://cr.openjdk.java.net/~jbachorik/8035668/webrev.00/ The test logic is simple - first the application to be monitored is started. When the application is ready jstat is la

Re: PING Re: RR(S): JDK-7189721 nightly tests failed on JDI attaching

2014-02-27 Thread Dmitry Samersoff
Still waiting for review. On 2014-02-21 20:08, Dmitry Samersoff wrote: > On 2014-02-14 18:52, Dmitry Samersoff wrote: >> Hi Everyone, >> >> Please, review the changes. >> >> http://cr.openjdk.java.net/~dsamersoff/JDK-7189721/webrev.01/ >> >> Summary: >> >> If for some reason elf section with secti

Re: RFR(XS) 8031065: LowMemoryTest2.sh fails: OutOfMemoryError: Metaspace

2014-02-27 Thread Mattias Tobiasson
Hi, thanks for the fast reviews. I did think about stop calling loadNext() after the flag has been set. The main reason for not doing that was just because I wanted to change as little as possible. Now the test works as originally intended. I do not mind removing the calls to loadNext(), but the

Re: RFR(XS) 8031065: LowMemoryTest2.sh fails: OutOfMemoryError: Metaspace

2014-02-27 Thread shanliang
Daniel Fuchs wrote: On 2/27/14 11:43 AM, Mattias Tobiasson wrote: Hi, Could you please review this test fix. The test verifies that MemoryPoolMXBean sends a notification when used memory has reached the threshold. The flag thresholdExceeded marks if we have reached the memory threshold. When

Re: Review request for 7195249: Some jtreg tests use hard coded ports

2014-02-27 Thread Staffan Larsen
On 27 feb 2014, at 12:39, taras ledkov wrote: > Staffan, Excuse me. No problem. > I didn't know about that. > I looked at the http://openjdk.java.net/census#serviceability. In this case the relevant project is jdk9 since that is where the change should happen: http://openjdk.java.net/census#

Re: RFR(XS) 8031065: LowMemoryTest2.sh fails: OutOfMemoryError: Metaspace

2014-02-27 Thread Daniel Fuchs
On 2/27/14 11:43 AM, Mattias Tobiasson wrote: Hi, Could you please review this test fix. The test verifies that MemoryPoolMXBean sends a notification when used memory has reached the threshold. The flag thresholdExceeded marks if we have reached the memory threshold. When the flag is set, the

Re: Review request for 7195249: Some jtreg tests use hard coded ports

2014-02-27 Thread Jaroslav Bachorik
On 27.2.2014 12:39, taras ledkov wrote: Staffan, Excuse me. I didn't know about that. I looked at the http://openjdk.java.net/census#serviceability. Now I'm in need of the second review. You only need one Reviewer to approve. The other approvals may come from non-Reviewers. -JB- On 26.02

Re: Review request for 7195249: Some jtreg tests use hard coded ports

2014-02-27 Thread taras ledkov
Staffan, Excuse me. I didn't know about that. I looked at the http://openjdk.java.net/census#serviceability. Now I'm in need of the second review. On 26.02.2014 18:36, Staffan Larsen wrote: On 26 feb 2014, at 15:24, taras ledkov wrote: Hi, Alan, Mandy could you please review the fix: http

Re: RFR(XS) 8031065: LowMemoryTest2.sh fails: OutOfMemoryError: Metaspace

2014-02-27 Thread Staffan Larsen
Looks good! Thanks, /Staffan On 27 feb 2014, at 11:43, Mattias Tobiasson wrote: > Hi, > Could you please review this test fix. > > The test verifies that MemoryPoolMXBean sends a notification when used memory > has reached the threshold. > The flag thresholdExceeded marks if we have reached

RFR(XS) 8031065: LowMemoryTest2.sh fails: OutOfMemoryError: Metaspace

2014-02-27 Thread Mattias Tobiasson
Hi, Could you please review this test fix. The test verifies that MemoryPoolMXBean sends a notification when used memory has reached the threshold. The flag thresholdExceeded marks if we have reached the memory threshold. When the flag is set, the test slows down to give time for the notificatio

2-nd round RFR 6471769: Error: assert(_cur_stack_depth == count_frames(), "cur_stack_depth out of sync")

2014-02-27 Thread serguei.spit...@oracle.com
Please, review the fix for: https://bugs.openjdk.java.net/browse/JDK-6471769 Open webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2014/hotspot/6471769-JVMTI-DEPTH.2 Summary: It is the 2-nd round of review because the JTREG com/sun/jdi tests discovered a regression in the first roun