Hi Dmitri,
Thank you for the review.
You're right, the code gets cleaner this way.
New webrev:
http://www.sapjvm.com/as/webrevs/803_3/
Thanks,
Axel
On 17.03.2014 23:01, Dmitry Samersoff wrote:
Axel,
The changes it self looks good for me.
But it looks like the owning_thread is always
The serviceability libraries (as defined by
jdk/make/lib/ServiceabilityLibraries.gmk) should be compiled with warnings as
errors. To enable this all current warnings need to be fixed.
The background for this is that we recently had a bug that could have easily
been avoided if we had paid
On 2014-03-19 13:30, Staffan Larsen wrote:
The serviceability libraries (as defined by jdk/make/lib/ServiceabilityLibraries.gmk)
should be compiled with warnings as errors. To enable this all current
warnings need to be fixed.
The background for this is that we recently had a bug that could
Hello,
Nice work! Removing warnings and enforcing them is definitely something
we like.
For the makefile change, ideally the new variable WARNINGS_ARE_ERRORS
should be set in configure. I would suggest flags.m4, in
FLAGS_SETUP_COMPILER_FLAGS_MISC. Also, instead of making the conditional
on
Greetings,
I'm writing special purpose java agent to compute sizes of classes
loaded in perm gen. Basically reimplementing some functionality of jmap
-permstat. But in order to do that, I need to get instances of
InstanceKlass for all loaded classes.
I've looked up PermStat source code, and
Erik, Magnus,
Thanks for the quick looks. Here is an updated version that adds the new
variable to flags.m4 instead.
http://cr.openjdk.java.net/~sla/8037825/webrev.01/root/
http://cr.openjdk.java.net/~sla/8037825/webrev.01/jdk/
Thanks,
/Staffan
On 19 mar 2014, at 14:03, Erik Joelsson
When I fixed JDK-8036599 I added a few too many test cases to Basic.sh. The SA
does not support the -flag option. This fix removes those tests.
webrev: http://cr.openjdk.java.net/~sla/8037225/webrev.00/
bug: https://bugs.openjdk.java.net/browse/JDK-8037225
Thanks,
/Staffan
Looks good for me!
-Dmitry
On 2014-03-19 18:27, Staffan Larsen wrote:
When I fixed JDK-8036599 I added a few too many test cases to Basic.sh. The
SA does not support the -flag option. This fix removes those tests.
webrev: http://cr.openjdk.java.net/~sla/8037225/webrev.00/
bug:
Hi Sergei,
Are you using PermStat in the context of Serviceability Agent? In other
words, is the agent you're writing a Serviceability Agent, or something
else, like a Java agent as in java.lang.instrument, or a JVMTI agent?
SA uses different means to connect to the target VM from the other types
Please review the change below to add
java/lang/instrument/NativeMethodPrefixAgent.java to ProblemList.txt. The test
has started to fail since JDK-8035808 and requires a large re-write to handle
new byte codes.
Thanks,
/Staffan
diff --git a/test/ProblemList.txt b/test/ProblemList.txt
---
Build part looks good!
Don't forget to push the closed generated configure.
/Erik
On 2014-03-19 15:20, Staffan Larsen wrote:
Erik, Magnus,
Thanks for the quick looks. Here is an updated version that adds the new
variable to flags.m4 instead.
On 19/03/2014 16:05, Staffan Larsen wrote:
Please review the change below to add
java/lang/instrument/NativeMethodPrefixAgent.java to ProblemList.txt. The test
has started to fail since JDK-8035808 and requires a large re-write to handle
new byte codes.
Thanks,
/Staffan
Looks fine,
Hi Mattias,
On 3/14/2014 6:21 AM, Mattias Tobiasson wrote:
Hi,
I have updated the patch to include all failing tests for this bug.
The tests currently fail because their GC options collide with GC options from
the test framework.
The fix will launch the tests in a separate JVM with controlled
On 19 mar 2014, at 17:47, Erik Joelsson erik.joels...@oracle.com wrote:
Build part looks good!
Thanks.
Don't forget to push the closed generated configure.
I would have forgotten…
/Staffan
/Erik
On 2014-03-19 15:20, Staffan Larsen wrote:
Erik, Magnus,
Thanks for the quick
Thank you for response, Kris!I’m writing both “Java agent” and JVMTI agent.Are you suggesting that I should write Serviceability Agent instead? If yes, then could you please pinpoint me into the right direction? Because it wasn’t clear to me how can I write my own custom Serviceability Agent.By
Thank you for response, Kris!I’m writing both “Java agent” and JVMTI agent.Are you suggesting that I should write Serviceability Agent instead? If yes, then could you please pinpoint me into the right direction? Because it wasn’t clear to me how can I write my own custom Serviceability Agent.By
Hi Sergei,
jmap -permstat, or PermStat itself is an utility based on the
Serviceability Agent.
For your reference, I've written other utilities based on SA, some of them
listed here: http://rednaxelafx.iteye.com/blog/1814429
The easiest way to write your own custom SA-based tool is to inherit
Hi Dmitry,
Looks good, if you're still needing comments.
Always amazing what a good load of nightly testing can find!
Regards
Kevin
On 05/03/14 20:29, Dmitry Samersoff wrote:
Serguei,
Thank you for the review. You are the first reviewer.
-Dmitry
On 2014-03-06 00:25,
18 matches
Mail list logo
