JEP 167

Hi all! What's the state of JEP 167? http://openjdk.java.net/jeps/167 I was trying to understand what kind of events have been added and how I can retrieve them from the outside world, but documentation seems to be quite lacking and it's difficult to find everything. I'm also interested in addi

Re: RFR(XS): 8043264: hsdis library not picked up correctly on expected paths

On 15 maj 2014, at 22:19, Krystal Mok wrote: > Hi everyone, > > May I have a couple of review for this small patch, please? > > *Bug*: https://bugs.openjdk.java.net/browse/JDK-8043264 > > *Patch*: (against jdk9/hs) > > diff -r 466b58fa837b src/share/vm/compiler/disassembler.cpp > --- a/src/s

Re: RFR(S): JDK-8041435 Make JDWP socket connector accept only local connections by default

On 5/15/14 3:20 PM, serguei.spit...@oracle.com wrote: Dmitry, I've reviewed the .01 webrev. Sorry, wanted to say .02 webrev. Thanks, Serguei src/share/transport/socket/socketTransport.c Lines 197-240: to be consistent with the rest of the file the indent must be 4, not 2. The comment at

Re: RFR(XS): 8043264: hsdis library not picked up correctly on expected paths

Hi Mark, Thank you for your reply. No, my public key was re-added a while ago, and I was able to upload a couple of webrevs with that public key, e.g.: http://cr.openjdk.java.net/~kmo/8003585/ Could there have been issues around the recent maintenance to cr.openjdk.java.net? Thanks, Kris On Th

Re: RFR(S): JDK-8041435 Make JDWP socket connector accept only local connections by default

Dmitry, I've reviewed the .01 webrev. src/share/transport/socket/socketTransport.c Lines 197-240: to be consistent with the rest of the file the indent must be 4, not 2. The comment at the line 200 is better to start from capital letter: "It looks up ..." 202 struct addrinfo hints, *res;

Re: RFR(XS): 8043264: hsdis library not picked up correctly on expected paths

2014/5/15 6:19 -0700, rednaxel...@gmail.com: > ... > > P.S. I wanted to upload a webrev, but somehow I couldn't get the the > connection to work. Could it be that my publickey is missing on > cr.openjdk.java.net? Your public key was removed when you left Oracle. Now that you work for Azul you're

RFR(XS): 8043264: hsdis library not picked up correctly on expected paths

Hi everyone, May I have a couple of review for this small patch, please? *Bug*: https://bugs.openjdk.java.net/browse/JDK-8043264 *Patch*: (against jdk9/hs) diff -r 466b58fa837b src/share/vm/compiler/disassembler.cpp --- a/src/share/vm/compiler/disassembler.cpp Thu May 15 11:35:26 2014 -0700 +++

Re: RFR(S): JDK-8041435 Make JDWP socket connector accept only local connections by default

Dan, Thank you for the review. Next version is: http://cr.openjdk.java.net/~dsamersoff/JDK-8041435/webrev.02/ please, see below. On 2014-05-15 19:58, Daniel D. Daugherty wrote: > On 5/15/14 5:50 AM, Dmitry Samersoff wrote: >> Hi Everyone, >> >> Please review the fix: >> >> http://cr.openjdk.jav

Re: RFR(S): JDK-8041435 Make JDWP socket connector accept only local connections by default

On 5/15/14 5:50 AM, Dmitry Samersoff wrote: Hi Everyone, Please review the fix: http://cr.openjdk.java.net/~dsamersoff/JDK-8041435/webrev.01/ src/share/transport/socket/socketTransport.c line 200: // it lookups "localhost" and return 127.0.0.1 if lookup Typo: "it lookups" -> "it

RFR(S): JDK-8041435 Make JDWP socket connector accept only local connections by default

Hi Everyone, Please review the fix: http://cr.openjdk.java.net/~dsamersoff/JDK-8041435/webrev.01/ After the fix, JDWP server attempts to guess localhost address and bind to it only if no address is specified in command line but user can explicitly bind server to all of available addresses by usi

Re: RFR: 8032901: WaitForMultipleObjects() return value not handled appropriately

On 15 maj 2014, at 03:48, David Holmes wrote: > On 14/05/2014 11:18 PM, Aleksej Efimov wrote: >> David, Vitaly, >> >> I totally agree with Vitaly's explanation (Vitaly - thank you for that) >> and code in shmemBase.c (the usage of enterMutex() function for >> sending/receiving bytes through sha