Re: RFR: 8064799: [TESTBUG] JT-Reg Serviceability tests to be run as part of JPRT submit job

2014-11-13 Thread Staffan Larsen
Looks good! Thanks, /Staffan > On 13 nov 2014, at 16:53, Mikael Auno wrote: > > On 2014-11-13 14:56, Mikael Auno wrote: >> Hi, >> >> Could I please get a review of this addition of SVC tests to JPRT submit >> jobs. So far, I'm only adding JDI tests as those are the only ones I >> have complete

Re: RFR: 8064799: [TESTBUG] JT-Reg Serviceability tests to be run as part of JPRT submit job

2014-11-13 Thread David Holmes
Hi Mikael, So to be clear this adds the JDK JDI tests (select subset thereof) to "-testset hotspot" for full forest submissions to JPRT. Test overhead seems okay. Hopefully the test stability will be exhibited in JPRT as well as other testing. Ok. David On 14/11/2014 1:53 AM, Mikael Auno

Re: RFR(S) Solaris Full Debug Symbols (FDS) fix for 8033602 and 8034005

2014-11-13 Thread David Holmes
On 14/11/2014 4:18 AM, Daniel D. Daugherty wrote: Magnus, Thanks for the review! Replies embedded below... On 11/13/14 7:44 AM, Magnus Ihse Bursie wrote: On 2014-11-11 01:00, Daniel D. Daugherty wrote: Greetings, I have a Solaris Full Debug Symbols (FDS) fix ready for review. Yes, it is a s

Re: RFR(S) Solaris Full Debug Symbols (FDS) fix for 8033602 and 8034005

2014-11-13 Thread Daniel D. Daugherty
Magnus, Thanks for the review! Replies embedded below... On 11/13/14 7:44 AM, Magnus Ihse Bursie wrote: On 2014-11-11 01:00, Daniel D. Daugherty wrote: Greetings, I have a Solaris Full Debug Symbols (FDS) fix ready for review. Yes, it is a small fix, but it is in Makefiles so feel free to ru

Re: RFR(XS): JDK-8062037 java/lang/instrument/RetransformBigClass.sh should be quarantined

2014-11-13 Thread olivier.lagn...@oracle.com
Thanks Dan and Serguey for the quick reply. I will change 8062037 reference to 8061177 in ProblemList.txt before pushing. Olivier. On 12/11/2014 19:22, Daniel D. Daugherty wrote: Thumbs up on the quarantine. However, I think the bug reference in ProblemList.txt should be 8061177 and not the

Re: RFR: 8064799: [TESTBUG] JT-Reg Serviceability tests to be run as part of JPRT submit job

2014-11-13 Thread serguei.spit...@oracle.com
It looks good. Thanks, Serguei On 11/13/14 7:53 AM, Mikael Auno wrote: On 2014-11-13 14:56, Mikael Auno wrote: Hi, Could I please get a review of this addition of SVC tests to JPRT submit jobs. So far, I'm only adding JDI tests as those are the only ones I have completed code coverage analysi

Re: RFR: 8064799: [TESTBUG] JT-Reg Serviceability tests to be run as part of JPRT submit job

2014-11-13 Thread Mikael Auno
On 2014-11-13 14:56, Mikael Auno wrote: > Hi, > > Could I please get a review of this addition of SVC tests to JPRT submit > jobs. So far, I'm only adding JDI tests as those are the only ones I > have completed code coverage analysis on to determine the best subset to > add. The other areas will b

Re: RFR(S) Solaris Full Debug Symbols (FDS) fix for 8033602 and 8034005

2014-11-13 Thread Magnus Ihse Bursie
On 2014-11-11 01:00, Daniel D. Daugherty wrote: Greetings, I have a Solaris Full Debug Symbols (FDS) fix ready for review. Yes, it is a small fix, but it is in Makefiles so feel free to run screaming from the room... :-) On the plus side the fix does delete two work around source files (Coleen

RFR: 8064799: [TESTBUG] JT-Reg Serviceability tests to be run as part of JPRT submit job

2014-11-13 Thread Mikael Auno
Hi, Could I please get a review of this addition of SVC tests to JPRT submit jobs. So far, I'm only adding JDI tests as those are the only ones I have completed code coverage analysis on to determine the best subset to add. The other areas will be added too, but I'm adding these now to get the bal

Re: Fwd: Re: RFR: 8062536: [TESTBUG] Conflicting GC combinations in jdk tests

2014-11-13 Thread Evgeniya Stepanova
Hi Bengt! Ok, I'll remove this string. Thank you for reviewing it one more time :) Evgeniya Stepanova On 13.11.2014 13:44, Bengt Rutisson wrote: Hi Evgeniya, On 2014-11-12 17:07, Evgeniya Stepanova wrote: Hi Bengt, Please see comments inline On 12.11.2014 19:43, Bengt Rutisson wrote: On

Re: Fwd: Re: RFR: 8062536: [TESTBUG] Conflicting GC combinations in jdk tests

2014-11-13 Thread Bengt Rutisson
Hi Evgeniya, On 2014-11-12 17:07, Evgeniya Stepanova wrote: Hi Bengt, Please see comments inline On 12.11.2014 19:43, Bengt Rutisson wrote: On 2014-11-12 16:21, Evgeniya Stepanova wrote: Hi everyone! Since the decision was made to change only tests which fail because of conflict for now (