On 2014-11-13 14:56, Mikael Auno wrote:
> Hi,
>
> Could I please get a review of this addition of SVC tests to JPRT submit
> jobs. So far, I'm only adding JDI tests as those are the only ones I
> have completed code coverage analysis on to determine the best subset to
> add. The other areas will be added too, but I'm adding these now to get
> the ball rolling asap.
>
> I've run these through JPRT once already without failures and have got
> two more runs in the pipe. I've also looked through the history for
> these tests and found that they do not have any known instabilities to
> worry about.
>
> Issue: https://bugs.openjdk.java.net/browse/JDK-8064799
> Webrev: http://cr.openjdk.java.net/~miauno/8064799/webrev.00/
The additional JPRT runs have completed now and have no failures. Here
are also the duration (in seconds) for each test on each platform to in
case anyone wonders ("com/sun/jdi" prefix stripped out):
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------
> | | lin_i586-c1 | lin_i586-c2 | lin_x64-c2 |
> osx_x64-c2 | sol_sparcv9-c2 | sol_x64-c2 | win_i586-c1 | win_i586-c2 |
> win_x64-c2 |
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------
> | .../AcceptTimeout | 1.24 | 1.277 | 1.308 |
> 1.349 | 1.54 | 1.204 | 2.184 | 2.293 |
> 2.34 |
> | .../AccessSpecifierTest | 1.689 | 1.883 | 2.021 |
> 2.303 | 4.892 | 2.048 | 1.332 | 1.707 |
> 2.19 |
> | .../AfterThreadDeathTest | 0.855 | 0.748 | 0.815 |
> 0.605 | 1.098 | 0.691 | 0.299 | 0.424 |
> 1.683 |
> | .../ArrayRangeTest | 0.659 | 0.823 | 0.794 |
> 0.702 | 1.445 | 0.837 | 0.783 | 0.503 |
> 1.267 |
> | .../ConstantPoolInfo | 0.589 | 0.74 | 0.791 |
> 0.621 | 1.067 | 0.607 | 0.315 | 0.408 |
> 0.674 |
> | .../CountFilterTest | 0.588 | 0.638 | 0.729 |
> 0.617 | 1.068 | 0.618 | 0.3 | 0.502 |
> 0.674 |
> | .../EarlyReturnNegativeTest | 0.724 | 0.8 | 0.824 |
> 0.675 | 1.186 | 0.642 | 0.362 | 0.627 |
> 0.736 |
> | .../EarlyReturnTest | 1.218 | 1.164 | 1.295 |
> 1.207 | 1.962 | 1.307 | 0.72 | 1.189 |
> 1.242 |
> | .../FieldWatchpoints | 0.616 | 0.628 | 0.728 |
> 0.6 | 1.052 | 0.683 | 0.3 | 0.408 |
> 0.674 |
> | .../FramesTest | 0.598 | 0.696 | 0.741 |
> 0.601 | 1.006 | 0.592 | 0.299 | 0.425 |
> 0.627 |
> | .../InstanceFilter | 0.604 | 0.677 | 0.696 |
> 0.587 | 1.005 | 0.608 | 0.284 | 0.393 |
> 0.69 |
> | .../InterfaceMethodsTest | 0.706 | 0.83 | 0.837 |
> 0.69 | 1.193 | 0.762 | 0.362 | 1.032 |
> 0.752 |
> | .../InvokeTest | 0.719 | 0.788 | 0.861 |
> 0.71 | 1.196 | 0.647 | 0.377 | 0.752 |
> 0.721 |
> | .../LocalVariableEqual | 0.66 | 0.662 | 0.714 |
> 0.622 | 1.087 | 0.715 | 0.315 | 0.383 |
> 0.612 |
> | .../LocationTest | 0.639 | 0.651 | 0.688 |
> 0.715 | 1.014 | 0.612 | 0.299 | 0.362 |
> 0.58 |
> | .../ModificationWatchpoints | 0.764 | 0.789 | 0.872 |
> 0.726 | 1.375 | 0.668 | 0.424 | 0.502 |
> 0.877 |
> | .../MonitorEventTest | 0.597 | 0.638 | 0.69 |
> 1.608 | 1.03 | 0.648 | 0.284 | 0.377 |
> 0.689 |
> | .../MonitorFrameInfo | 0.622 | 0.652 | 0.731 |
> 0.596 | 1.014 | 0.592 | 0.299 | 0.456 |
> 0.612 |
> | .../NullThreadGroupNameTest | 0.602 | 0.702 | 0.733 |
> 0.588 | 1.045 | 0.572 | 0.299 | 0.362 |
> 0.58 |
> | .../PopAndStepTest | 0.318 | 0.351 | 0.416 |
> 0.593 | 0.989 | 0.713 | 0.3 | 0.455 |
> 0.752 |
> | .../PopAsynchronousTest | 0.718 | 0.869 | 0.8 |
> 0.654 | 1.063 | 0.619 | 0.519 | 0.581 |
> 0.737 |
> | .../ProcessAttachTest | 6.748 | 6.482 | 6.781 |
> 7.115 | 9.167 | 6.973 | 6.043 | 6.355 |
> 6.881 |
> | .../redefineMethod/RedefineTest | 3.678 | 3.743 | 4.072 |
> 5.207 | 7.081 | 3.757 | 2.976 | 3.568 |
> 4.723 |
> | .../ReferrersTest | 0.846 | 0.811 | 0.866 |
> 1.493 | 2.295 | 1.096 | 0.642 | 0.892 |
> 1.31 |
> | .../RequestReflectionTest | 0.642 | 0.644 | 0.706 |
> 0.59 | 1.172 | 0.584 | 0.3 | 0.737 |
> 0.736 |
> | .../ResumeOneThreadTest | 0.612 | 0.661 | 0.688 |
> 0.669 | 1.073 | 0.583 | 0.502 | 0.362 |
> 0.658 |
> | .../RunToExit | 1.434 | 1.454 | 1.462 |
> 1.215 | 1.182 | 1.188 | 1.126 | 1.126 |
> 1.22 |
> | .../sde/MangleTest | 0.739 | 0.976 | 0.9 |
> 0.72 | 1.295 | 0.703 | 0.486 | 0.752 |
> 1.11 |
> | .../sde/TemperatureTableTest | 0.923 | 0.986 | 0.992 |
> 0.784 | 1.368 | 0.846 | 0.502 | 0.892 |
> 0.908 |
> | .../SourceNameFilterTest | 1.246 | 1.365 | 1.45 |
> 1.246 | 2.041 | 1.215 | 0.599 | 1.051 |
> 1.316 |
> | .../VarargsTest | 0.713 | 0.763 | 0.814 |
> 0.718 | 1.183 | 0.654 | 0.393 | 0.533 |
> 0.924 |
> | .../Vars | 0.568 | 0.609 | 0.692 |
> 0.628 | 1.012 | 0.583 | 0.284 | 0.362 |
> 0.564 |
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------
> | Total | 33.874 | 35.564 | 37.507 |
> 37.754 | 57.196 | 34.567 | 24.509 | 30.771 |
> 40.059 |
>
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------
Thanks,
Mikael
