Hi Dmitry,
The fix looks good.
However, there are a couple of more places in that file
where the result of the jvmtiAllocate() is not checked:
68 utf8msg = (jbyte*)jvmtiAllocate(maxlen+1);
393 buf = jvmtiAllocate(len*3+3);
Could you fix this as well?
Thanks,
Serguei
On 12/
Hi Everybody,
Please review small fix.
http://cr.openjdk.java.net/~dsamersoff/JDK-8067030/webrev.01/
JDWP crash if allocation fails because it calls strcpy before
check of allocation results.
-Dmitry
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to
Volker,
I'll take a look at it.
-Dmitry
On 2014-12-09 21:10, Volker Simonis wrote:
> Hi,
>
> can somebody from the serviceability team please review this webrev?
>
> http://cr.openjdk.java.net/~simonis/webrevs/8049716
> https://bugs.openjdk.java.net/browse/JDK-8049716
>
> The shared changes a
Hi,
can somebody from the serviceability team please review this webrev?
http://cr.openjdk.java.net/~simonis/webrevs/8049716
https://bugs.openjdk.java.net/browse/JDK-8049716
The shared changes are really all trivial.
Thanks,
Volker
On Fri, Dec 5, 2014 at 4:01 PM, Volker Simonis wrote:
> Hi S
Hi there,
I'm the one who started the perf-map-agent project. Thanks, Brendan
and all others for having this discussion here.
On Fri, Dec 5, 2014 at 11:22 AM, Volker Simonis wrote:
> That said, I still don't know how perf creates stack traces. Does it
> attach to the process with ptrace or how el
Dmitry,
It looks good.
Than you for the update!
Serguei
On 12/9/14 5:51 AM, Dmitry Samersoff wrote:
Serguei,
Fixed. Webrev updated in-place, please press shift-reload.
http://cr.openjdk.java.net/~dsamersoff/JDK-8028773/webrev.03/
-Dmitry
On 2014-12-08 14:02, serguei.spit...@oracle.com wrot
Serguei,
Fixed. Webrev updated in-place, please press shift-reload.
http://cr.openjdk.java.net/~dsamersoff/JDK-8028773/webrev.03/
-Dmitry
On 2014-12-08 14:02, serguei.spit...@oracle.com wrote:
> Looks good.
>
> Some minor comments.
>
> Better to reformat with one variable at a line:
>
> 113
On 12/09/2014 01:39 AM, Stuart Marks wrote:
On 12/8/14 12:35 PM, Jaroslav Bachorik wrote:
Please, review the following test change
Issue : https://bugs.openjdk.java.net/browse/JDK-8066708
Webrev: http://cr.openjdk.java.net/~jbachorik/8066708/webrev.00
The test fails very intermittently when RM
I should also add that I don't have enough knowledge of the compiler
internals to review this patch, sorry.
Thanks,
Erik
On 2014-12-09 10:53, Erik Helin wrote:
I applied the patch on top of jdk9/hs-comp and created a webrev:
http://cr.openjdk.java.net/~ehelin/brendan/frame-pointer/webrev/
I a
> On 8 dec 2014, at 21:31, Brendan Gregg wrote:
>
> G'Day Staffan,
>
> On Mon, Dec 8, 2014 at 11:17 AM, Staffan Larsen
> wrote:
>>
>>> On 8 dec 2014, at 16:05, Maynard Johnson wrote:
>>>
> [...]
>>>
>>> And if the VM creates a /tmp/perf-.map file to save information about
>>> JITed methods
I applied the patch on top of jdk9/hs-comp and created a webrev:
http://cr.openjdk.java.net/~ehelin/brendan/frame-pointer/webrev/
I also successfully run the patch through JPRT.
Thanks,
Erik
On 2014-12-05 20:57, Brendan Gregg wrote:
On Thu, Dec 4, 2014 at 2:55 PM, Brendan Gregg mailto:brenda
On 2014-12-08 21:31, Brendan Gregg wrote:
G'Day Staffan,
On Mon, Dec 8, 2014 at 11:17 AM, Staffan Larsen
wrote:
On 8 dec 2014, at 16:05, Maynard Johnson wrote:
[...]
And if the VM creates a /tmp/perf-.map file to save information about
JITed methods, the perf's post-profiling tool will
On 08/12/14 22:19, Brendan Gregg wrote:
> It's a good idea, but I'm not sure the DWARF unwind approach is
> suitable for dynamic JIT. I'm usually sampling at 99 Hertz. With
> inlined symbols, just the perf.map file can become 10s of Mbytes, and
> I assume the DWARF info would be similar. So the fil
13 matches
Mail list logo
