Re: A hotspot patch for stack profiling (frame pointer)

2015-02-16 Thread Bertrand Delsart
On 13/02/2015 23:26, Brendan Gregg wrote: Thanks Bertrand and John for explaining the invokedynamic issue, and Vladimir for filing the bug. I'll reply here (I don't have a JBS account; I would like one!). The profilers I'm using (Linux perf, and Solaris DTrace) can already handle a broken RBP,

Re: JEP 240: Remove the JVM TI hprof Agent

2015-02-16 Thread Rainer Jung
Am 16.02.2015 um 13:47 schrieb Florian Weimer: On 02/13/2015 01:46 AM, mark.reinh...@oracle.com wrote: New JEP Candidate: http://openjdk.java.net/jeps/240 Removal of the hprof agent interferes with my TLS performance work. I'm not complaining (removing cruft is always a good idea), I'm just

Re: RFR: 6588467: Add isDaemon() and getPriority() to ThreadInfo

2015-02-16 Thread Mandy Chung
Hi Jeremy, On 2/9/2015 4:51 PM, Jeremy Manson wrote: http://cr.openjdk.java.net/~jmanson/6588467/webrev.01/ http://cr.openjdk.java.net/%7Ejmanson/6588467/webrev.01/ The change looks okay to me. Nit: It would be good for the new methods to replace tt.../tt with {@code ...}. line 600, 603

Re: JEP 240: Remove the JVM TI hprof Agent

2015-02-16 Thread Florian Weimer
On 02/13/2015 01:46 AM, mark.reinh...@oracle.com wrote: New JEP Candidate: http://openjdk.java.net/jeps/240 Removal of the hprof agent interferes with my TLS performance work. I'm not complaining (removing cruft is always a good idea), I'm just providing a data point. If I understand VisualVM

Re: gdb and OpenJDK

2015-02-16 Thread Andrew Haley
On 02/16/2015 12:06 PM, Erik Helin wrote: On 2015-02-16, Andrew Haley wrote: On 02/16/2015 10:43 AM, Volker Simonis wrote: Now if we replicate this SA code one more time in a Python library for GDB, you'll probably agree that it can't work more reliably than the original SA code. This may be

Re: gdb and OpenJDK

2015-02-16 Thread Erik Helin
On 2015-02-16, Andrew Haley wrote: On 02/16/2015 12:06 PM, Erik Helin wrote: On 2015-02-16, Andrew Haley wrote: On 02/16/2015 10:43 AM, Volker Simonis wrote: Now if we replicate this SA code one more time in a Python library for GDB, you'll probably agree that it can't work more reliably

Re: gdb and OpenJDK

2015-02-16 Thread Florian Weimer
On 02/11/2015 11:27 PM, Jeremy Manson wrote: First, gdb needed to be extended to support the ability to plug in a frame unwinder. The process of submitting this to gdb (which has been ongoing for quite a while) is finally starting to make reasonable progress. Next, we need a plugin for

Re: JEP 240: Remove the JVM TI hprof Agent

2015-02-16 Thread Mario Torre
2015-02-16 13:47 GMT+01:00 Florian Weimer fwei...@redhat.com: On 02/13/2015 01:46 AM, mark.reinh...@oracle.com wrote: New JEP Candidate: http://openjdk.java.net/jeps/240 Removal of the hprof agent interferes with my TLS performance work. I'm not complaining (removing cruft is always a good

Re: gdb and OpenJDK

2015-02-16 Thread Volker Simonis
Hi everybody, I really don't want to prevent the Good Enough solution and as far as I understand, this solution doesn't require any code changes to HotSpot, right? It will just add an additional Python artifact to the OpenJDK delivery which will be used by gdb. But in general I have to agree

Re: gdb and OpenJDK

2015-02-16 Thread Andrew Haley
On 02/16/2015 10:43 AM, Volker Simonis wrote: Now if we replicate this SA code one more time in a Python library for GDB, you'll probably agree that it can't work more reliably than the original SA code. This may be good enough for some use cases, but it won't be perfect. I'm not a gdb/DWARF

Re: DTraceAllocProbes bug in interpreter

2015-02-16 Thread Mikael Gerdin
Hi Jungwoo, The DTrace probes are part of the serviceability support, bcc:ing gc-dev and redirecting to serviceability-dev. /Mikael On 2015-02-14 02:21, Jungwoo Ha wrote: I am not sure if DTraceAllocProbes is a live code, but I think this is a bug. dtrace_object_alloc has changed to receive

Re: RFR 8072908: 8072908: com/sun/management/OperatingSystemMXBean/TestTotalSwap.sh fails on OS X with exit code 2

2015-02-16 Thread Staffan Larsen
Looks good! (And verified on my mac) Thanks, /Staffan On 13 feb 2015, at 10:40, Jaroslav Bachorik jaroslav.bacho...@oracle.com wrote: On 13.2.2015 03:36, David Holmes wrote: Hi Jaroslav, Looks reasonable - but I can't vouch for MacOSX commands. I am not a lucky Mac owner neither. I

Re: gdb and OpenJDK

2015-02-16 Thread Andrew Haley
On 15/02/15 19:55, Staffan Larsen wrote: I think what Erik suggested was if there was some way the JVM could expose data in a format that is easy to interpret by other tools (such as the python gdb plugin, but also plugins for other debuggers, or SA). Of course this would have to be data, not

Re: gdb and OpenJDK

2015-02-16 Thread Dmitry Samersoff
Andrew, One of possible solution is to make gdb to support native plugins, than re-use existing hotspot code as much as possible. I have a patch for gdb and can send it across if anybody interesting in it. With this patch we can do something like: (gdb) load-plugin libgdbjvm.so (gdb) attach

Re: gdb and OpenJDK

2015-02-16 Thread Erik Helin
On 2015-02-16, Andrew Haley wrote: On 02/16/2015 10:43 AM, Volker Simonis wrote: Now if we replicate this SA code one more time in a Python library for GDB, you'll probably agree that it can't work more reliably than the original SA code. This may be good enough for some use cases, but it