Re: Please review draft JEP: JMX Specific Annotations for Registration of Managed Resources

2015-03-03 Thread Jaroslav Bachorik
On 4.3.2015 02:09, Eamonn McManus wrote: Could you explain what you mean by this, regarding the annotations that were already agreed on by the JSR 255 Expert Group: * Smaller scope compared to the proposed solution * Conceptually in pre JDK7 era I have a number of other comments, but procedural

Re: Please review draft JEP: JMX Specific Annotations for Registration of Managed Resources

2015-03-03 Thread Eamonn McManus
Could you explain what you mean by this, regarding the annotations that were already agreed on by the JSR 255 Expert Group: * Smaller scope compared to the proposed solution * Conceptually in pre JDK7 era I have a number of other comments, but procedurally I'm not sure what the precedent is for s

Re: RFR: 8073688: Infinite loop reading types during jmap attach.

2015-03-03 Thread Dmitry Samersoff
Kevin, The fix looks good for me, but please add a comment explaining the problem we are solving here. -Dmitry On 2015-03-03 16:15, Kevin Walls wrote: > Hi, > > This is a review request for a way to make the SA tools protect > themselves from infinite loops during initialisation. > > Attaching

Re: RFR(S): 8073042: jcmd hangs until another jcmd is executed (which, in turn, also hangs) (on Windows)

2015-03-03 Thread Dean Long
Hi Markus. OK, thanks for the explanation. dl On 3/3/2015 1:15 AM, Markus Gronlund wrote: Hi Dean, Thanks for your input. I think a monitor would be less ideal here: A monitor would introduce blocking in enqueuing operations. The "posters" are (in this case) remotely injected threads (by a

Please review draft JEP: JMX Specific Annotations for Registration of Managed Resources

2015-03-03 Thread Jaroslav Bachorik
Hi all, Please review this draft JEP for JMX Specific Annotations for Registration of Managed Resources: https://bugs.openjdk.java.net/browse/JDK-8044507 Background: Current mechanism of defining an MBean requires to provide an MBean interface and its implementation. The interface and t

Re: RFR: 8073688: Infinite loop reading types during jmap attach.

2015-03-03 Thread Mikael Gerdin
On 2015-03-03 14:57, Kevin Walls wrote: Hi, Yes that's true - the original problem is in 7u. We'll have it around for a while yet so I would like to get this change there to protect us. While we can't reproduce the same thing on 9 today, there's still a while loop that will never terminate

Re: RFR: 8073688: Infinite loop reading types during jmap attach.

2015-03-03 Thread Kevin Walls
Hi, Yes that's true - the original problem is in 7u. We'll have it around for a while yet so I would like to get this change there to protect us. While we can't reproduce the same thing on 9 today, there's still a while loop that will never terminate if we read a zero for the stride size,

Re: RFR: 8073688: Infinite loop reading types during jmap attach.

2015-03-03 Thread Mikael Gerdin
Kevin, On 2015-03-03 14:15, Kevin Walls wrote: Hi, This is a review request for a way to make the SA tools protect themselves from infinite loops during initialisation. Attaching jmap (for example) to a JVM can fail, infinitely writing an error - and filling a disk if being logged to a file.

RFR: 8073688: Infinite loop reading types during jmap attach.

2015-03-03 Thread Kevin Walls
Hi, This is a review request for a way to make the SA tools protect themselves from infinite loops during initialisation. Attaching jmap (for example) to a JVM can fail, infinitely writing an error - and filling a disk if being logged to a file. This reproduces on a Solaris package based in

RE: RFR(S): 8073042: jcmd hangs until another jcmd is executed (which, in turn, also hangs) (on Windows)

2015-03-03 Thread Markus Gronlund
Hi Dean, Thanks for your input. I think a monitor would be less ideal here: A monitor would introduce blocking in enqueuing operations. The "posters" are (in this case) remotely injected threads (by another process), and the processes injecting those threads are in WaitForSingleObject() on th