Looks good to me.
/Magnus
> 7 apr 2015 kl. 17:21 skrev Erik Joelsson :
>
> (corrected subject)
>
>> On 2015-04-07 17:15, Erik Joelsson wrote:
>> Hello,
>>
>> When upgrading the toolchain to VS2013, management.dll stopped working on
>> certain Windows hosts. I've identified this to be related
On 4/7/15 6:07 PM, serguei.spit...@oracle.com wrote:
On 4/7/15 2:01 PM, serguei.spit...@oracle.com wrote:
On 4/7/15 11:20 AM, Coleen Phillimore wrote:
шI see. The PreviousVersionWalker is gone in 9 and you're using it
to find the method.
But this is only going to find the method if it ha
On 4/7/15 2:01 PM, serguei.spit...@oracle.com wrote:
On 4/7/15 11:20 AM, Coleen Phillimore wrote:
шI see. The PreviousVersionWalker is gone in 9 and you're using it
to find the method.
But this is only going to find the method if it happens to be in the
cpCache somewhere. I think
pv_n
On 4/7/15 11:20 AM, Coleen Phillimore wrote:
шI see. The PreviousVersionWalker is gone in 9 and you're using it to
find the method.
But this is only going to find the method if it happens to be in the
cpCache somewhere. I think
pv_node->prev_constant_pool()->pool_holder() is scratch_clas
Ok, thanks!
Serguei
On 4/7/15 9:59 AM, Daniel D. Daugherty wrote:
I _think_ you're OK with a single (R)eviewer for a backport even
when minor changes are required, but I can never remember all these
rules for sure...
Dan
On 4/6/15 5:50 PM, serguei.spit...@oracle.com wrote:
Coleen and Dan,
I
Dan, thank you for the review!
On 4/7/15 9:54 AM, Daniel D. Daugherty wrote:
On 4/2/15 6:03 PM, serguei.spit...@oracle.com wrote:
Please, review the jdk 8u60 backport for:
https://bugs.openjdk.java.net/browse/JDK-8067662
8u60 hotspot webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2015
Great
Thanks, Dan!
Serguei
On 4/7/15 9:44 AM, Daniel D. Daugherty wrote:
On 3/25/15 7:16 PM, serguei.spit...@oracle.com wrote:
Please, review the fix for:
https://bugs.openjdk.java.net/browse/JDK-8066679
Open hotspot webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2015/hotspot/8066679
On 4/7/15 9:06 AM, Jaroslav Bachorik wrote:
Hi Mandy,
On 3.4.2015 23:35, Mandy Chung wrote:
On 4/3/15 7:31 AM, Jaroslav Bachorik wrote:
Please, review the following change
Issue : https://bugs.openjdk.java.net/browse/JDK-8074368
Webrev: http://cr.openjdk.java.net/~jbachorik/8074368/webrev.00
Looks good!
Thanks,
/Staffan
> On 7 apr 2015, at 17:15, Erik Joelsson wrote:
>
> Hello,
>
> When upgrading the toolchain to VS2013, management.dll stopped working on
> certain Windows hosts. I've identified this to be related to the call to
> GetProcessMemoryInfo. By adding -DPSAPI_VERSION=1
I see. The PreviousVersionWalker is gone in 9 and you're using it to
find the method.
But this is only going to find the method if it happens to be in the
cpCache somewhere. I think
pv_node->prev_constant_pool()->pool_holder() is scratch_class (not 100%
sure). In which case, you can loo
Erik-
Looks good to me.
Tim
On 04/07/15 08:21, Erik Joelsson wrote:
(corrected subject)
On 2015-04-07 17:15, Erik Joelsson wrote:
Hello,
When upgrading the toolchain to VS2013, management.dll stopped
working on certain Windows hosts. I've identified this to be related
to the call to GetPr
I _think_ you're OK with a single (R)eviewer for a backport even
when minor changes are required, but I can never remember all these
rules for sure...
Dan
On 4/6/15 5:50 PM, serguei.spit...@oracle.com wrote:
Coleen and Dan,
I'm asking you as the jdk 9 reviewers...
Please, let me know if you
On 4/2/15 6:03 PM, serguei.spit...@oracle.com wrote:
Please, review the jdk 8u60 backport for:
https://bugs.openjdk.java.net/browse/JDK-8067662
8u60 hotspot webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2015/hotspot/8067662-JVMTI-trace.8u60
Nit - please update copyright years as nee
On 3/25/15 7:16 PM, serguei.spit...@oracle.com wrote:
Please, review the fix for:
https://bugs.openjdk.java.net/browse/JDK-8066679
Open hotspot webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2015/hotspot/8066679-JVMTI-cache.1/
src/share/vm/prims/jvmtiRedefineClasses.cpp
I concur
Hi Mandy,
On 3.4.2015 23:35, Mandy Chung wrote:
On 4/3/15 7:31 AM, Jaroslav Bachorik wrote:
Please, review the following change
Issue : https://bugs.openjdk.java.net/browse/JDK-8074368
Webrev: http://cr.openjdk.java.net/~jbachorik/8074368/webrev.00
Looks okay to me.
Minor comment on ThreadI
(corrected subject)
On 2015-04-07 17:15, Erik Joelsson wrote:
Hello,
When upgrading the toolchain to VS2013, management.dll stopped working
on certain Windows hosts. I've identified this to be related to the
call to GetProcessMemoryInfo. By adding -DPSAPI_VERSION=1 to CFLAGS,
the problem goe
Hello,
When upgrading the toolchain to VS2013, management.dll stopped working
on certain Windows hosts. I've identified this to be related to the call
to GetProcessMemoryInfo. By adding -DPSAPI_VERSION=1 to CFLAGS, the
problem goes away.
Bug: https://bugs.openjdk.java.net/browse/JDK-8076557
Jaroslav, Staffan,
Thanks for the reviews!
// Katja
On 04/07/2015 03:55 PM, Jaroslav Bachorik wrote:
Looks fine!
You might want to convert the 'jstatd started (bound to' string to a
constant to make it easier to track any changes in the future but it
is up to you. I am fine with the chang
Looks fine!
You might want to convert the 'jstatd started (bound to' string to a
constant to make it easier to track any changes in the future but it is
up to you. I am fine with the changes anyway.
-JB-
On 7.4.2015 14:52, Yekaterina Kantserova wrote:
Hi,
The updated webrev can be found h
Looks good!
Thanks,
/Staffan
> On 7 apr 2015, at 14:52, Yekaterina Kantserova
> wrote:
>
> Hi,
>
> The updated webrev can be found here:
> http://cr.openjdk.java.net/~ykantser/8027668/webrev.01/
>
> Thanks,
> Katja
>
>
>
> On 04/02/2015 02:44 PM, Jaroslav Bachorik wrote:
>> Hi Katja,
>>
Hi,
The updated webrev can be found here:
http://cr.openjdk.java.net/~ykantser/8027668/webrev.01/
Thanks,
Katja
On 04/02/2015 02:44 PM, Jaroslav Bachorik wrote:
Hi Katja,
On 2.4.2015 14:16, Yekaterina Kantserova wrote:
Hi,
Could I please have a review of this fix.
bug: https://bugs.ope
21 matches
Mail list logo
