RFR(M): 8078896: Add @modules as needed to the jdk_svc tests

2015-05-05 Thread Yekaterina Kantserova
Hi, Could I please have a review of this fix. bug: https://bugs.openjdk.java.net/browse/JDK-8078896 webrev: http://cr.openjdk.java.net/~ykantser/8078896 The push will be pushed to jdk9/dev. Thanks, Katja Alan's clarification from same change in hotspot (RFR: JDK-8075586: add @modules as nee

RFR(M): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

2015-05-05 Thread Dmitry Samersoff
Everyone, Please review the fix: http://cr.openjdk.java.net/~dsamersoff/JDK-8059036/webrev.01/ heap dcmd outputs the same information as SIGBREAK finalizerinfo dcmd outputs a list of all classes in finalization queue with count -Dmitry -- Dmitry Samersoff Oracle Java development team, Saint

Re: RFR(M): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

2015-05-05 Thread Staffan Larsen
Dmitry, I think this should be reviewed on hotspot-gc and core-libs-dev as well considering the changes to Finalizer. I’m a little worried about the potentially very large String that is returned from printFinalizationQueue(). A possible different approach would be to write printFinalizationQu

RFR(XS): 8076998: BadHandshakeTest.java fails due to warnings in output

2015-05-05 Thread Yekaterina Kantserova
Hi, Could I please have a review of this fix. bug: https://bugs.openjdk.java.net/browse/JDK-8076998 webrev: http://cr.openjdk.java.net/~ykantser/8076998/webrev.00/ The test has been checking the first line of output for either 'Listening for transport dt_socket at address:' or 'Address already

Re: RFR(XS): 8076998: BadHandshakeTest.java fails due to warnings in output

2015-05-05 Thread Staffan Larsen
Looks good! Thanks, /Staffan > On 5 maj 2015, at 15:24, Yekaterina Kantserova > wrote: > > Hi, > > Could I please have a review of this fix. > > bug: https://bugs.openjdk.java.net/browse/JDK-8076998 > webrev: http://cr.openjdk.java.net/~ykantser/8076998/webrev.00/ > > The test has been chec

Re: RFR(M): 8078896: Add @modules as needed to the jdk_svc tests

2015-05-05 Thread Alan Bateman
On 05/05/2015 10:04, Yekaterina Kantserova wrote: Hi, Could I please have a review of this fix. bug: https://bugs.openjdk.java.net/browse/JDK-8078896 webrev: http://cr.openjdk.java.net/~ykantser/8078896 The push will be pushed to jdk9/dev. Thanks Katja, this looks good. One thing that we shou

Re: RFR(XS): 8076998: BadHandshakeTest.java fails due to warnings in output

2015-05-05 Thread Yekaterina Kantserova
Thanks! // Katja On 05/05/2015 03:30 PM, Staffan Larsen wrote: Looks good! Thanks, /Staffan On 5 maj 2015, at 15:24, Yekaterina Kantserova wrote: Hi, Could I please have a review of this fix. bug: https://bugs.openjdk.java.net/browse/JDK-8076998 webrev: http://cr.openjdk.java.net/~ykant

Re: RFR(M): 8078896: Add @modules as needed to the jdk_svc tests

2015-05-05 Thread Yekaterina Kantserova
Alan, Thanks for the review! And for the catch - I'll fix it. // Katja On 05/05/2015 03:30 PM, Alan Bateman wrote: Thanks Katja, this looks good. One thing that we should as part of this is rev the requiredVersion in jdk/test/TEST.ROOT in case people are using older versions of jtreg. I think

Re: RFR(M): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

2015-05-05 Thread Peter Levart
Hi Dmitry, Staffan, On 05/05/2015 12:38 PM, Staffan Larsen wrote: Dmitry, I think this should be reviewed on hotspot-gc and core-libs-dev as well considering the changes to Finalizer. I’m a little worried about the potentially very large String that is returned from printFinalizationQueue().

Re: RFR(M): 8078896: Add @modules as needed to the jdk_svc tests

2015-05-05 Thread Mandy Chung
On 05/05/2015 02:04 AM, Yekaterina Kantserova wrote: Hi, Could I please have a review of this fix. bug: https://bugs.openjdk.java.net/browse/JDK-8078896 webrev: http://cr.openjdk.java.net/~ykantser/8078896 com.sun.management has been moved to jdk.management module. The patch for JDK-8042

Re: RFR(M): 8078896: Add @modules as needed to the jdk_svc tests

2015-05-05 Thread Mandy Chung
On 05/05/2015 01:33 PM, Mandy Chung wrote: On 05/05/2015 02:04 AM, Yekaterina Kantserova wrote: Hi, Could I please have a review of this fix. bug: https://bugs.openjdk.java.net/browse/JDK-8078896 webrev: http://cr.openjdk.java.net/~ykantser/8078896 com.sun.management has been moved to j

Re: RFR(XS): 8076998: BadHandshakeTest.java fails due to warnings in output

2015-05-05 Thread serguei.spit...@oracle.com
Looks good. Thanks, Serguei On 5/5/15 6:24 AM, Yekaterina Kantserova wrote: Hi, Could I please have a review of this fix. bug: https://bugs.openjdk.java.net/browse/JDK-8076998 webrev: http://cr.openjdk.java.net/~ykantser/8076998/webrev.00/ The test has been checking the first line of output