Re: RFR (XXS) 8069068: VM warning: WaitForMultipleObjects timed out (0) ...

Looks good! Thanks, David On 20/05/2015 11:57 PM, Ivan Gerasimov wrote: On 20.05.2015 10:04, David Holmes wrote: Hi Ivan, On 20/05/2015 9:54 AM, Ivan Gerasimov wrote: Hello! Since the beginning of the year a warning about an expired timeout has been seen a few times. It is most likely to

Re: [9] RFR (M) 8054386: Allow Java debugging when CDS is enabled

Hi Chris, On 21/05/2015 4:18 AM, Chris Plummer wrote: On 5/19/15 9:26 PM, David Holmes wrote: Hi Chris, On 20/05/2015 12:25 AM, Chris Plummer wrote: Hi, Please review the following changes for allowing java debugging when CDS is enabled. Webrev:http://cr.openjdk.java.net/~cjplummer/8054386/

Re: RFR[ 9u-dev] JDK-8075773 - jps running as root fails with 7u75, works fine with 7u72

On 5/18/15 3:59 AM, cheleswer sahu wrote: Hi, I have fixed the code and tested. It's working fine. Please review the changes. Web review link: http://cr.openjdk.java.net/~dbuck/8075773/webrev.02/ Cheleswer, Sorry for another lengthy review, but since this is security related, I have to be co

Re: RFR(M, v7): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

> On May 19, 2015, at 11:51 PM, Dmitry Samersoff > wrote: > > Other alternatives could be to do all hashing/sorting/printing on native > layer i.e. implement printFinalizationQueue inside VM. > > Both options has pros and cons - Java based solution requires less JNI > calls and better readable

Re: [9] RFR (M) 8054386: Allow Java debugging when CDS is enabled

On 5/19/15 9:26 PM, David Holmes wrote: Hi Chris, On 20/05/2015 12:25 AM, Chris Plummer wrote: Hi, Please review the following changes for allowing java debugging when CDS is enabled. Webrev:http://cr.openjdk.java.net/~cjplummer/8054386/webrev.01/ Bug:https://bugs.openjdk.java.net/browse/JDK-

Re: RFR (XXS) 8069068: VM warning: WaitForMultipleObjects timed out (0) ...

On 20.05.2015 18:19, Daniel D. Daugherty wrote: On 5/20/15 7:57 AM, Ivan Gerasimov wrote: On 20.05.2015 10:04, David Holmes wrote: Hi Ivan, On 20/05/2015 9:54 AM, Ivan Gerasimov wrote: Hello! Since the beginning of the year a warning about an expired timeout has been seen a few times. It

Re: RFR (XXS) 8069068: VM warning: WaitForMultipleObjects timed out (0) ...

On 5/20/15 7:57 AM, Ivan Gerasimov wrote: On 20.05.2015 10:04, David Holmes wrote: Hi Ivan, On 20/05/2015 9:54 AM, Ivan Gerasimov wrote: Hello! Since the beginning of the year a warning about an expired timeout has been seen a few times. It is most likely to observe this under a heavy load,

Re: RFR 8080663: Use sun.misc.SharedSecrets to allow access from java.management to @ConstructorProperties

On 20/05/2015 15:38, Mandy Chung wrote: Using the shared secret approach is okay. Some suggestion: Since both sun.misc.JavaBeansIntrospectorAccess and ConstructorPropertiesAccess are for JMX to access java.beans types, it could be simplified to have one single interface (e.g. sun.misc.Ja

Re: RFR 8080663: Use sun.misc.SharedSecrets to allow access from java.management to @ConstructorProperties

On 05/19/2015 06:39 AM, Jaroslav Bachorik wrote: > Please, review the following change > > Issue : https://bugs.openjdk.java.net/browse/JDK-8080663 > > Webrev: http://cr.openjdk.java.net/~jbachorik/8080663/webrev.00 >

Re: RFR (XXS) 8069068: VM warning: WaitForMultipleObjects timed out (0) ...

On 20.05.2015 10:04, David Holmes wrote: Hi Ivan, On 20/05/2015 9:54 AM, Ivan Gerasimov wrote: Hello! Since the beginning of the year a warning about an expired timeout has been seen a few times. It is most likely to observe this under a heavy load, when many threads are exiting. The propos

Re: RFR(M,v7): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

Staffan, On 2015-05-20 14:19, Staffan Larsen wrote: > Dmitry, > > I’ve look at the changes on the hotspot side. > > vm/services/diagnosticCommand.hpp: > > 270 static const char* impact() { > 271 return "Low"; > 272 } > > I wonder if the impact should be “Medium” instead. There aren’

Re: RFR(M,v7): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

Peter, > I see diagnostic commands mostly format their output in native code. > But for some of them (like this finalizer histogram) it would be nice > to have a Java wrapper for hotspot's outputStream. I love to have an ability to write pure-java DCMD's without touching of hotspot code but it's

Re: RFR(M,v7): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

On 05/20/2015 10:42 AM, Dmitry Samersoff wrote: Peter, What about creating a special package-private java.lang.ref.DiagnosticCommands class I'm not quite happy with current printFinalizationQueue method - love to have a way to print directly to DCMD pipe from Java rather than return a huge s

Re: RFR(M, v7): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

Dmitry, I’ve look at the changes on the hotspot side. vm/services/diagnosticCommand.hpp: 270 static const char* impact() { 271 return "Low"; 272 } I wonder if the impact should be “Medium” instead. There aren’t any good guidelines for what impact means, but finalizerinfo does have n

Internal - RE: PerfData counter: sun.gc.policy.generations in JDK 8

Hi How do we usually handle these bugs where we have an external patch to take in, should someone from Dev take ownership of the bug? And should we fix this in 8u60? Kind Regards /Mattis From: Staffan Larsen Sent: den 18 maj 2015 10:23 To: Srinivas Ramakrishna Cc: serviceability-dev

Re: RFR(M,v7): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

Peter, > What about creating a special package-private > java.lang.ref.DiagnosticCommands class I'm not quite happy with current printFinalizationQueue method - love to have a way to print directly to DCMD pipe from Java rather than return a huge string to VM. But lang.ref.Finalizer is cached by

Re: RFR(M,v7): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

On 05/20/2015 08:51 AM, Dmitry Samersoff wrote: Mandy, However I have trouble for Finalizer.printFinalizationQueue method that doesn’t belong there. What are the other alternatives you have explored? Other alternatives could be to do all hashing/sorting/printing on native layer i.e. implemen

Re: RFR (XXS) 8069068: VM warning: WaitForMultipleObjects timed out (0) ...

Hi Ivan, On 20/05/2015 9:54 AM, Ivan Gerasimov wrote: Hello! Since the beginning of the year a warning about an expired timeout has been seen a few times. It is most likely to observe this under a heavy load, when many threads are exiting. The propose is to increase the timeout. The rationale