Re: RFR: JDK-8114828: wrong class file error when compiling tests

Adding in hotspot-dev as there's a meta-question here Hi Alexander, On 16/07/2015 2:57 AM, Alexander Kulyakhtin wrote: Hi, Could you, please, review these simple test-only changes: CR: https://bugs.openjdk.java.net/browse/JDK-8114828 "wrong class file error when compiling tests" (All the cha

RFR: 8130115: REDO - Reduce Symbol::_identity_hash to 2 bytes

Hi, This is redo for bug 8087143, in that push, it caused failure on Serviceability Agent failed to get type for "_identity_hash": mistakenly used JShortField for it, but in fact it still is CIntegerField. In this change, besides of the original change in hotspot/src, I add code to calculat

RFR: JDK-8114828: wrong class file error when compiling tests

Hi, Could you, please, review these simple test-only changes: CR: https://bugs.openjdk.java.net/browse/JDK-8114828 "wrong class file error when compiling tests" (All the changed files belong to the Open JDK. Since the CR was submitted as confidential, the issue is described in this mail below)

Re: RFR: 8048353: jstack -l crashes VM when a Java mirror for a primitive type is locked

Hello Thanks for looking into this. Where can I find jstack/tmtools tests to run them ? Thanks, Vladimir. On 14.07.2015 19:21, Daniel D. Daugherty wrote: > Webrev: http://cr.openjdk.java.net/~vkempik/8048353/webrev.00/ src/share/vm/classfile/javaClasses.cpp No comments. (Thanks for inclu

Re: RFR(S): JDK-8129971 TestStackTrace.java: ArrayIndexOutOfBoundsException thrown by AARCH64ThreadContext.setRegister

Katja, done. Webrev updated in-place (press shift-reload) -Dmitry On 2015-07-15 15:16, Yekaterina Kantserova wrote: > Dmitry, > > could you please remove @ignore tag in TestStackTrace.java as well? > > // Katja > > On 07/15/2015 01:52 PM, Dmitry Samersoff wrote: >> Everybody, >> >> Please, r

Re: RFR(S): JDK-8129971 TestStackTrace.java: ArrayIndexOutOfBoundsException thrown by AARCH64ThreadContext.setRegister

Dmitry, could you please remove @ignore tag in TestStackTrace.java as well? // Katja On 07/15/2015 01:52 PM, Dmitry Samersoff wrote: Everybody, Please, review the fix: http://cr.openjdk.java.net/~dsamersoff/JDK-8129971/webrev.01/ Added one more register counted in frame context. -Dmitry

Re: RFR(S): JDK-8129971 TestStackTrace.java: ArrayIndexOutOfBoundsException thrown by AARCH64ThreadContext.setRegister

Looks good! -JB- On 15.7.2015 13:52, Dmitry Samersoff wrote: Everybody, Please, review the fix: http://cr.openjdk.java.net/~dsamersoff/JDK-8129971/webrev.01/ Added one more register counted in frame context. -Dmitry

RFR(S): JDK-8129971 TestStackTrace.java: ArrayIndexOutOfBoundsException thrown by AARCH64ThreadContext.setRegister

Everybody, Please, review the fix: http://cr.openjdk.java.net/~dsamersoff/JDK-8129971/webrev.01/ Added one more register counted in frame context. -Dmitry -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but they won't give me the

Re: RFR(XS): 8131328: Restore demo/jvmti tests

Serguei, Thanks a lot for the discovery and the review! // Katja On 07/15/2015 01:10 PM, serguei.spit...@oracle.com wrote: Looks good to me. Sorry, I did not notice it earlier. Thanks, Serguei On 7/15/15 3:55 AM, Yekaterina Kantserova wrote: Hi, Could I please have a review of this fix.

Re: RFR(XS): 8131328: Restore demo/jvmti tests

Looks good to me. Sorry, I did not notice it earlier. Thanks, Serguei On 7/15/15 3:55 AM, Yekaterina Kantserova wrote: Hi, Could I please have a review of this fix. demo/jvmti tests were unintentionally removed by https://bugs.openjdk.java.net/browse/JDK-8076471. This fix will restore the t

RFR(XS): 8131328: Restore demo/jvmti tests

Hi, Could I please have a review of this fix. demo/jvmti tests were unintentionally removed by https://bugs.openjdk.java.net/browse/JDK-8076471. This fix will restore the tests unrelated to hprof. bug: https://bugs.openjdk.java.net/browse/JDK-8131328 webrev: http://cr.openjdk.java.net/~ykant

Re: RFR(XS): 8076471: Remove hprof agent tests in JDK

Ok, thanks! Serguei On 7/15/15 3:07 AM, Yekaterina Kantserova wrote: Hi Serguei, Thanks a lot for looking at it! Yes, I unintentionally removed test/demo/jvmti instead of test/demo/jvmti/hprof :( Will restore the tests asap. // Katja On 07/15/2015 11:58 AM, serguei.spit...@oracle.com wr

Re: RFR(XS): 8076471: Remove hprof agent tests in JDK

Hi Serguei, Thanks a lot for looking at it! Yes, I unintentionally removed test/demo/jvmti instead of test/demo/jvmti/hprof :( Will restore the tests asap. // Katja On 07/15/2015 11:58 AM, serguei.spit...@oracle.com wrote: Hi Katya, On 7/15/15 2:22 AM, Yekaterina Kantserova wrote: Hi,

Re: RFR(XS): 8076471: Remove hprof agent tests in JDK

Hi Katya, On 7/15/15 2:22 AM, Yekaterina Kantserova wrote: Hi, I've forgotten to remove serviceability/hprof/cpu002.java test in hotspot repo. Could I please have a review for this change? webrev: http://cr.openjdk.java.net/~ykantser/8076471.hotspot/webrev.00 This looks good. Thanks, K

Re: RFR(XS): 8076471: Remove hprof agent tests in JDK

David, thanks for the review! Yes, I will. // Katja On 07/15/2015 11:31 AM, David Holmes wrote: Hi Katja, On 15/07/2015 7:22 PM, Yekaterina Kantserova wrote: Hi, I've forgotten to remove serviceability/hprof/cpu002.java test in hotspot repo. Could I please have a review for this change? web

Re: RFR(XS): 8076471: Remove hprof agent tests in JDK

Hi Katja, On 15/07/2015 7:22 PM, Yekaterina Kantserova wrote: Hi, I've forgotten to remove serviceability/hprof/cpu002.java test in hotspot repo. Could I please have a review for this change? webrev: http://cr.openjdk.java.net/~ykantser/8076471.hotspot/webrev.00 Reviewed. As this is in a sep

Re: RFR(XS): 8076471: Remove hprof agent tests in JDK

Hi, I've forgotten to remove serviceability/hprof/cpu002.java test in hotspot repo. Could I please have a review for this change? webrev: http://cr.openjdk.java.net/~ykantser/8076471.hotspot/webrev.00 Thanks, Katja On 07/10/2015 02:55 PM, Yekaterina Kantserova wrote: Hi, Could I please h