Hi all,
Could I have a couple of reviews for this small change?
http://cr.openjdk.java.net/~brutisso/8140384/webrev.00/
https://bugs.openjdk.java.net/browse/JDK-8140384
The TicksToTimeHelper class use different return values depending on if
you want to convert to seconds or milliseconds.
c
Hi Bengt,
Looks good - thanks for fixing.
One small thing:
I think we can drop the return (double) cast on line 55, no need for updated
webrevs.
Thanks
Markus
-Original Message-
From: Bengt Rutisson
Sent: den 23 oktober 2015 10:27
To: serviceability-dev@openjdk.java.net serviceabilit
Hi Markus,
On 2015-10-23 10:41, Markus Gronlund wrote:
Hi Bengt,
Looks good - thanks for fixing.
Thanks for looking at this!
One small thing:
I think we can drop the return (double) cast on line 55, no need for updated
webrevs.
Good point. I'll fix that before I push.
Thanks,
Bengt
On 23/10/2015 6:41 PM, Markus Gronlund wrote:
Hi Bengt,
Looks good - thanks for fixing.
Arguably if you asked for milliseconds you really didn't care about the
fractional part. If you did care then you could just multiply seconds by
1000. But on that basis we could just drop the milliseconds
Hi David,
Thanks for looking at this!
On 2015-10-23 12:53, David Holmes wrote:
On 23/10/2015 6:41 PM, Markus Gronlund wrote:
Hi Bengt,
Looks good - thanks for fixing.
Arguably if you asked for milliseconds you really didn't care about
the fractional part. If you did care then you could ju
Hi all,
I'm waiting some reviews from (R)eviewer.
And here's a new webrev which includes Chris' comments.
- Move fflush() outside of 'if' statement at jni.cpp.
- Remove #ifdef _WIN32
webrev:
http://cr.openjdk.java.net/~sangheki/8139801/webrev.02/
Thanks,
Sangheon
On 10/20/2015 05:17 PM, sangh
