Including serviceability-dev. Recap:
Summary: In logging/log.hpp, the logging vwrite function previously
asserted that the buffer remains within 512 characters, which is
too short for logging message of non-pre-determined length, e.g. for
vtable and itable function names. Now, the function resi
Hi Andreas,
The fix looks good to me.
Thank you for taking care about this issue!
Thanks,
Serguei
On 10/28/15 05:46, Andreas Eriksson wrote:
Hi,
Please review this change to JDI to address a performance bottleneck
in findBootType for high delay networks.
Bug:
8074696: Remote debugging ses
Rachel,
On 2015-10-28 17:48, Rachel Protacio wrote:
> Thank you for the comments, both Dmitry and Mikael. Replies inline.
>
> Modified webrev: http://cr.openjdk.java.net/~rprotacio/8138916.01/
111 Assert is never happens on Windows, so it's better to move it to
os_posix
113 newbuf_len doesn't a
Rachel,
> I don't think this would work anyway. A char[] needs a static size.
It does work. C++ allows this way of on-stack allocation, C not.
see attached testcase
-Dmitry
On 2015-10-28 17:48, Rachel Protacio wrote:
> Thank you for the comments, both Dmitry and Mikael. Replies inline.
>
> Mo
Thank you for the comments, both Dmitry and Mikael. Replies inline.
Modified webrev: http://cr.openjdk.java.net/~rprotacio/8138916.01/
(Retested and works fine.)
On 10/27/2015 7:52 AM, Dmitry Samersoff wrote:
Rachel,
In worst case (windows, overflow) the code would parse format string
four t
Hi,
Please review this change to JDI to address a performance bottleneck in
findBootType for high delay networks.
Bug:
8074696: Remote debugging session hangs for several minutes when calling
findBootType
https://bugs.openjdk.java.net/browse/JDK-8074696
Webrev:
http://cr.openjdk.java.net/~a
