On 15/12/2015 10:18 PM, Ivan Gerasimov wrote:
while(true) would convey that much more clearly - and perhaps obviate
the need for pr_ex.
Yes, I can surely transform the code
- while (pr_ex != curr_id) {
+ if (pr_ex != curr_id) {
+ while (true} {
The intention was to save
Looks good!
Thanks,
David
On 16/12/2015 1:12 AM, Marcus Larsson wrote:
Hey Markus,
On 2015-12-15 11:58, Markus Gronlund wrote:
Hi Marcus,
Looks good!
One minor thing that you don't need to fix if you don't want to:
I would use:
class ConfigurationLock {
...
debug_only(static bool curr
Hi Rachel,
On 17/12/2015 7:33 AM, Rachel Protacio wrote:
Hi,
On 12/16/2015 3:52 PM, David Holmes wrote:
Hi Rachel,
On 16/12/2015 6:26 AM, Rachel Protacio wrote:
Hi,
Thanks for the comments, David.
I had messed up my uploading before and had not actually updated the
open html. So for real t
On 12/16/15 4:01 PM, John Rose wrote:
On Dec 15, 2015, at 12:26 PM, Rachel Protacio
wrote:
- each incident of ttyLocker that involved separate logging lines for the same
message have been consolidated to one line
- each incident of ttyLocker that involved separate print statements to one
l
Hi,
On 12/16/2015 3:52 PM, David Holmes wrote:
Hi Rachel,
On 16/12/2015 6:26 AM, Rachel Protacio wrote:
Hi,
Thanks for the comments, David.
I had messed up my uploading before and had not actually updated the
open html. So for real this time, the most recent webrev is at
http://cr.openjdk.ja
On Dec 15, 2015, at 12:26 PM, Rachel Protacio
wrote:
>
> - each incident of ttyLocker that involved separate logging lines for the
> same message have been consolidated to one line
> - each incident of ttyLocker that involved separate print statements to one
> logging line has been changed to
Hi Rachel,
On 16/12/2015 6:26 AM, Rachel Protacio wrote:
Hi,
Thanks for the comments, David.
I had messed up my uploading before and had not actually updated the
open html. So for real this time, the most recent webrev is at
http://cr.openjdk.java.net/~rprotacio/8141211.01/ Of note:
- each inc
On Dec 15, 2015, at 10:12 AM, Marcus Larsson wrote:
>
> I think it's worth another round. :)
>
> New webrev:
> http://cr.openjdk.java.net/~mlarsson/8145083/webrev.04/
>
> Incremental:
> http://cr.openjdk.java.net/~mlarsson/8145083/webrev.03-04/
Looks good.
I like the reorganization around the
Hi all,
If Shanliang cannot review, someone could review it?
I reported this issue first at the below.
http://mail.openjdk.java.net/pipermail/jdk9-dev/2015-April/002152.html
http://mail.openjdk.java.net/pipermail/serviceability-dev/2015-May/017241.html
Hope this patch helps to community.
Thanks
Daniel,
Thank you very much for the review. I'm going to add the comment as you have
suggested.
Best regards,
Alexander
- Original Message -
From: daniel.daughe...@oracle.com
To: alexander.kulyakh...@oracle.com, serviceability-dev@openjdk.java.net
Sent: Wednesday, December 16, 2015 5:58
Hi,
On 15.12.2015 19:19, olivier.lagn...@oracle.com wrote:
Hi,
Please review the following changes for task "JDK-8058865 : JMX Test
Refactoring"
Issue: https://bugs.openjdk.java.net/browse/JDK-8058865
Webrev: http://cr.openjdk.java.net/~olagneau/8058865/webrev.06/
Issue Description:
" The maj
Looks good!
Thanks,
/Staffan
> On 16 dec. 2015, at 13:05, Alexander Kulyakhtin
> wrote:
>
> Hi,
>
> Could you, please, review this small test-only fix:
>
> CR: https://bugs.openjdk.java.net/browse/JDK-8145408
> "com/sun/jdi/BreakpointWithFullGC.sh: Required output "Full GC" not found"
> Web
You might want to include a comment like:
# Prior to JDK9-BNN, the pattern was 'Full GC'
where NN is the promoted build where the format changed.
This will help anyone backporting test fixes to older releases.
Dan
On 12/16/15 5:05 AM, Alexander Kulyakhtin wrote:
Hi,
Could you, please, review
Please, review the following simple test change
Issue : https://bugs.openjdk.java.net/browse/JDK-8145417
Webrev: http://cr.openjdk.java.net/~jbachorik/8145417/webrev.00
The affected tests check for 'Unknown host' in stderr. In some
situations this line may not appear, although an alternative er
Jaroslav,
Thank you very much for the review.
We are going to submit an enhancement to convert the existing jdi shell tests
from scripts to java.
As this shell test, along with several others, depends on a common shell
script, all the depending tests will need to be modified in the course of s
On 16.12.2015 13:05, Alexander Kulyakhtin wrote:
Hi,
Could you, please, review this small test-only fix:
CR: https://bugs.openjdk.java.net/browse/JDK-8145408 "com/sun/jdi/BreakpointWithFullGC.sh:
Required output "Full GC" not found"
Webrev:
http://cr.openjdk.java.net/~akulyakh/8145408/test/co
Hi,
Could you, please, review this small test-only fix:
CR: https://bugs.openjdk.java.net/browse/JDK-8145408
"com/sun/jdi/BreakpointWithFullGC.sh: Required output "Full GC" not found"
Webrev:
http://cr.openjdk.java.net/~akulyakh/8145408/test/com/sun/jdi/BreakpointWithFullGC.sh.udiff.html
The t
Hi Marcus,
Looks good, thanks for fixing.
As we spoke out-of-band, post this fix, lets figure a way of how to generalize
this with some kind of SemaphoreAcquireRelease utility.
/Markus
-Original Message-
From: Marcus Larsson
Sent: den 16 december 2015 09:46
To: serviceability-dev@open
Hi Chris,
On 2015-12-16 08:40, Chris Plummer wrote:
Hi Mikael,
On 12/15/15 1:56 AM, Mikael Gerdin wrote:
Hi Chris,
sorry for the late reply.
On 2015-12-10 22:31, Chris Plummer wrote:
Hi Mikael,
See comments inline below:
On 12/9/15 8:48 AM, Mikael Gerdin wrote:
On 2015-12-08 20:14, Chris
Hi,
Please review the following patch to fix a race in file rotations with UL.
Summary:
freopen and fwrite are not safe to use concurrently and hence the VM
might crash if a thread tries to write during a rotation. Writing and
rotating needs to be properly synchronized, but using a Mutex is
p
Hi Dmitry,
On 12/15/15 4:11 AM, Dmitry Samersoff wrote:
Chris,
1. Please file a separate CR for SA (assign it to me) and go ahead with
your fix when it become ready.
Ok.
2. As far as I understand the fix, you just removed explicit alignment
for all platforms (not only 32bit) and rely on comp
21 matches
Mail list logo
