Re: RFR(L): JDK-8067194 Restructure hotspot/agent/src to conform the modular source layout

Hello Dmitry, Nice to see this happen! make/lib/Lib-jdk.hotspot.agent.gmk: Missing a "/libsaproc" here: SA_SRC += $(SA_TOPDIR)/share/native $(SA_TOPDIR)/$(OPENJDK_TARGET_OS)/native/libsaproc Otherwise it looks good. /Erik On 2015-12-21 22:50, Dmitry Samersoff wrote: Everybody, Please, rev

Re: RFR : JDK-6744127 - NullPointerException at com.sun.tools.jdi.EventRequestManagerImpl.request

Hi Serguei, Many thanks for reviewing the code. Regards Harsha On Tuesday 22 December 2015 01:31 AM, serguei.spit...@oracle.com wrote: Hi Harsha, The fix is good, thumbs up. Thank you for the extra work around the test failure! Thanks, Serguei On 12/21/15 05:37, Harsha Wardhana B wrote:

RFR(L): JDK-8067194 Restructure hotspot/agent/src to conform the modular source layout

Everybody, Please, review the changes: http://cr.openjdk.java.net/~dsamersoff/JDK-8067194/webrevs.02/ The problem: Serviceability agent source should follow source layout convention for modular jdk. The solution: Move SA sources under src/jdk.hotspot.agent Move native code under jdk.

Re: RFR: 8141211: Convert TraceExceptions to Unified Logging

Hi, Please take a look at my updated changeset! Webrev: http://cr.openjdk.java.net/~rprotacio/8141211.02/ I've fixed the multi-line statements as requested, i.e. put newlines in them to replicate the original format. Since the UL framework atomically writes complete messages, these single

Re: RFR : JDK-6744127 - NullPointerException at com.sun.tools.jdi.EventRequestManagerImpl.request

Hi Harsha, The fix is good, thumbs up. Thank you for the extra work around the test failure! Thanks, Serguei On 12/21/15 05:37, Harsha Wardhana B wrote: Hi All, Please find below the updated webrev incorporating review comments. Issue : https://bugs.openjdk.java.net/browse/JDK-6744127 web

Re: RFR: 8141211: Convert TraceExceptions to Unified Logging

Hello, everyone! I've filed an RFE for this issue. https://bugs.openjdk.java.net/browse/JDK-8145934 It'll probably be easier to continue the discussion there. Thanks, Rachel On 12/18/2015 8:29 AM, Staffan Larsen wrote: On 18 dec. 2015, at 14:06, David Holmes

Re: JDK 9 RFR of JDK-8145869: Mark test JMXStartStopTest.java and TestJstatdServer.java as intermittently failing

Looks fine Amy; thanks, -Joe On 12/20/2015 8:53 PM, Amy Lu wrote: sun/management/jmxremote/startstop/JMXStartStopTest.java sun/tools/jstatd/TestJstatdServer.java Above tests are known to fail intermittently, this patch is to mark the test accordingly with keyword 'intermittent'. bug: https:

Re: RFR : JDK-6744127 - NullPointerException at com.sun.tools.jdi.EventRequestManagerImpl.request

Hi All, Please find below the updated webrev incorporating review comments. Issue : https://bugs.openjdk.java.net/browse/JDK-6744127 webrev : http://cr.openjdk.java.net/~jbachorik/sponsorship/6744127/webrev.01/ Hello Serguei, I will send fix for tonga test case in a separate review request.

Re: JDK 9 RFR of JDK-8145869: Mark test JMXStartStopTest.java and TestJstatdServer.java as intermittently failing

Looks good! -JB- On 21.12.2015 05:53, Amy Lu wrote: sun/management/jmxremote/startstop/JMXStartStopTest.java sun/tools/jstatd/TestJstatdServer.java Above tests are known to fail intermittently, this patch is to mark the test accordingly with keyword 'intermittent'. bug: https://bugs.openjdk.j