Re: RFR 8145127: VM warning: WaitForMultipleObjects timed out (0) ...

Looks okay. Second review needed though. Thanks, David On 19/12/2015 10:28 PM, Ivan Gerasimov wrote: We will suspend the current thread if two conditions are satisfied: process_exiting != 0 and process_exiting != current thread id. But, yes, pr_ex isn't really needed, as we can use process_

Re: RFR: 8141211: Convert TraceExceptions to Unified Logging

Thanks Rachel - looks good. David On 22/12/2015 7:46 AM, Rachel Protacio wrote: Hi, Please take a look at my updated changeset! Webrev: http://cr.openjdk.java.net/~rprotacio/8141211.02/ I've fixed the multi-line statements as requested, i.e. put newlines in them to replicate the original form

Re: RFR: JDK-8145788: JVM crashes with -XX:+EnableTracing

Hi Yasumasa, On 23/12/2015 11:49 AM, Yasumasa Suenaga wrote: > Hi David, > > I've added callstack when JVM crashed: > > https://bugs.openjdk.java.net/browse/JDK-8145788?focusedCommentId=13880225&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13880225 Thanks for

Re: RFR: JDK-8145788: JVM crashes with -XX:+EnableTracing

Hi David, I've added callstack when JVM crashed: https://bugs.openjdk.java.net/browse/JDK-8145788?focusedCommentId=13880225&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13880225 This crash occurrs in Arguments::apply_ergo() in Threads::create_vm(). apply_ergo()

Re: jmx-dev RFR 8145982: JMXInterfaceBindingTest is failing intermittently

On 22 Dec 2015, at 17:25, olivier.lagn...@oracle.com wrote: > Hi Jaroslav, > > Looks good. Not a reviewer however. +1 -Chris. > Olivier. > > On 22/12/2015 17:50, Jaroslav Bachorik wrote: >> Please, review this trivial test change >> >> Issue : https://bugs.openjdk.java.net/browse/JDK-814598

Re: jmx-dev RFR 8145982: JMXInterfaceBindingTest is failing intermittently

Hi Jaroslav, Looks good. Not a reviewer however. Olivier. On 22/12/2015 17:50, Jaroslav Bachorik wrote: Please, review this trivial test change Issue : https://bugs.openjdk.java.net/browse/JDK-8145982 Webrev: http://cr.openjdk.java.net/~jbachorik/8145982/webrev.00 The test calls System.exit(

RFR 8145982: JMXInterfaceBindingTest is failing intermittently

Please, review this trivial test change Issue : https://bugs.openjdk.java.net/browse/JDK-8145982 Webrev: http://cr.openjdk.java.net/~jbachorik/8145982/webrev.00 The test calls System.exit(0) in case when it is not applicable (due to HW configuration). This call is forbidden by the test harness

Re: RFR(L): JDK-8067194 Restructure hotspot/agent/src to conform the modular source layout

Hi, looks good, modulo the problems you are mentioning (docs will need update to refer to correct locations; the same might be true for the textual output from scripts). I believe the tests are still passing. Supposing the remaining problems are covered by CR you can consider this reviewed.

Re: RFR: JDK-8145788: JVM crashes with -XX:+EnableTracing

On 19/12/2015 1:50 AM, Yasumasa Suenaga wrote: > Hi all, > > I encountered JVM crash when I passed -XX:+EnableTracing. > > I checked core image, it crashed in EventBooleanFlagChanged::writeEvent() > which is called by Arguments::apply_ergo() because thread had not been > initialized. (JVM s

Re: RFR(L): JDK-8067194 Restructure hotspot/agent/src to conform the modular source layout

On 2015-12-22 08:46, Erik Joelsson wrote: Hello Dmitry, Nice to see this happen! make/lib/Lib-jdk.hotspot.agent.gmk: Missing a "/libsaproc" here: SA_SRC += $(SA_TOPDIR)/share/native $(SA_TOPDIR)/$(OPENJDK_TARGET_OS)/native/libsaproc Otherwise it looks good. Looks good to me too. /Magnus