Re: RFR 8143047: Re-examine javax/management/ImplementationVersion/ImplVersionTest.java

2016-01-04 Thread Eamonn McManus
I think this test should either be deleted or reduced to a simple check that the MBeanServerDelegate's ImplementationVersion attribute is equal to System.getProperty("java.runtime.version"). The whole business of starting up a separate process and checking things with security managers and so on

RFR 8143047: Re-examine javax/management/ImplementationVersion/ImplVersionTest.java

2016-01-04 Thread Jaroslav Bachorik
Please, review the following simple change Issue : https://bugs.openjdk.java.net/browse/JDK-8143047 Webrev: http://cr.openjdk.java.net/~jbachorik/8143047/webrev.00 The patch removes the special path taken when jmxrmi.jar is present on the bootclasspath. There are two reasons for this cleanup:

Re: jmx-dev RFR 8143047: Re-examine javax/management/ImplementationVersion/ImplVersionTest.java

2016-01-04 Thread Alan Bateman
On 04/01/2016 10:20, Jaroslav Bachorik wrote: Please, review the following simple change Issue : https://bugs.openjdk.java.net/browse/JDK-8143047 Webrev: http://cr.openjdk.java.net/~jbachorik/8143047/webrev.00 The patch removes the special path taken when jmxrmi.jar is present on the

[ping] Re: RFR 8146015: JMXInterfaceBindingTest is failing intermittently for IPv6 addresses

2016-01-04 Thread Jaroslav Bachorik
Gentle reminder ... On 23.12.2015 11:26, Jaroslav Bachorik wrote: Please, review the following test change Issue : https://bugs.openjdk.java.net/browse/JDK-8146015 Webrev: http://cr.openjdk.java.net/~jbachorik/8146015/webrev.00 The test fails for IPv6 addresses since the RMI expects an IPv6

jcmd -help shows non-existent option

2016-01-04 Thread KUBOTA Yuji
Hi all, It's just typo level. The jcmd help messages include non-existent option as below. If no options are given, lists Java processes (same as -p). I confirmed the jcmd implementation, but could not find "-p". I think "-l" is correct. I write a patch from jdk9/dev/jdk

[PING] Potential infinite waiting at JMXConnection#createConnection

2016-01-04 Thread KUBOTA Yuji
Hi all, Could you please review this patch? Thanks, Yuji 2015-12-17 2:05 GMT+09:00 KUBOTA Yuji : > Hi all, > > If Shanliang cannot review, someone could review it? > > I reported this issue first at the below. >

Re: jmx-dev RFR 8143047: Re-examine javax/management/ImplementationVersion/ImplVersionTest.java

2016-01-04 Thread Alan Bateman
On 04/01/2016 15:05, Jaroslav Bachorik wrote: : Not sure. With this change in place the test will not even try to detect the situation when JMX is not bundled with JDK. There is another test (jdk/test/javax/management/remote/mandatory/version/ImplVersionTest.java) with the same wording

Re: [PING] Potential infinite waiting at JMXConnection#createConnection

2016-01-04 Thread Jaroslav Bachorik
Hi Yuji, On 4.1.2016 15:14, KUBOTA Yuji wrote: Hi all, Could you please review this patch? Sorry for the long delay. Shanliang has not been present for some time and probably this slipped the attention of the others. However, core-libs mailing list might be more appropriate place to

Re: jmx-dev RFR 8143047: Re-examine javax/management/ImplementationVersion/ImplVersionTest.java

2016-01-04 Thread Jaroslav Bachorik
On 4.1.2016 12:09, Alan Bateman wrote: On 04/01/2016 10:20, Jaroslav Bachorik wrote: Please, review the following simple change Issue : https://bugs.openjdk.java.net/browse/JDK-8143047 Webrev: http://cr.openjdk.java.net/~jbachorik/8143047/webrev.00 The patch removes the special path taken