Re: RFR: JDK-8145788: JVM crashes with -XX:+EnableTracing

2016-01-05 Thread David Holmes
Pinging the serviceability tracing experts please! David On 24/12/2015 12:25 AM, Yasumasa Suenaga wrote: > Hi David, > >>> 1. Initialize JavaThread before calling apply_ergo() in create_vm(). >> >> That is not likely to be an option - it would likely be far too >> disruptive to the initiali

Re: RFR 8145127: VM warning: WaitForMultipleObjects timed out (0) ...

2016-01-05 Thread David Holmes
On 6/01/2016 3:33 AM, Daniel D. Daugherty wrote: Happy New Year! And to you :) > http://cr.openjdk.java.net/~igerasim/8145127/01/webrev/ src/os/windows/vm/os_windows.cpp L3923: Atomic::cmpxchg((jint)GetCurrentThreadId(), &process_exiting, 0); What's the return size of

Re: HSDB could not terminate when launched on CLI.

2016-01-05 Thread KUBOTA Yuji
Dmitry, Thank your reply on vacation. Have a good time :) Thanks, Yuji 2016-01-06 3:08 GMT+09:00 Dmitry Samersoff : > Yuji, > > I'm on vacation till Jan 10, answer you next week. > > Sorry! > Dmitry. > > > On 2016-01-05 18:01, KUBOTA Yuji wrote: >> Hi Dmitry, >> >> Thank you for your time. If yo

Re: Review of JDK-6659240 - Exceptions thrown by MXBeans wrongly documented in j.l.m.ManagementFactory

2016-01-05 Thread Daniel Fuchs
On 30/12/15 10:06, Jaroslav Bachorik wrote: On 28.12.2015 18:01, Sharath Ballal wrote: Hi, Kindly review the changes for bug https://bugs.openjdk.java.net/browse/JDK-6659240 Webrev: http://cr.openjdk.java.net/~jbachorik/sponsorship/6659240/webrev.00/ Looks good! Hi, What is {@code MBeanSe

Re: HSDB could not terminate when launched on CLI.

2016-01-05 Thread Dmitry Samersoff
Yuji, I'm on vacation till Jan 10, answer you next week. Sorry! Dmitry. On 2016-01-05 18:01, KUBOTA Yuji wrote: > Hi Dmitry, > > Thank you for your time. If you have a comment, please let me know. > > Thanks, > Yuji > > 2015-12-15 18:11 GMT+09:00 Dmitry Samersoff : >> Yuji, >> >> I'll take a

Re: RFR 8145127: VM warning: WaitForMultipleObjects timed out (0) ...

2016-01-05 Thread Daniel D. Daugherty
Happy New Year! > http://cr.openjdk.java.net/~igerasim/8145127/01/webrev/ src/os/windows/vm/os_windows.cpp L3923: Atomic::cmpxchg((jint)GetCurrentThreadId(), &process_exiting, 0); What's the return size of GetCurrentThreadId()? Are we down casting a larger size int

Re: RFR 8143047: Re-examine javax/management/ImplementationVersion/ImplVersionTest.java

2016-01-05 Thread Eamonn McManus
OK. In that case I would suggest removing the checkVersion variable since it is now always true, along with the logic from ImplVersionCommand for when it is false. Éamonn 2016-01-05 5:52 GMT-08:00 Jaroslav Bachorik : > On 4.1.2016 21:26, Eamonn McManus wrote: > >> I think this test should either

Re: HSDB could not terminate when launched on CLI.

2016-01-05 Thread KUBOTA Yuji
Hi Dmitry, Thank you for your time. If you have a comment, please let me know. Thanks, Yuji 2015-12-15 18:11 GMT+09:00 Dmitry Samersoff : > Yuji, > > I'll take a look. > > -Dmitry > > On 2015-12-15 11:23, KUBOTA Yuji wrote: >> Hi all, >> >> When I ran HSDB by jhsdb on CLI i.e. without x11 displa

[pong] Re: [ping] Re: RFR 8146015: JMXInterfaceBindingTest is failing intermittently for IPv6 addresses

2016-01-05 Thread Jaroslav Bachorik
On 4.1.2016 10:05, Jaroslav Bachorik wrote: Gentle reminder ... On 23.12.2015 11:26, Jaroslav Bachorik wrote: Please, review the following test change Issue : https://bugs.openjdk.java.net/browse/JDK-8146015 Webrev: http://cr.openjdk.java.net/~jbachorik/8146015/webrev.00 The test fails for IP

Re: jmx-dev RFR 8143047: Re-examine javax/management/ImplementationVersion/ImplVersionTest.java

2016-01-05 Thread Jaroslav Bachorik
On 5.1.2016 15:00, Alan Bateman wrote: On 05/01/2016 13:52, Jaroslav Bachorik wrote: On 4.1.2016 21:26, Eamonn McManus wrote: I think this test should either be deleted or reduced to a simple check that the MBeanServerDelegate's ImplementationVersion attribute is equal to System.getProperty("

Re: jmx-dev RFR 8143047: Re-examine javax/management/ImplementationVersion/ImplVersionTest.java

2016-01-05 Thread Alan Bateman
On 05/01/2016 13:52, Jaroslav Bachorik wrote: On 4.1.2016 21:26, Eamonn McManus wrote: I think this test should either be deleted or reduced to a simple check that the MBeanServerDelegate's ImplementationVersion attribute is equal to System.getProperty("java.runtime.version"). The whole busine

Re: RFR 8143047: Re-examine javax/management/ImplementationVersion/ImplVersionTest.java

2016-01-05 Thread Jaroslav Bachorik
On 4.1.2016 21:26, Eamonn McManus wrote: I think this test should either be deleted or reduced to a simple check that the MBeanServerDelegate's ImplementationVersion attribute is equal to System.getProperty("java.runtime.version"). The whole business of starting up a separate process and checking