RFR: JDK-8147447: [TESTBUG] serviceability/tmtools/jstack/WaitNotifyThreadTest.java test fails

Hi, Could you, please, review this minor test-only change CR: https://bugs.openjdk.java.net/browse/JDK-8147447 "[TESTBUG] serviceability/tmtools/jstack/WaitNotifyThreadTest.java test fails" Webrev: http://cr.openjdk.java.net/~akulyakh/8147447/index.html The test WaitNotifyThreadTest.java tries

Re: RFR[9u-dev] 8130425: libjvm crash due to stack overflow in executables with 32k tbss/tdata

| Hi Cheleswer, I think Martin is suggesting something like: | // Use a modest stack size, unless requested otherwise: long stackSize = Boolean.getBoolean("processReaperUseDefaultStackSize") ? 0 : 32768; Thread t = new Thread(systemThreadGroup, grimReaper, "process reaper", stackSize); ||| If

Re: RFR[9u-dev] 8130425: libjvm crash due to stack overflow in executables with 32k tbss/tdata

On 19/01/2016 9:53 PM, Kevin Walls wrote: | Hi Cheleswer, I think Martin is suggesting something like: | // Use a modest stack size, unless requested otherwise: long stackSize = Boolean.getBoolean("processReaperUseDefaultStackSize") ? 0 : 32768; Someone from core-libs needs to chime on what

Re: RFR: JDK-8147388: Add diagnostic commands to attach JVMTI agent.

On 19/01/2016 11:19 PM, Yasumasa Suenaga wrote: Hi, I uploaded a new webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8147388/webrev.03/ It is malloc/free version. If NULL returns from malloc(), it calls vm_exit_out_of_memory(). That seems rather extreme - do other dcmd failures abort the

Re: RFR: 8146009: "pure virtual method called" with using new GC logging mechanism

On Jan 19, 2016, at 8:58 AM, Marcus Larsson wrote: > > Hi, > > Please review the following patch to fix an issue in UL causing the VM to > crash during shutdown. > > The problem is that the static LogStdoutOutput is deinitialized before the > last use of it (G1

Re: RFR: JDK-8147388: Add diagnostic commands to attach JVMTI agent.

Hi Yasumasa, This looks pretty good. Thank you for the enhancement! A couple of minor comments. src/share/vm/prims/jvmtiExport.cp +jint JvmtiExport::load_agent_library(const char *agent, const char *absParam, + const char *options, outputStream* st) { The indent needs to be corrected.

Re: RFR: JDK-8147388: Add diagnostic commands to attach JVMTI agent.

Hi David, ShouldNotReachHere( ) is called at NMTDcmd: http://hg.openjdk.java.net/jdk9/hs-rt/hotspot/file/8fcd5cba7938/src/share/vm/services/nmtDCmd.cpp#l156 If target VM is aborted, caller (e.g. jcmd) cannot receive response. I think that the caller show Exception. Thanks, Yasumasa 2016/01/20

Re: RFR: JDK-8147388: Add diagnostic commands to attach JVMTI agent.

Hi Serguei, Thank you for your comment. I will fix them before creating changeset. Thanks, Yasumasa 2016/01/20 4:04 "serguei.spit...@oracle.com" : > Hi Yasumasa, > > This looks pretty good. > Thank you for the enhancement! > > A couple of minor comments. > >

Re: RFR: 8146009: "pure virtual method called" with using new GC logging mechanism

On 19/01/2016 11:58 PM, Marcus Larsson wrote: Hi, Please review the following patch to fix an issue in UL causing the VM to crash during shutdown. The problem is that the static LogStdoutOutput is deinitialized before the last use of it (G1 concurrent thread tries to log very late during VM

Re: RFR: JDK-8147388: Add diagnostic commands to attach JVMTI agent.

David, > Anytime we start to use a language feature for the first time we need > to be extra diligent to make sure there are no unintended > side-effects and that all our supported compilers (and probably a few > others used in the community) do the right thing. A bit of googling > seems to

Re: RFR: JDK-8147388: Add diagnostic commands to attach JVMTI agent.

Hi, I uploaded a new webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8147388/webrev.03/ It is malloc/free version. If NULL returns from malloc(), it calls vm_exit_out_of_memory(). All test about this changes work fine. Please review. Thanks, Yasumasa On 2016/01/19 22:07, Dmitry

RFR: 8146009: "pure virtual method called" with using new GC logging mechanism

Hi, Please review the following patch to fix an issue in UL causing the VM to crash during shutdown. The problem is that the static LogStdoutOutput is deinitialized before the last use of it (G1 concurrent thread tries to log very late during VM shutdown). The solution is to make sure

Re: RFR[9u-dev] 8130425: libjvm crash due to stack overflow in executables with 32k tbss/tdata

Hi David, On 1/18/16 2:48 AM, David Holmes wrote: Hi Roger, On 16/01/2016 3:43 AM, Roger Riggs wrote: Hi, If just doubling the size of the Reaper stack would suffice, I would start there. That's too specific. It might be fix this problem case today, but break again tomorrow. I was

RFR: 8147609: Correct the @build statements in the serviceability/dcmd/gc/HeapDumpAllTest.java and HeapDumpTest.java tests

Hi, Could you, please, review this trivial test-only change: CR: https://bugs.openjdk.java.net/browse/JDK-8147609 "Correct the @build statements in the serviceability/dcmd/gc/HeapDumpAllTest.java and HeapDumpTest.java tests" Webrev: http://cr.openjdk.java.net/~akulyakh/8147609/index.html The

Re: RFR: JDK-8147388: Add diagnostic commands to attach JVMTI agent.

Yasumasa, Looks good for me. -Dmitry On 2016-01-19 16:19, Yasumasa Suenaga wrote: > Hi, > > I uploaded a new webrev: > http://cr.openjdk.java.net/~ysuenaga/JDK-8147388/webrev.03/ > > It is malloc/free version. > If NULL returns from malloc(), it calls vm_exit_out_of_memory(). > > All test

Re: RFR: 8147609: Correct the @build statements in the serviceability/dcmd/gc/HeapDumpAllTest.java and HeapDumpTest.java tests

On 19.1.2016 16:32, Alexander Kulyakhtin wrote: Hi, Could you, please, review this trivial test-only change: CR: https://bugs.openjdk.java.net/browse/JDK-8147609 "Correct the @build statements in the serviceability/dcmd/gc/HeapDumpAllTest.java and HeapDumpTest.java tests" Webrev:

Re: RFR: 8146009: "pure virtual method called" with using new GC logging mechanism

Hi Marcus, I think all the copyrights need to be updated. Since I had been able to reproduce the problem on nearly every run, I tried your fix and the crash no longer occurs. However, I now see that in about 1 in 5 runs, the final message that used to trigger the crash now gets printed

Re: RFR: 8147609: Correct the @build statements in the serviceability/dcmd/gc/HeapDumpAllTest.java and HeapDumpTest.java tests

Jaroslav, Thank you very much for the review. Best regards, Alexander - Original Message - From: jaroslav.bacho...@oracle.com To: alexander.kulyakh...@oracle.com, serviceability-dev@openjdk.java.net Cc: stefan.sa...@oracle.com Sent: Tuesday, January 19, 2016 7:03:16 PM GMT +03:00 Iraq