RFR(xs): 8148053: Remove unused log tags

2016-01-22 Thread Robbin Ehn
Hi, Please review, this removes unused tags in UL. Testing: Passed RBT build Bug: https://bugs.openjdk.java.net/browse/JDK-8148053 Webrev: http://cr.openjdk.java.net/~mlarsson/rehn/8148053/ Thanks and thanks Marcus for hosting! /Robbin

Re: jmx-dev [8] RFR(S): 8147857: RMIConnector logs attribute names incorrectly

2016-01-22 Thread Andrew Hughes
- Original Message - > > On 22/01/16 15:58, Andrew Hughes wrote: > >> >Yes - please fix this issue in JDK 9 first as per rule 1: > >> >http://openjdk.java.net/projects/jdk8u/groundrules.html > >> > > >> >In a nutshell, produce a JDK 9 webrev, send it to > >>

Re: RFR(xs): 8148053: Remove unused log tags

2016-01-22 Thread Staffan Larsen
Looks good! Thanks, /Staffan > On 22 jan. 2016, at 16:00, Robbin Ehn wrote: > > Hi, > > Please review, this removes unused tags in UL. > > Testing: > Passed RBT build > > Bug: https://bugs.openjdk.java.net/browse/JDK-8148053 > Webrev:

Re: RFR: JDK-8147447: [TESTBUG] serviceability/tmtools/jstack/WaitNotifyThreadTest.java test fails

2016-01-22 Thread Alexander Kulyakhtin
Hi Staffan, Following your suggestion below, I'm going to restrict the possible options for the test to -Xmixed only and verify that either of the two patterns is present in the jstack output. I'm going to submit a review after testing with all the options combinations. Best regards,

Re: RFR: JDK-8147388: Add diagnostic commands to attach JVMTI agent.

2016-01-22 Thread Dmitry Samersoff
Yasumasa, It's dangerous to allow arbitrary length string to be passed to running process. We should limit it to some reasonable value. It is much easier to increase the limit if necessary than debug random allocation failures caused by too long string. e.g. Corrupted script (or admin mistake)

Re: RFR: JDK-8147388: Add diagnostic commands to attach JVMTI agent.

2016-01-22 Thread Dmitry Samersoff
Yasumasa, I would prefer to check that opt_len is less than PATH_MAX *before* any attempt to allocate memory to avoid any possible attack/missuses. I.e.: int opt_len = strlen(_libpath.value()) + strlen(_option.value()) + 2; if (opt_len > PATH_MAX) { output()->print_cr("JVMTI agent attach

Re: [8] RFR(S): 8147857: RMIConnector logs attribute names incorrectly

2016-01-22 Thread Severin Gehwolf
On Thu, 2016-01-21 at 18:03 +0100, Daniel Fuchs wrote: > On 21/01/16 15:20, Severin Gehwolf wrote: > > Thanks, Jaroslav. Any JDK 8 reviewer willing to have a look at this? > > Looks good to me Severin. Thank you, Daniel! Cheers, Severin > best regards, > > -- daniel > > > > Thanks, > >

Re: RFR: JDK-8147388: Add diagnostic commands to attach JVMTI agent.

2016-01-22 Thread Yasumasa Suenaga
Dmitry, Can we limit the length of argument? I guess that we can pass more length when we use -agentlib, -javaagent, etc. (I do not know about commandline length.) Thanks, Yasumasa 2016/01/22 17:45 "Dmitry Samersoff" : > Yasumasa, > > I would prefer to check that

Re: RFR: 8146009: "pure virtual method called" with using new GC logging mechanism

2016-01-22 Thread David Holmes
On 22/01/2016 3:00 AM, Thomas Stüfe wrote: Hi, On Wed, Jan 20, 2016 at 2:01 PM, k...@kodewerk.com > wrote: > On Jan 20, 2016, at 5:20 AM, David Holmes > wrote:

Re: RFR: 8146009: "pure virtual method called" with using new GC logging mechanism

2016-01-22 Thread Staffan Larsen
> On 22 jan. 2016, at 13:21, David Holmes wrote: > > On 22/01/2016 3:00 AM, Thomas Stüfe wrote: >> Hi, >> >> On Wed, Jan 20, 2016 at 2:01 PM, k...@kodewerk.com >> > > wrote: >> >> >>> On Jan

Re: jmx-dev [8] RFR(S): 8147857: RMIConnector logs attribute names incorrectly

2016-01-22 Thread Seán Coffey
On 22/01/16 15:58, Andrew Hughes wrote: >Yes - please fix this issue in JDK 9 first as per rule 1: >http://openjdk.java.net/projects/jdk8u/groundrules.html > >In a nutshell, produce a JDK 9 webrev, send it to >serviceability-dev@openjdk.java.net for review and once reviewed, push >to jdk9/dev

Re: RFR(xs): 8148053: Remove unused log tags

2016-01-22 Thread Marcus Larsson
Hi Robbin, On 01/22/2016 04:00 PM, Robbin Ehn wrote: Hi, Please review, this removes unused tags in UL. Testing: Passed RBT build Bug: https://bugs.openjdk.java.net/browse/JDK-8148053 Webrev: http://cr.openjdk.java.net/~mlarsson/rehn/8148053/ Looks good to me! Marcus Thanks and thanks

Re: jmx-dev [8] RFR(S): 8147857: RMIConnector logs attribute names incorrectly

2016-01-22 Thread Andrew Hughes
- Original Message - > On 22/01/16 14:50, Andrew Hughes wrote: > > - Original Message - > >> On 21/01/16 15:20, Severin Gehwolf wrote: > >>> Thanks, Jaroslav. Any JDK 8 reviewer willing to have a look at this? > >> Looks good to me Severin. > >> > > It looks good to me also; I