RFR : JDK-8147610 - javax/management/mxbean/MXBeanLoadingTest1.java assumes URLClassLoader

Hi All, I request you to review fix for, Issue : JDK-8147610 - javax/management/mxbean/MXBeanLoadingTest1.java assumes URLClassLoader Webrev : http://cr.openjdk.java.net/~hb/8147610/werev.00/ The fix is simple and self-explanatory. Thanks Harsha

Re: RFR(xs): 8149096: Remove unused code in methodComparator

On 2/8/16 20:20, David Holmes wrote: On 9/02/2016 5:22 AM, serguei.spit...@oracle.com wrote: Hi Thomas, The fix looks good. The following variable and all its uses are dead too as it never gets 'true' value. I think _switchable_test is the variable Serguei was referring to. Yes. I forgot to

Re: RFR(xs): 8149096: Remove unused code in methodComparator

On 9/02/2016 5:22 AM, serguei.spit...@oracle.com wrote: Hi Thomas, The fix looks good. The following variable and all its uses are dead too as it never gets 'true' value. I think _switchable_test is the variable Serguei was referring to. The whole notion of switchability is "dead" now so all

Re: RFR(xs): 8149096: Remove unused code in methodComparator

Hi Thomas, The fix looks good. The following variable and all its uses are dead too as it never gets 'true' value. But it is up to you to fix it or not. I can sponsor and push the fix. Thank you for taking care about this. Serguei On 2/8/16 06:24, Thomas Stüfe wrote: Hi all, please review

Re: RFR: 8144732: VM_HeapDumper hits assert with bad dump_len

Andreas, On 2016-02-08 17:18, Andreas Eriksson wrote: > Hi, > > On 2016-02-08 13:28, Dmitry Samersoff wrote: >> Andreas, >> >> Sorry for delay. >> >> Code changes looks good for me. >> >> But behavior of non-segmented dump is not clean for me (1074, if dump is >> not segmented than the size of th

RFR(xs): 8149096: Remove unused code in methodComparator

Hi all, please review and sponsor this little change. It gets rid of two unused methods in methodComparator(cpp/hpp). We stumbled over this because of warings about unchecked realloc() return values; but instead of fixing the code, we may just remove the offending methods, because they are not us

Re: RFR: 8144732: VM_HeapDumper hits assert with bad dump_len

Hi, On 2016-02-08 13:28, Dmitry Samersoff wrote: Andreas, Sorry for delay. Code changes looks good for me. But behavior of non-segmented dump is not clean for me (1074, if dump is not segmented than the size of the dump is always less than max_bytes and code below (1086) will not be executed.

Re: Unused code in prims/methodComparator

On 2/6/16 4:59 AM, David Holmes wrote: On 6/02/2016 12:26 AM, Daniel D. Daugherty wrote: MethodComparator::methods_switchable() appears to be a day zero function added by Misha Dmitriev back on 2000.10.23. And was it actually used? I was trying to find out when it stopped being used but gav

Re: RFR: 8144732: VM_HeapDumper hits assert with bad dump_len

Andreas, Sorry for delay. Code changes looks good for me. But behavior of non-segmented dump is not clean for me (1074, if dump is not segmented than the size of the dump is always less than max_bytes and code below (1086) will not be executed. I think today we may always write a segmented heap

Ping: RFR: JDK-8148659: Add all option to JSnap

Ping: Could you review this change? Yasumasa 2016/01/31 0:48 "Yasumasa Suenaga" : > I want to add -a (all) option to JSnap because JSnap is very useful to > analyze core image. > > Currently, JSnap can show PerfDataEntry which namespace is java.* or > com.sun.* . > We can use jcmd with PerfCount

PING: Check PerfCounter in core image through JSnap

Ping: Can I file it to JBS as new issue? Yasumasa 2016/01/30 23:08 "Yasumasa Suenaga" : > Hi all, > > I want to check PerfCounter in core image to analyze state of crashed JVM. > When I use JSnap tool, I encountered NPE on Fedora 23 x86_64. > > I checked core image, and I found PerfMemory::_start