RE: RFR: 8147456 Parsing of argument for -agentpath can write outside of allocated memory

Thanks David. I have changed the copyright year to 2016. -Sharath Ballal -Original Message- From: David Holmes Sent: Tuesday, March 01, 2016 10:29 AM To: Sharath Ballal; serviceability-dev@openjdk.java.net Subject: Re: RFR: 8147456 Parsing of argument for -agentpath can write outside

Re: RFR: 8147456 Parsing of argument for -agentpath can write outside of allocated memory

Hi Sharath, On 1/03/2016 2:39 AM, Sharath Ballal wrote: Hi David, I have created a java testcase. The webrev link is: http://cr.openjdk.java.net/~jbachorik/sponsorship/8147456/webrev.04/ Seems fine. Just fix the copyright year: Copyright (c) 2003, 2016, Should only be 2016 for this new

Re: PING: Check PerfCounter in core image through JSnap

PING: Can I file this to JBS ? On 2016/02/14 21:27, Yasumasa Suenaga wrote: Ping: What do you think about this issue? Yasumasa On 2016/02/08 19:17, Yasumasa Suenaga wrote: Ping: Can I file it to JBS as new issue? Yasumasa 2016/01/30 23:08 "Yasumasa Suenaga"

PING: RFR: JDK-8148659: Add all option to JSnap

PING: Could you review and sponsor? On 2016/02/14 21:28, Yasumasa Suenaga wrote: Ping: Could you review? Yasumasa On 2016/02/08 19:19, Yasumasa Suenaga wrote: Ping: Could you review this change? Yasumasa 2016/01/31 0:48 "Yasumasa Suenaga"

Re: RFR(S, TESTONLY): JDK-8150318 serviceability/dcmd/jvmti/LoadAgentDcmdTest.java - Could not find JDK_DIR/lib/x86_64/libinstrument.so

On 2/29/16 08:21, Jaroslav Bachorik wrote: Looks good modulo the comments from Jaroslav. Thanks, Serguei Hi, On 29.2.2016 17:12, Dmitry Samersoff wrote: Everybody, Please review test changes: http://cr.openjdk.java.net/~dsamersoff/JDK-8150318/webrev.01/ Looks good - just a few nits.

RE: RFR: 8147456 Parsing of argument for -agentpath can write outside of allocated memory

Hi David, I have created a java testcase. The webrev link is: http://cr.openjdk.java.net/~jbachorik/sponsorship/8147456/webrev.04/ -Sharath Ballal -Original Message- From: David Holmes Sent: Tuesday, February 23, 2016 7:15 AM To: Sharath Ballal; serviceability-dev@openjdk.java.net

Re: RFR(S, TESTONLY): JDK-8150318 serviceability/dcmd/jvmti/LoadAgentDcmdTest.java - Could not find JDK_DIR/lib/x86_64/libinstrument.so

Hi, On 29.2.2016 17:12, Dmitry Samersoff wrote: Everybody, Please review test changes: http://cr.openjdk.java.net/~dsamersoff/JDK-8150318/webrev.01/ Looks good - just a few nits. Please, update the copyright years accordingly.

RFR(S, TESTONLY): JDK-8150318 serviceability/dcmd/jvmti/LoadAgentDcmdTest.java - Could not find JDK_DIR/lib/x86_64/libinstrument.so

Everybody, Please review test changes: http://cr.openjdk.java.net/~dsamersoff/JDK-8150318/webrev.01/ -Dmitry -- Dmitry Samersoff Oracle Java development team, Saint Petersburg, Russia * I would love to change the world, but they won't give me the sources.

Re: RFR: JDK-8150723: HSDB toolbar icons are missing.

Looks correct to me. Thanks for doing this! /Erik On 2016-02-29 14:28, Dmitry Samersoff wrote: > Yasumasa, > > Looks good for me! > > -Dmitry > > > On 2016-02-29 16:26, Yasumasa Suenaga wrote: >> Hi Dmitry, Erik, >> >> I've uploaded new webrev: >> >> hotspot: >>

Re: RFR: JDK-8150723: HSDB toolbar icons are missing.

Yasumasa, Looks good for me! -Dmitry On 2016-02-29 16:26, Yasumasa Suenaga wrote: > Hi Dmitry, Erik, > > I've uploaded new webrev: > > hotspot: > http://cr.openjdk.java.net/~ysuenaga/JDK-8150723/webrev.02/hotspot/ > makefile:

Re: RFR: JDK-8150723: HSDB toolbar icons are missing.

Hi Dmitry, Erik, I've uploaded new webrev: hotspot: http://cr.openjdk.java.net/~ysuenaga/JDK-8150723/webrev.02/hotspot/ makefile: http://cr.openjdk.java.net/~ysuenaga/JDK-8150723/webrev.02/make/ > Could you move gif files to correct location and remove custom makefile > logic? I moved

Re: RFR(s): 8150026: Add the ability to log with variable log level

Hi Robbin, On 02/18/2016 08:37 PM, Robbin Ehn wrote: Hi, please review. This adds a write method to the UL log which takes the level as parameter. JBS: https://bugs.openjdk.java.net/browse/JDK-8150026 Webrev: http://cr.openjdk.java.net/~mlarsson/rehn/8150026/ Looks good, thanks for fixing

Re: [8u-dev] RFR 8150070: TESTBUG: com/sun/jdi tests fail on Cygwin but pass on MKS

Kindly reminder Please, review Thanks -Konstantin On 02/18/2016 07:07 PM, Konstantin Shefov wrote: Hello Please review a test bug fix. The test fails because Cygwin PID returned by "$!" and Windows PID returned by "tasklist" are not the same. Need to use cygwin "ps". Bug:

Re: RFR: JDK-8150723: HSDB toolbar icons are missing.

Yasumasa, I think it's better to have a complete fix rather than yet another workaround. Could you move gif files to correct location and remove custom makefile logic? I'll sponsor the push then. -Dmitry On 2016-02-27 06:44, Yasumasa Suenaga wrote: > Hi Erik, > > Thanks! > I've uploaded new