Re: RFR: 8146879: Add option for handling existing log files in UL

Updated patch after feedback. New webrev: http://cr.openjdk.java.net/~mlarsson/8146879/webrev.04/ Incremental: http://cr.openjdk.java.net/~mlarsson/8146879/webrev.03-04/ Tested with internal VM tests through RBT. Changes: * Rotation filecount is now limited to 1000 files. * Removed loop in os:

RE: RFR(XS): 8152119: Event-based tracing to allow for tracing Klass definition

Thanks Erik! Markus From: Erik Gahlin Sent: den 18 mars 2016 00:39 To: serviceability-dev@openjdk.java.net Subject: Re: RFR(XS): 8152119: Event-based tracing to allow for tracing Klass definition Looks good. Not a reviewer. Erik On 2016-03-17 19:43, Markus Gronlund wrote: Greetings

Re: RFR(xs): 8151993: Remove inclusion of inline.hpp in log.hpp

Hi Carsten, thanks for looking at this. On 03/16/2016 05:27 PM, Carsten Varming wrote: Dear Robbin, It would be much nicer if the code was changed to call a new method in a cpp file (this is clearly a slow path) and the new method could use a This is a template class. bufferedStream to auto

Re: RFR(m): 8150015: Integrate TraceTime with Unified Logging more seamlessly

Hi Robbin, Thanks for filing the RFE. Bengt On 2016-03-17 11:51, Robbin Ehn wrote: Hi Bengt Thanks for your input. On 03/16/2016 11:38 AM, Bengt Rutisson wrote: Hi Robbin, On 2016-03-15 21:31, Robbin Ehn wrote: Hi, please review this enhancement. This adds support for multiple UL tags

Re: RFR: 8150823: UL handles disabling logs incorrectly

Hi, Updated the patch after offline discussion. New patch attempts to normalize the output name before searching for it or adding it. This includes adding the implicit file= prefix if missing, and/or removing quotes from a quoted name. Webrev: http://cr.openjdk.java.net/~mlarsson/8150823/web

Re: RFR: JDK-8151674: STW phases at Concurrent GC should count in PerfCounter

Hi Jon, 2016/03/17 3:25 "Jon Masamitsu" : > > > > On 03/10/2016 07:59 PM, Yasumasa Suenaga wrote: >> >> Hi all, >> >> This review request continues from: >> http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2016-March/016774.html >> http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2016-Ma

Re: RFR(xs): 8151993: Remove inclusion of inline.hpp in log.hpp

> On Mar 17, 2016, at 2:44 AM, Robbin Ehn wrote: > On 03/16/2016 05:13 PM, Kim Barrett wrote: >>> On Mar 16, 2016, at 8:33 AM, Robbin Ehn wrote: >>> >>> Hi, please review this small change. >>> >>> This also change allocation methods. >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-81519

Re: RFR(m): 8150015: Integrate TraceTime with Unified Logging more seamlessly

Hi Bengt Thanks for your input. On 03/16/2016 11:38 AM, Bengt Rutisson wrote: Hi Robbin, On 2016-03-15 21:31, Robbin Ehn wrote: Hi, please review this enhancement. This adds support for multiple UL tags in TraceTime. Bug: https://bugs.openjdk.java.net/browse/JDK-8150015/ Webrev: http://cr.