Hi all,
Please review this bug fix.
Bug: https://bugs.openjdk.java.net/browse/JDK-8154064
Test with tonga. (the 5 crashed tonga test no longer crashes)
Thanks!
/Robbin
diff -r 4823056a5bbd src/share/vm/prims/jvmtiExport.cpp
--- a/src/share/vm/prims/jvmtiExport.cppTue Apr 12 09:08:48
On 4/12/16 18:43, Coleen Phillimore wrote:
Hi Serguei,
On 4/12/16 9:35 PM, serguei.spit...@oracle.com wrote:
On 4/12/16 12:29, Coleen Phillimore wrote:
Hi Serguei,
Thank you for looking at this change.
On 4/11/16 9:17 PM, serguei.spit...@oracle.com wrote:
Coleen,
Hi Serguei,
On 4/12/16 9:35 PM, serguei.spit...@oracle.com wrote:
On 4/12/16 12:29, Coleen Phillimore wrote:
Hi Serguei,
Thank you for looking at this change.
On 4/11/16 9:17 PM, serguei.spit...@oracle.com wrote:
Coleen,
src/share/vm/prims/jvmtiRedefineClasses.cpp
- // Update the version
On 4/12/16 12:29, Coleen Phillimore wrote:
Hi Serguei,
Thank you for looking at this change.
On 4/11/16 9:17 PM, serguei.spit...@oracle.com wrote:
Coleen,
src/share/vm/prims/jvmtiRedefineClasses.cpp
- // Update the version number of the constant pool
+ // Update the version number of the
2016-04-12 15:34 GMT-06:00 Daniel D. Daugherty :
> I'm also good with the fix. At this point, I think everyone who
> has commented on this fix previously has chimed in...
Yeah, this change shouldn't be controversial, I'm just waiting for
someone to push it to the
I'm also good with the fix. At this point, I think everyone who
has commented on this fix previously has chimed in...
Dan
On 4/12/16 3:12 PM, Dmitry Samersoff wrote:
Alex,
The fix looks good for me.
-Dmitry
On 2016-04-12 22:28, Alex Henrie wrote:
# HG changeset patch
# User Alex Henrie
Alex,
The fix looks good for me.
-Dmitry
On 2016-04-12 22:28, Alex Henrie wrote:
> # HG changeset patch
> # User Alex Henrie
> # Date 1447827030 25200
> # Tue Nov 17 23:10:30 2015 -0700
> # Node ID 66c6fa3b2280afa12a2d51ea668b6a781b5744b5
> # Parent
On 4/12/16 13:11, Alex Henrie wrote:
2016-04-12 14:07 GMT-06:00 serguei.spit...@oracle.com
:
Hi Alex,
The fix looks good.
Could you tell why this is important to you, what is the motivation?
Do you really observe this problem, or it is based on a static analysis?
I
2016-04-12 14:07 GMT-06:00 serguei.spit...@oracle.com
:
> Hi Alex,
>
> The fix looks good.
> Could you tell why this is important to you, what is the motivation?
> Do you really observe this problem, or it is based on a static analysis?
I was playing around with the
Hi Alex,
The fix looks good.
Could you tell why this is important to you, what is the motivation?
Do you really observe this problem, or it is based on a static analysis?
Thanks,
Serguei
On 4/12/16 12:28, Alex Henrie wrote:
# HG changeset patch
# User Alex Henrie
#
Ioi,
> On Apr 11, 2016, at 7:11 PM, Ioi Lam wrote:
>
> Hi Jiangli,
>
>
> Thanks for the review:
>
> On 4/11/16 6:44 PM, Jiangli Zhou wrote:
>> Hi Ioi,
>>
>> I like the more structural way of reading/writing the compact table with
>> SimpleCompactHashtable. It looks
Hi Serguei,
Thank you for looking at this change.
On 4/11/16 9:17 PM, serguei.spit...@oracle.com wrote:
Coleen,
src/share/vm/prims/jvmtiRedefineClasses.cpp
- // Update the version number of the constant pool
+ // Update the version number of the constant pools (may keep scratch_cp)
# HG changeset patch
# User Alex Henrie
# Date 1447827030 25200
# Tue Nov 17 23:10:30 2015 -0700
# Node ID 66c6fa3b2280afa12a2d51ea668b6a781b5744b5
# Parent 1f8c4b1a301c989dc299cad63dbc530b1de3ed70
8145278: Fix memory leak in splitPathList
diff --git
Thanks for the explanation. The change looks good.
Do you know if the change in jps output was intentional or caused by something
else?
> On 12 apr. 2016, at 16:32, Dmitry Samersoff
> wrote:
>
> Staffan,
>
> On 2016-04-12 16:32, Staffan Larsen wrote:
>> Can you
Hi Andreas,
The fix looks good.
Thanks,
Serguei
On 4/12/16 09:05, Andreas Eriksson wrote:
Hi,
Please review this fix for 8153641: assert(thread_state ==
_thread_in_native) failed: Assumed thread_in_native while heap dump
Bug: https://bugs.openjdk.java.net/browse/JDK-8153641
Webrev:
Dmitry,
It looks good.
Thanks,
Serguei
On 4/12/16 05:36, Dmitry Samersoff wrote:
Everybody,
Please, review the fix.
http://cr.openjdk.java.net/~dsamersoff/JDK-8152847/webrev.01/
Public interface PathSearchingVirtualMachine.bootClassPath() left
untouched, but
Thanks Dmitry!
- Andreas
On 2016-04-12 18:07, Dmitry Samersoff wrote:
Andreas,
Looks good for me!
-Dmitry
On 2016-04-12 19:05, Andreas Eriksson wrote:
Hi,
Please review this fix for 8153641: assert(thread_state ==
_thread_in_native) failed: Assumed thread_in_native while heap dump
Bug:
Andreas,
Looks good for me!
-Dmitry
On 2016-04-12 19:05, Andreas Eriksson wrote:
> Hi,
>
> Please review this fix for 8153641: assert(thread_state ==
> _thread_in_native) failed: Assumed thread_in_native while heap dump
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8153641
> Webrev:
Hi,
Please review this fix for 8153641: assert(thread_state ==
_thread_in_native) failed: Assumed thread_in_native while heap dump
Bug: https://bugs.openjdk.java.net/browse/JDK-8153641
Webrev: http://cr.openjdk.java.net/~aeriksso/8153641/webrev.00/
The crash is because changes I did in
Staffan,
On 2016-04-12 16:32, Staffan Larsen wrote:
> Can you explain what is going on here? It looks like the old code
> looked for the TTY process, whereas the new code accepts any process.
> What am I missing?
Both code select jdbCmd first:
ll. 926
jdbCmd=`$jdk/bin/jps -v | $grep
Ping!
On 04/06/2016 08:46 AM, Marcus Larsson wrote:
Hi,
Please review the following patch to add a warning for when tag
selections in -Xlog or VM.log don't match any tag sets used in the VM.
Webrev:
http://cr.openjdk.java.net/~mlarsson/8150894/webrev.00/
Issue:
Can you explain what is going on here? It looks like the old code looked for
the TTY process, whereas the new code accepts any process. What am I missing?
> On 12 apr. 2016, at 14:28, Dmitry Samersoff
> wrote:
>
> Everybody,
>
> Please review a small fix.
>
>
On 12/04/2016 13:36, Dmitry Samersoff wrote:
Everybody,
Please, review the fix.
http://cr.openjdk.java.net/~dsamersoff/JDK-8152847/webrev.01/
Public interface PathSearchingVirtualMachine.bootClassPath() left
untouched, but VirtualMachineImpl.bootClassPath() returns an empty list.
This
Everybody,
Please, review the fix.
http://cr.openjdk.java.net/~dsamersoff/JDK-8152847/webrev.01/
Public interface PathSearchingVirtualMachine.bootClassPath() left
untouched, but VirtualMachineImpl.bootClassPath() returns an empty list.
Tested with RBT
-Dmitry
--
Dmitry Samersoff
Oracle Java
Everybody,
Please review a small fix.
http://cr.openjdk.java.net/~dsamersoff/JDK-8153856/webrev.01/
This fix doesn't fix root cause of the test fail but fix small test bug
to get better diagnostic.
-Dmitry
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would
+1
-Sundar
On 4/12/2016 11:42 AM, serguei.spit...@oracle.com wrote:
> Ping...
>
> Thanks,
> Serguei
>
>
> On 4/8/16 16:04, serguei.spit...@oracle.com wrote:
>> Please, review this trivial, test-only change (enabling previously
>> excluded tests).
>>
>> Bug:
>>
Ping...
Thanks,
Serguei
On 4/8/16 16:04, serguei.spit...@oracle.com wrote:
Please, review this trivial, test-only change (enabling previously
excluded tests).
Bug:
https://bugs.openjdk.java.net/browse/JDK-8153902
Summary:
The tests need to be enabled again after the fix of:
27 matches
Mail list logo