Re: RFR: 8153749 - New capability can_generate_early_class_hook_events

2016-04-14 Thread serguei.spit...@oracle.com
Alan, This is for sanity check: The updated hotspot webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/8153749-Jigsaw-newcap.hs2/ Please, note that the *src/share/vm/prims/jvmtiEnvBase.hpp* was corrected too. Please, find the JVMTI spec here: http:://cr.openjdk.java.net/~sspit

Re: RFR: 8153749 - New capability can_generate_early_class_hook_events

2016-04-14 Thread serguei.spit...@oracle.com
On 4/14/16 13:00, Alan Bateman wrote: On 14/04/2016 19:35, serguei.spit...@oracle.com wrote: : or it is about something like this: "When can_generate_early_class_hook_events and can_generate_all_class_hook_events are enabled then this event may be sent in the primordial phase. Otherw

Re: RFR: 8153749 - New capability can_generate_early_class_hook_events

2016-04-14 Thread Alan Bateman
On 14/04/2016 19:35, serguei.spit...@oracle.com wrote: : or it is about something like this: "When can_generate_early_class_hook_events and can_generate_all_class_hook_events are enabled then this event may be sent in the primordial phase. Otherwise, this event may be sent before the

Re: RFR: 8153749 - New capability can_generate_early_class_hook_events

2016-04-14 Thread serguei.spit...@oracle.com
On 4/14/16 06:53, Alan Bateman wrote: On 14/04/2016 09:24, serguei.spit...@oracle.com wrote: Please, review the Jigsaw-related fix for: https://bugs.openjdk.java.net/browse/JDK-8153749 Hotspot webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/8153749-Jigsaw-newcap.hs1/

Re: RFR: 8153749 - New capability can_generate_early_class_hook_events

2016-04-14 Thread Alan Bateman
On 14/04/2016 09:24, serguei.spit...@oracle.com wrote: Please, review the Jigsaw-related fix for: https://bugs.openjdk.java.net/browse/JDK-8153749 Hotspot webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/8153749-Jigsaw-newcap.hs1/ Jdk webrev: http://cr.openjdk.java.net/

RFR: 8154059: JVMTI ObjectTagging to UL

2016-04-14 Thread Robbin Ehn
Hi all, Please review: This moves jvmti object-tagging output to the tag-set jvmti,objecttagging on debug level. The TraceJVMTIObjectTagging argument is deprecated and aliased with: "-Xlog:jvmti+objecttagging=debug" Did this on top of: http://mail.openjdk.java.net/pipermail/hotspot-runtime-d

RFR: 8154041: JVMTI to Unified Logging

2016-04-14 Thread Robbin Ehn
Hi all, Please review: This moves jvmti trace output to the tag jvmti on trace level. The jvmti trace argument e.g. "-XX:TraceJVMTI=ec+ieost,all+ieost" have a lot of functionality, e.g. can filter on func, in/out, etc, so it if left as is. TraceJVMTI enables jvmti trace to stdout if no othe

Re: RFR: 8153749 - New capability can_generate_early_class_hook_events

2016-04-14 Thread serguei.spit...@oracle.com
Thanks, Dmitry! Serguei On 4/14/16 02:24, Dmitry Samersoff wrote: Serguei, Looks good for me. -Dmitry On 2016-04-14 11:24, serguei.spit...@oracle.com wrote: Please, review the Jigsaw-related fix for: https://bugs.openjdk.java.net/browse/JDK-8153749 Hotspot webrev: http://cr.openjdk.ja

Re: RFR: 8153749 - New capability can_generate_early_class_hook_events

2016-04-14 Thread Dmitry Samersoff
Serguei, Looks good for me. -Dmitry On 2016-04-14 11:24, serguei.spit...@oracle.com wrote: > Please, review the Jigsaw-related fix for: > https://bugs.openjdk.java.net/browse/JDK-8153749 > > > Hotspot webrev: > http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/8153749-Jigsaw-newcap.

Re: [PATCH resend2] 8145278: Fix memory leak in splitPathList

2016-04-14 Thread serguei.spit...@oracle.com
Alex, Your fix has been pushed. Thanks, Serguei On 4/12/16 14:56, Alex Henrie wrote: 2016-04-12 15:34 GMT-06:00 Daniel D. Daugherty : I'm also good with the fix. At this point, I think everyone who has commented on this fix previously has chimed in... Yeah, this change shouldn't be controve

RFR: 8153749 - New capability can_generate_early_class_hook_events

2016-04-14 Thread serguei.spit...@oracle.com
Please, review the Jigsaw-related fix for: https://bugs.openjdk.java.net/browse/JDK-8153749 Hotspot webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/8153749-Jigsaw-newcap.hs1/ Jdk webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/jdk/8153749-Jigsaw-newcap.jdk1/ Summ

Re: RFR(8u) JDK-8153252: SA: Hotspot build on Windows fails if make/closed folder does not exist

2016-04-14 Thread Erik Joelsson
Looks good to me. /Erik On 2016-04-13 22:49, Poonam Bajaj Parhar wrote: Hello, As per Erik's suggestion not to remove the existing check for HS_ALT_MAKE, here is the updated webrev: http://cr.openjdk.java.net/~poonam/8153252/webrev.01/ Thanks, Poonam On 4/11/2016 12:15 PM, Poonam Bajaj Par

Re: RFR(8u) JDK-8153252: SA: Hotspot build on Windows fails if make/closed folder does not exist

2016-04-14 Thread Dmitry Samersoff
Poonam, Looks good for me! -Dmitry On 2016-04-13 23:49, Poonam Bajaj Parhar wrote: > Hello, > > As per Erik's suggestion not to remove the existing check for > HS_ALT_MAKE, here is the updated webrev: > http://cr.openjdk.java.net/~poonam/8153252/webrev.01/ > > Thanks, > Poonam > > On 4/11/20