Re: PING: RFR: JDK-8153073: UL: Set filesize option with k/m/g

On 2016/05/05 10:52, David Holmes wrote: +1 from me. Thanks David! I will sponsor this - currently submitting to JPRT. Marcus will be a sponsor. Thanks, Yasumasa Thanks, David On 4/05/2016 11:49 PM, Marcus Larsson wrote: On 05/04/2016 03:43 PM, Yasumasa Suenaga wrote: Thanks,

Re: PING: RFR: JDK-8153073: UL: Set filesize option with k/m/g

+1 from me. I will sponsor this - currently submitting to JPRT. Thanks, David On 4/05/2016 11:49 PM, Marcus Larsson wrote: On 05/04/2016 03:43 PM, Yasumasa Suenaga wrote: Thanks, Marcus! into something like if (!success || values > SIZE_MAX) { Also, I think you probably need a

Re: RFR:8153978:New test to verify the modules info as returned by the JVMTI

Hi Alexander, It looks good. Thank you for making the changes! Thanks, Serguei On 5/4/16 05:17, Alexander Kulyakhtin wrote: Hi Sergey, Thank you very much for the review. Please, find the updated webrev with your findings corrected at:

Re: RFR(M): 8155091: Remove SA related functions from tmtools

> On May 4, 2016, at 12:40 PM, Dmitry Samersoff > wrote: > > Alan, > > On 2016-05-04 22:37, Alan Bateman wrote: >> Dmitry - did the ToolProvider spi go away too? > > Probably yes, but I have to check it. I also expect module-info.java for both jdk.jcmd and

Re: RFR(M): 8155091: Remove SA related functions from tmtools

Dmitry - did the ToolProvider spi go away too? On 04/05/2016 20:30, Dmitry Samersoff wrote: Everybody, Please review the changes: http://cr.openjdk.java.net/~dsamersoff/JDK-8155091/webrev.03/ We are spitting tmtools (jstack, jmap, jinfo) into two separate sets of tools to reduce a cost of

RFR(M): 8155091: Remove SA related functions from tmtools

Everybody, Please review the changes: http://cr.openjdk.java.net/~dsamersoff/JDK-8155091/webrev.03/ We are spitting tmtools (jstack, jmap, jinfo) into two separate sets of tools to reduce a cost of SA support. This is the last part of the split - removal of SA related code from jstack,

RFR: JDK-8156033: jhsdb jmap cannot set heapdump name

Hi all, This review request relates to [1]. We cannot change heapdump name (heap.bin) when we genarate heapdump via jhsdb. When we use jmap, we can change heapdump name through file option. I want to set it like a jmap. I uploaded webrev for this enhancement. Could you review it?

Re: PING: RFR: JDK-8153074: UL: Show output option in VM.log jcmd

Hi, On 05/04/2016 04:12 PM, Yasumasa Suenaga wrote: Hi Marcus, 93 out->print("filecount=%u,filesize=" SIZE_FORMAT "%s ", _file_count, byte_size_in_proper_unit(_rotate_size), proper_unit_for_byte_size(_rotate_size)); Thanks, I applied it to new webrev:

Re: PING: RFR: JDK-8153074: UL: Show output option in VM.log jcmd

Hi Marcus, 93 out->print("filecount=%u,filesize=" SIZE_FORMAT "%s ", _file_count, byte_size_in_proper_unit(_rotate_size), proper_unit_for_byte_size(_rotate_size)); Thanks, I applied it to new webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8153074/webrev.03/ Could you review again?

Re: PING: RFR: JDK-8153073: UL: Set filesize option with k/m/g

On 05/04/2016 03:43 PM, Yasumasa Suenaga wrote: Thanks, Marcus! into something like if (!success || values > SIZE_MAX) { Also, I think you probably need a static_cast here: 201 _rotate_size = value; I applied them to new webrev:

Re: PING: RFR: JDK-8153073: UL: Set filesize option with k/m/g

Thanks, Marcus! into something like if (!success || values > SIZE_MAX) { Also, I think you probably need a static_cast here: 201 _rotate_size = value; I applied them to new webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8153073/webrev.07/ Thanks, Yasumasa On 2016/05/04 21:38,

Re: PING: RFR: JDK-8153074: UL: Show output option in VM.log jcmd

Hi, On 05/04/2016 02:59 PM, Yasumasa Suenaga wrote: Hi Marcus, Thank you for your comment. http://cr.openjdk.java.net/~ysuenaga/JDK-8153074/webrev.02/ Looks better. The format for _rotate_size should be SIZE_FORMAT. While we're at it I think it would be good (as I mentioned) to use a

Re: PING: RFR: JDK-8153074: UL: Show output option in VM.log jcmd

Hi Marcus, Thank you for your comment. http://cr.openjdk.java.net/~ysuenaga/JDK-8153074/webrev.02/ I fixed to use _rotate_size and _file_count directly to show VM.log list jcmd. I do not store option string, and I added new function to print option string. Could you review it again?

Re: PING: RFR: JDK-8153073: UL: Set filesize option with k/m/g

Hi, On 05/04/2016 02:29 PM, Yasumasa Suenaga wrote: Hi David, Marcus, Thank you for your comment. I uploaded new webrev. Could you review it again? http://cr.openjdk.java.net/~ysuenaga/JDK-8153073/webrev.06/ Can you join these two cases: 193 if (!success) { 194 break; 195 } else if

Re: PING: RFR: JDK-8153073: UL: Set filesize option with k/m/g

Hi David, Marcus, Thank you for your comment. I uploaded new webrev. Could you review it again? http://cr.openjdk.java.net/~ysuenaga/JDK-8153073/webrev.06/ Thanks, Yasumasa On 2016/05/04 15:49, Marcus Larsson wrote: Hi, On 05/04/2016 03:45 AM, David Holmes wrote: On 4/05/2016 10:19

Re: RFR:8153978:New test to verify the modules info as returned by the JVMTI

Hi Sergey, Thank you very much for the review. Please, find the updated webrev with your findings corrected at: http://cr.openjdk.java.net/~akulyakh/8153978_02/index.html Best regards, Alexander - Original Message - From: serguei.spit...@oracle.com To:

Re: PING: RFR: JDK-8153074: UL: Show output option in VM.log jcmd

Hi, On 05/03/2016 01:43 PM, Yasumasa Suenaga wrote: PING: Could you review and sponsor it? http://cr.openjdk.java.net/~ysuenaga/JDK-8153074/webrev.01/ I would prefer to generate the option string from the actual options rather than saving the string from when it was configured. This would

Re: PING: RFR: JDK-8153073: UL: Set filesize option with k/m/g

Hi, On 05/04/2016 03:45 AM, David Holmes wrote: On 4/05/2016 10:19 AM, Yasumasa Suenaga wrote: Hi David, Marcus, I would not have done that but instead used a temporary julong for the parse result, then range check, then assign to the actual _rotate_size etc with a cast. Thanks. However, I