Re: RFR(XXS): 8160102: Typo in message for NULL memory size arguments in diagnosticArgument.cpp

Looks good. Thanks, David On 23/06/2016 6:57 AM, Dmitry Dmitriev wrote: Hello, Please review small patch which fixes error message for NULL memory size arguments. Currently message for nanotime arguments is printed. I change it to make it consistent with other error messages for memory size ar

Re: Jigsaw Enhancement RFR round #2: 8159145 Add JVMTI function GetModuleByPackageName

On 6/22/16 16:40, David Holmes wrote: On 23/06/2016 9:20 AM, serguei.spit...@oracle.com wrote: On 6/22/16 15:31, David Holmes wrote: On 23/06/2016 5:01 AM, Alan Bateman wrote: On 22/06/2016 19:36, serguei.spit...@oracle.com wrote: Alan, please, let me know if you support the Stanislav's sug

Re: Jigsaw Enhancement RFR round #2: 8159145 Add JVMTI function GetModuleByPackageName

Hi Serguei, What is the expected behavior when passed string is not a valid package name (e.g. contains illegal characters)? I think I'd expect JVMTI_ERROR_ILLEGAL_ARGUMENT to be returned in that case. Now it looks like the method will return unnamed module not only for an empty string but f

Re: Jigsaw Enhancement RFR round #2: 8159145 Add JVMTI function GetModuleByPackageName

On 23/06/2016 9:20 AM, serguei.spit...@oracle.com wrote: On 6/22/16 15:31, David Holmes wrote: On 23/06/2016 5:01 AM, Alan Bateman wrote: On 22/06/2016 19:36, serguei.spit...@oracle.com wrote: Alan, please, let me know if you support the Stanislav's suggestion. I can go ahead and implement r

Re: Jigsaw Enhancement RFR round #2: 8159145 Add JVMTI function GetModuleByPackageName

On 6/22/16 15:31, David Holmes wrote: On 23/06/2016 5:01 AM, Alan Bateman wrote: On 22/06/2016 19:36, serguei.spit...@oracle.com wrote: Alan, please, let me know if you support the Stanislav's suggestion. I can go ahead and implement returning the JVMTI_ERROR_ILLEGAL_ARGUMENT for invalid pack

Re: Jigsaw Enhancement RFR round #2: 8159145 Add JVMTI function GetModuleByPackageName

On 23/06/2016 5:01 AM, Alan Bateman wrote: On 22/06/2016 19:36, serguei.spit...@oracle.com wrote: Alan, please, let me know if you support the Stanislav's suggestion. I can go ahead and implement returning the JVMTI_ERROR_ILLEGAL_ARGUMENT for invalid package names. No objection from me. It wo

Re: Jigsaw Enhancement RFR round #2: 8159145 Add JVMTI function GetModuleByPackageName

On 6/22/16 13:54, Jiangli Zhou wrote: Hi Serguei, On Jun 22, 2016, at 1:17 PM, serguei.spit...@oracle.com wrote: Hi Jiangli, Fixed both places - nice catch! Would you like I list you as a reviewer? No worry, if you already committed/pushed your changes.

RFR(XXS): 8160102: Typo in message for NULL memory size arguments in diagnosticArgument.cpp

Hello, Please review small patch which fixes error message for NULL memory size arguments. Currently message for nanotime arguments is printed. I change it to make it consistent with other error messages for memory size arguments. JBS: https://bugs.openjdk.java.net/browse/JDK-8160102 webrev.

Re: Jigsaw Enhancement RFR round #2: 8159145 Add JVMTI function GetModuleByPackageName

Hi Serguei, > On Jun 22, 2016, at 1:17 PM, serguei.spit...@oracle.com wrote: > > Hi Jiangli, > > Fixed both places - nice catch! > Would you like I list you as a reviewer? No worry, if you already committed/pushed your changes. Thanks, Jiangli > > Thanks, > Serguei > > > On 6/22/16 10:29,

Re: Jigsaw Enhancement RFR round #2: 8159145 Add JVMTI function GetModuleByPackageName

Hi Jiangli, Fixed both places - nice catch! Would you like I list you as a reviewer? Thanks, Serguei On 6/22/16 10:29, Jiangli Zhou wrote: Hi Serguei, The comment in the following assert is outdated. There is no get_module_from_pkg. Should it be changed to get_module_by_package_name()? 80

Re: Jigsaw Enhancement RFR round #2: 8159145 Add JVMTI function GetModuleByPackageName

On 6/22/16 12:01, Alan Bateman wrote: On 22/06/2016 19:36, serguei.spit...@oracle.com wrote: Alan, please, let me know if you support the Stanislav's suggestion. I can go ahead and implement returning the JVMTI_ERROR_ILLEGAL_ARGUMENT for invalid package names. No objection from me. Ok, tha

Re: Jigsaw Enhancement RFR round #2: 8159145 Add JVMTI function GetModuleByPackageName

On 22/06/2016 19:36, serguei.spit...@oracle.com wrote: Alan, please, let me know if you support the Stanislav's suggestion. I can go ahead and implement returning the JVMTI_ERROR_ILLEGAL_ARGUMENT for invalid package names. No objection from me. It would be good to first check the existing spec

Re: Jigsaw Enhancement RFR round #2: 8159145 Add JVMTI function GetModuleByPackageName

On 6/22/16 11:11, serguei.spit...@oracle.com wrote: On 6/22/16 10:45, Alan Bateman wrote: On 22/06/2016 18:09, stanislav lukyanov wrote: Hi Serguei, What is the expected behavior when passed string is not a valid package name (e.g. contains illegal characters)? I think I'd expect JVMTI_ERRO

Re: Jigsaw Enhancement RFR round #2: 8159145 Add JVMTI function GetModuleByPackageName

Hi Stanislav, Thank you for looking at this update and the comments! On 6/22/16 10:09, stanislav lukyanov wrote: Hi Serguei, What is the expected behavior when passed string is not a valid package name (e.g. contains illegal characters)? I think I'd expect JVMTI_ERROR_ILLEGAL_ARGUMENT to be r

Re: Jigsaw Enhancement RFR round #2: 8159145 Add JVMTI function GetModuleByPackageName

On 6/22/16 10:45, Alan Bateman wrote: On 22/06/2016 18:09, stanislav lukyanov wrote: Hi Serguei, What is the expected behavior when passed string is not a valid package name (e.g. contains illegal characters)? I think I'd expect JVMTI_ERROR_ILLEGAL_ARGUMENT to be returned in that case. No

Re: Jigsaw Enhancement RFR round #2: 8159145 Add JVMTI function GetModuleByPackageName

On 22/06/2016 18:09, stanislav lukyanov wrote: Hi Serguei, What is the expected behavior when passed string is not a valid package name (e.g. contains illegal characters)? I think I'd expect JVMTI_ERROR_ILLEGAL_ARGUMENT to be returned in that case. Now it looks like the method will return

Re: Jigsaw Enhancement RFR round #2: 8159145 Add JVMTI function GetModuleByPackageName

Hi Serguei, The comment in the following assert is outdated. There is no get_module_from_pkg. Should it be changed to get_module_by_package_name()? 804 assert(ModuleEntryTable::javabase_defined(), 805 "Attempt to call get_module_from_pkg before java.base is defined"); It’s not par

Re: Jigsaw Enhancement RFR round #2: 8159145 Add JVMTI function GetModuleByPackageName

I've updated the libGetModuleByPkgTest.c in place in the webrev #2 with minor improvements. Sorry, if it spoiled your work. Thanks, Serguei On 6/22/16 04:07, serguei.spit...@oracle.com wrote: Here are new hotspot webrev where I've fixed the comments from Alan and Christian. Hotspot: http://

Jigsaw Enhancement RFR round #2: 8159145 Add JVMTI function GetModuleByPackageName

Here are new hotspot webrev where I've fixed the comments from Alan and Christian. Hotspot: http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/8159145-jigsaw-jvmti-pkg.2 The Jdk webrev is the same: http://javaweb.sfbay.sun.com/java/svc/ss45998/webrevs/2016/hotspot/8159145-jigsaw-jvmti-p

Re: Jigsaw Enhancement RFR: 8159145 Add JVMTI function GetModuleByPackageName

On 6/22/16 02:02, Alan Bateman wrote: On 22/06/2016 10:00, serguei.spit...@oracle.com wrote: Alan, Now I prefer to separate both changes. My plan was to separate dropping the JVM_* function as we discussed previously. The JPLISAgent can be updated as a part of adding back the transform meth

Re: Jigsaw Enhancement RFR: 8159145 Add JVMTI function GetModuleByPackageName

On 22/06/2016 10:00, serguei.spit...@oracle.com wrote: Alan, Now I prefer to separate both changes. My plan was to separate dropping the JVM_* function as we discussed previously. The JPLISAgent can be updated as a part of adding back the transform method class loader argument as the change

Re: Jigsaw Enhancement RFR: 8159145 Add JVMTI function GetModuleByPackageName

Alan, Now I prefer to separate both changes. My plan was to separate dropping the JVM_* function as we discussed previously. The JPLISAgent can be updated as a part of adding back the transform method class loader argument as the change is pretty trivial. But I can make this change as a part of

Re: Jigsaw Enhancement RFR: 8159145 Add JVMTI function GetModuleByPackageName

Serguei, One other question - are you going to drop the (temporary) JVM_* function and update the JPLISAgent as part of this or are you leaving that to a follow-on issue? -Alan