Re: RFR(S): 8168305 GC.class_stats should not require -XX:+UnlockDiagnosticVMOptions

2016-10-27 Thread Staffan Larsen
> On 27 Oct 2016, at 20:15, David Holmes wrote: > > On 27/10/2016 6:36 PM, Staffan Larsen wrote: >> All, >> >> Please review this small patch to remove the requirement >> -XX:+UnlockDiagnosticVMOptions when running the GC.class_stats diagnostic >> command. Diagnostic

Re: RFR(S): 8168305 GC.class_stats should not require -XX:+UnlockDiagnosticVMOptions

2016-10-27 Thread David Holmes
On 27/10/2016 6:36 PM, Staffan Larsen wrote: All, Please review this small patch to remove the requirement -XX:+UnlockDiagnosticVMOptions when running the GC.class_stats diagnostic command. Diagnostic commands are used for diagnosing problems and should not require restarting the JVM with a

Re: RFR(S): 8168305 GC.class_stats should not require -XX:+UnlockDiagnosticVMOptions

2016-10-27 Thread Ioi Lam
Looks good. Thanks - Ioi On 10/27/16 2:41 AM, Marcus Larsson wrote: Hi Staffan, On 2016-10-27 10:36, Staffan Larsen wrote: All, Please review this small patch to remove the requirement -XX:+UnlockDiagnosticVMOptions when running the GC.class_stats diagnostic command. Diagnostic commands

Re: RFR : JDK-8151099 : java.lang.management.ManagementFactory.getPlatformMXBeans() should work even if jdk.management is not present.

2016-10-27 Thread Daniel Fuchs
On 25/10/16 10:45, Amit Sapre wrote: Thanks Mandy for the review. I incorporated your comments and updated changes are available in this webrev. http://cr.openjdk.java.net/~asapre/webrev/8151099/webrev.02/ PS: Also updated copyright year for all modified files. Looks good to me as well.

Re: RFR(S): 8168305 GC.class_stats should not require -XX:+UnlockDiagnosticVMOptions

2016-10-27 Thread Staffan Larsen
> On 27 Oct 2016, at 11:41, Marcus Larsson wrote: > > Hi Staffan, > > > On 2016-10-27 10:36, Staffan Larsen wrote: >> All, >> >> Please review this small patch to remove the requirement >> -XX:+UnlockDiagnosticVMOptions when running the GC.class_stats diagnostic

Re: RFR(S): 8168305 GC.class_stats should not require -XX:+UnlockDiagnosticVMOptions

2016-10-27 Thread Marcus Larsson
Hi Staffan, On 2016-10-27 10:36, Staffan Larsen wrote: All, Please review this small patch to remove the requirement -XX:+UnlockDiagnosticVMOptions when running the GC.class_stats diagnostic command. Diagnostic commands are used for diagnosing problems and should not require restarting the

Re: RFR(S): 8168305 GC.class_stats should not require -XX:+UnlockDiagnosticVMOptions

2016-10-27 Thread Robbin Ehn
Looks good! /Robbin On 10/27/2016 10:36 AM, Staffan Larsen wrote: All, Please review this small patch to remove the requirement -XX:+UnlockDiagnosticVMOptions when running the GC.class_stats diagnostic command. Diagnostic commands are used for diagnosing problems and should not require

Re: RFR: JDK-8168397 : sun/tools/jhsdb/HeapDumpTest.java timesout on MacOS X on non images build

2016-10-27 Thread Dmitry Samersoff
Looks good for me! On 2016-10-27 07:57, Sharath Ballal wrote: > Hello, > > After the fix for JDK-8160376 > - DebuggerException: > Can't attach symbolicator to the process, > > I have removed BasicLauncherTest.java & HeapDumpTest.java from >

RFR(S): 8168305 GC.class_stats should not require -XX:+UnlockDiagnosticVMOptions

2016-10-27 Thread Staffan Larsen
All, Please review this small patch to remove the requirement -XX:+UnlockDiagnosticVMOptions when running the GC.class_stats diagnostic command. Diagnostic commands are used for diagnosing problems and should not require restarting the JVM with a different command line flag if this can be

Re: RFR: JDK-8168397 : sun/tools/jhsdb/HeapDumpTest.java timesout on MacOS X on non images build

2016-10-27 Thread Staffan Larsen
Looks good! Thanks, /Staffan > On 27 Oct 2016, at 06:57, Sharath Ballal wrote: > > Hello, > After the fix for JDK-8160376 > - DebuggerException: Can't > attach symbolicator to the process, > I have removed