Hi David,
Thank you for looking at the test!
On 4/27/17 23:11, David Holmes wrote:
Hi Serguei,
On 28/04/2017 3:14 PM, serguei.spit...@oracle.com wrote:
Please, review the jdk 10 fix for the test enhancement:
https://bugs.openjdk.java.net/browse/JDK-8172970
Webrev:
http://cr.openjdk.java.
The updated webrev is:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2017/hotspot/8172970-start-phase.2/
I've re-arranged a little bit code in the ClassPrepare callback and the
function test_class_functions().
Thanks,
Serguei
On 4/28/17 00:47, serguei.spit...@oracle.com wrote:
Hi David,
Tha
On 4/28/17 00:47, serguei.spit...@oracle.com wrote:
Hi David,
Thank you for looking at the test!
On 4/27/17 23:11, David Holmes wrote:
Hi Serguei,
On 28/04/2017 3:14 PM, serguei.spit...@oracle.com wrote:
Please, review the jdk 10 fix for the test enhancement:
https://bugs.openjdk.java.net
Hi Serguei,
On 28/04/2017 6:07 PM, serguei.spit...@oracle.com wrote:
The updated webrev is:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2017/hotspot/8172970-start-phase.2/
Thanks for the updates (the issue with long is that on win64 it is only
32-bit while void* is 64-bit).
I prefer to see
Hi David,
On 4/28/17 04:42, David Holmes wrote:
Hi Serguei,
On 28/04/2017 6:07 PM, serguei.spit...@oracle.com wrote:
The updated webrev is:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2017/hotspot/8172970-start-phase.2/
Thanks for the updates (the issue with long is that on win64 it is
Hi,
Could you please take a quick look on a source code change to remove demo/jvmti
tests:
http://cr.openjdk.java.net/~shurailine/8179457/webrev.00/
The tests seem to only be testing the jvmti demos and not providing any useful
test coverage beyond that. The demos are now removed as part of JEP
Hi Shura,
the fix looks good to me, thank you for taking care of it.
-- Igor
> On Apr 28, 2017, at 2:41 PM, Alexandre (Shura) Iline
> wrote:
>
> Hi,
>
> Could you please take a quick look on a source code change to remove
> demo/jvmti tests:
> http://cr.openjdk.java.net/~shurailine/8179457/w
I have attached a patch that allows jcmd to work against a java process running
inside a Docker container. Apologies if this is not in the correct format. It
was
built against jdk8u. I couldn’t seem to find an existing JIRA for it.
Diagnostic commands (i.e. jcmd, jstack, etc) fail to attach to a
Please review the following simple changes to update use of {@docRoot}
in doc comments now that we have a single docs bundle.
Most instances in this review can be replaced with direct references
using @see or {@link}. One use of {@docRoot} remains, but modified, to
refer to an explicit anchor
> On Apr 28, 2017, at 3:29 PM, Jonathan Gibbons
> wrote:
>
> Please review the following simple changes to update use of {@docRoot} in doc
> comments now that we have a single docs bundle.
>
> Most instances in this review can be replaced with direct references using
> @see or {@link}. One u
Hi TJ,
Thanks for the patch (I haven't looked at it yet). FYI at the moment,
unless this is considered a high priority bug for JDK 9 it has to be
targeted to JDK 10, and then possibly backported to 9 and 8u.
Cheers,
David
On 29/04/2017 8:23 AM, TJ Fontaine wrote:
I have attached a patch tha
I had no doubt we’d end up on the conversation of 10 -> 9 -> 8u, I started with
8u merely because it was representative of today’s customer pain. I’ll be sure
to work on retargeting it as well.
Thanks!
TJ
On 4/28/17, 3:42 PM, "David Holmes" wrote:
Hi TJ,
Thanks for the patch (I
Hello,
Please review changes for java.management and java.management.rmi to
be HTML5 ready, there are outliers like cellpadding, cellspacing that needs
to be done separately, note this was *not* done mechanically by a script.
http://cr.openjdk.java.net/~ksrini/8179415/
https://bugs.openjdk.java.
> On Apr 28, 2017, at 4:16 PM, Kumar Srinivasan
> wrote:
>
> Hello,
>
> Please review changes for java.management and java.management.rmi to
> be HTML5 ready, there are outliers like cellpadding, cellspacing that needs
> to be done separately, note this was *not* done mechanically by a script.
Hi David,
On 4/28/17 10:34, serguei.spit...@oracle.com wrote:
Hi David,
On 4/28/17 04:42, David Holmes wrote:
Hi Serguei,
On 28/04/2017 6:07 PM, serguei.spit...@oracle.com wrote:
The updated webrev is:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2017/hotspot/8172970-start-phase.2/
Tha
Hi Shura,
The tests removal looks good to me.
Thanks,
Serguei
On 4/28/17 14:41, Alexandre (Shura) Iline wrote:
Hi,
Could you please take a quick look on a source code change to remove demo/jvmti
tests:
http://cr.openjdk.java.net/~shurailine/8179457/webrev.00/
The tests seem to only be tes
That looks fine to me Serguei!
Thanks,
David
On 29/04/2017 10:13 AM, serguei.spit...@oracle.com wrote:
Hi David,
On 4/28/17 10:34, serguei.spit...@oracle.com wrote:
Hi David,
On 4/28/17 04:42, David Holmes wrote:
Hi Serguei,
On 28/04/2017 6:07 PM, serguei.spit...@oracle.com wrote:
The u
Thanks, David!
Serguei
On 4/28/17 18:08, David Holmes wrote:
That looks fine to me Serguei!
Thanks,
David
On 29/04/2017 10:13 AM, serguei.spit...@oracle.com wrote:
Hi David,
On 4/28/17 10:34, serguei.spit...@oracle.com wrote:
Hi David,
On 4/28/17 04:42, David Holmes wrote:
Hi Serguei,
18 matches
Mail list logo
