Re: RFR(S): 8198655: test/lib/jdk/test/lib/apps/LingeredApp shouldn't inherit cout/cerr

2018-03-16 Thread Chris Plummer
On 3/16/18 1:25 PM, serguei.spit...@oracle.com wrote: Hi Chris, Thank you for taking care about this issue! On 3/16/18 11:20, Chris Plummer wrote: Hi, I've resolved the issues I had before with not seeing all the stderr output when I tried to capture it. What I'd like to do now is have us d

Re: RFR(S): 8198655: test/lib/jdk/test/lib/apps/LingeredApp shouldn't inherit cout/cerr

2018-03-16 Thread serguei.spit...@oracle.com
Hi Chris, Thank you for taking care about this issue! On 3/16/18 11:20, Chris Plummer wrote: Hi, I've resolved the issues I had before with not seeing all the stderr output when I tried to capture it. What I'd like to do now is have us decide how the output should be handled from the perspec

Re: RFR(S): 8198655: test/lib/jdk/test/lib/apps/LingeredApp shouldn't inherit cout/cerr

2018-03-16 Thread Chris Plummer
Hi, I've resolved the issues I had before with not seeing all the stderr output when I tried to capture it. What I'd like to do now is have us decide how the output should be handled from the perspective a LingeredApp user (driver app). Currently all LingeredApp stdout is captured and gets be

Re: RFR: JDK-8199682 Clean up building the saproc library

2018-03-16 Thread Magnus Ihse Bursie
Hi Sundar, I almost missed your mail, since you removed both me and build-dev from the cc list... > 16 mars 2018 kl. 06:14 skrev Sundararajan Athijegannathan > : > > Renaming sawindbg as saproc sounds odd. For Linux, Solaris/Unix, we either > use /proc & libproc, so calling saproc for those m

Re: RFR: JDK-8199682 Clean up building the saproc library

2018-03-16 Thread David Holmes
On 16/03/2018 9:49 PM, Magnus Ihse Bursie wrote: On 2018-03-16 04:13, David Holmes wrote: Hi Magnus, Overall this seems okay. Thanks! On 16/03/2018 4:22 AM, Magnus Ihse Bursie wrote: The saproc library has historically been built in quite odd ways on almost all platforms. When the old buil

Re: RFR: JDK-8199682 Clean up building the saproc library

2018-03-16 Thread Magnus Ihse Bursie
On 2018-03-16 04:13, David Holmes wrote: Hi Magnus, Overall this seems okay. Thanks! On 16/03/2018 4:22 AM, Magnus Ihse Bursie wrote: The saproc library has historically been built in quite odd ways on almost all platforms. When the old build system was converted, this was not changed. H

Re: RFR of JDK-8199215: Re-examine getFreePort method in test infrastructure library

2018-03-16 Thread Alan Bateman
On 16/03/2018 09:00, Hamlin Li wrote: : Just to confirm, have you run the serviceability and http client tests to make sure that they compile with this change? Yes, I ran tier1,tier2,tier3 tests(I think it includes httpclient tests), and also specific tests using Utils.getFreePort in svc ar

Re: RFR of JDK-8199215: Re-examine getFreePort method in test infrastructure library

2018-03-16 Thread Hamlin Li
On 16/03/2018 4:05 PM, Alan Bateman wrote: On 16/03/2018 01:54, Hamlin Li wrote: : Hi Alan, Thank you for detailed reviewing. I have updated the webrev in place. (http://cr.openjdk.java.net/~mli/8199215/webrev.00/) Looks good, just a minor typo "is better choice" -> "is a better choice". Hi

Re: RFR of JDK-8199215: Re-examine getFreePort method in test infrastructure library

2018-03-16 Thread Alan Bateman
On 16/03/2018 01:54, Hamlin Li wrote: : Hi Alan, Thank you for detailed reviewing. I have updated the webrev in place. (http://cr.openjdk.java.net/~mli/8199215/webrev.00/) Looks good, just a minor typo "is better choice" -> "is a better choice". Just to confirm, have you run the serviceabilit