INCLUDE_SA/serviceability agent - support on s390x

Hello, as far as I know the serviceability agent is not supported on linux s390x . However (unlike on aix where it is not supported as well) , INCLUDE_SA=falseis not set in the central configure m4 files . Should we set it ( suggested diff below) ? Best regards, Matthias hg

Re: Review Request JDK-8200559: Java agents doing instrumentation need a means to define auxiliary classes

On 15/04/2018 07:23, mandy chung wrote: This proposal would allow java agents to migrate from internal API and ClassDefiner to be enhanced in the future. Webrev: http://cr.openjdk.java.net/~mchung/jdk11/webrevs/8200559/webrev.00/ I went through the proposed spec/API addition and it looks goo

Re: INCLUDE_SA/serviceability agent - support on s390x

Makes sense to me. Looks good. /Erik On 2018-04-23 05:01, Baesken, Matthias wrote: Hello,   as far as I know  the serviceability agent   is not  supported on  linux s390x . However  (unlike  on aix where it is not supported as well) ,   INCLUDE_SA=false is not set  in the central configur

Re: RFR: 8196325: GarbageCollectionNotificationInfo has same information for before and after

Hi all, Can I have a second reviewer please? Thanks, Sangheon On 04/18/2018 04:57 PM, mandy chung wrote: On 4/19/18 4:52 AM, sangheon.kim wrote: Webrev: http://cr.openjdk.java.net/~sangheki/8196325/webrev.1 (full) http://cr.openjdk.java.net/~sangheki/8196325/webrev.1_to_0/ (inc) Looks

RFR(XS): JDK-8202155: quarantine test com/sun/jdi/JdbExprTest.sh on all platforms

Hello, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8202155 -- diff --git a/test/jdk/ProblemList.txt b/test/jdk/ProblemList.txt --- a/test/jdk/ProblemList.txt +++ b/test/jdk/ProblemList.txt @@ -738,6 +738,8 @@  com/sun/jdi/Redefi

Re: RFR(XS): JDK-8202155: quarantine test com/sun/jdi/JdbExprTest.sh on all platforms

Looks good. Thanks, David On 24/04/2018 6:25 AM, Chris Plummer wrote: Hello, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8202155 -- diff --git a/test/jdk/ProblemList.txt b/test/jdk/ProblemList.txt --- a/test/jdk/ProblemList.tx

Re: RFR(XS): JDK-8202155: quarantine test com/sun/jdi/JdbExprTest.sh on all platforms

Thanks! On 4/23/18 3:01 PM, David Holmes wrote: Looks good. Thanks, David On 24/04/2018 6:25 AM, Chris Plummer wrote: Hello, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8202155 -- diff --git a/test/jdk/ProblemList.txt b/test

Re: RFR(XS): JDK-8202155: quarantine test com/sun/jdi/JdbExprTest.sh on all platforms

+1 Thanks, Serguei On 4/23/18 15:01, David Holmes wrote: Looks good. Thanks, David On 24/04/2018 6:25 AM, Chris Plummer wrote: Hello, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8202155 -- diff --git a/test/jdk/ProblemList

Re: RFR: 8201409: JDWP debugger initialization hangs intermittently

Hi Andrew, There is a regression with this fix. The following test is failed with timeout on all platforms except Windows. I'll try to get more details about this timeout. Thanks, Serguei On 4/18/18 09:49, serguei.spit

Re: RFR: 8201409: JDWP debugger initialization hangs intermittently

On 4/23/18 16:08, serguei.spit...@oracle.com wrote: Hi Andrew, There is a regression with this fix. The following test is failed with timeout on all platforms except Windows: Sorry, forgot to copy the test

Re: RFR: 8201409: JDWP debugger initialization hangs intermittently

The most relevant stack traces from Solaris pstack dump are:   12 -  lwp# 2 / thread# 2    13  7eae9b3c lwp_cond_wait (100123448, 100123430, 0, 0)   14  fffd12331a94 void os::PlatformEvent::park() (100123400,

Re: INCLUDE_SA/serviceability agent - support on s390x

Hi Matthias, Your change looks good to me. It might make sense to also remove the following lines from: src/jdk.hotspot.agent/linux/native/libsaproc/libproc.h 78 #if defined(s390x) 79 #include 80 #endif I am not sure if the following files are required either: src/hotspot/cpu/s390/vmStru