Hi Gary,
On 26/06/2018 4:27 AM, Gary Adams wrote:
The first time I looked into problems with exclude001 test,
we discovered a large number of new packages in the jdk.internal
classes that were introduced in jdk9. The test needed to add excludes for
any of the jdk.* methods or it could not finish
On 26/06/2018 11:32 AM, Daniel D. Daugherty wrote:
David,
Thanks for your eagle eyes! More below...
On 6/25/18 9:27 AM, Daniel D. Daugherty wrote:
On 6/25/18 1:57 AM, David Holmes wrote:
Hi Dan,
On 21/06/2018 10:18 AM, Daniel D. Daugherty wrote:
Greetings,
I have a fix for a recent (very
David,
Thanks for your eagle eyes! More below...
On 6/25/18 9:27 AM, Daniel D. Daugherty wrote:
On 6/25/18 1:57 AM, David Holmes wrote:
Hi Dan,
On 21/06/2018 10:18 AM, Daniel D. Daugherty wrote:
Greetings,
I have a fix for a recent (very rare) Thread-SMR related test failure.
Since the fi
Hi,
Thanks for reviewing!
Yes, what Jini is saying is also what I found in the comments.
Best regards,
Goetz.
> -Original Message-
> From: Chris Plummer
> Sent: Monday, June 25, 2018 7:02 PM
> To: Lindenmaier, Goetz ; 'Jini George'
> ; serviceability-dev (serviceability-
> d...@openj
Hi Jini
Thanks for reviewing again, I fixed the typo's!
Best regards,
Goetz.
> -Original Message-
> From: Jini George
> Sent: Monday, June 25, 2018 6:20 PM
> To: Lindenmaier, Goetz ; 'Chris Plummer'
> ; serviceability-dev (serviceability-
> d...@openjdk.java.net)
> Subject: Re: RFR(S
The first time I looked into problems with exclude001 test,
we discovered a large number of new packages in the jdk.internal
classes that were introduced in jdk9. The test needed to add excludes for
any of the jdk.* methods or it could not finish in time.
As a follow up I'll try a test run with u
Hi Daniil,
Couple minor notes:
- Debugee.DEFAULT_MAIN_THREAD_NAME makes sense only for
HeapwalkingDebuggee-inherited tests, so it would be better to move the
constant to the class (and make it protected);
- HeapwalkingDebuggee.useStrictCheck can be simplified to something like
switch
I'm also wondering how fast this test
runs on other platforms and when passing on solaris-sparc. 5
minutes already seems like a long time for this test. There could
be an underlying issue that needs to be addressed.
Chris
On 6/25/18 11:00 AM, s
Hi Gary,
It looks Okay.
But I'm curious when this started failing and what triggered it to
fail?
Thanks,
Serguei
On 6/25/18 10:20, Gary Adams wrote:
The exclude001 test times out on solaris sparc debug
Hi Gunter,
The fix looks good.
Thanks,
Serguei
On 6/25/18 07:22, Haug, Gunter wrote:
Hi all,
Thank you, David for taking the time to do the review. Here is hopefully the
last version of the change:
http://cr.openjdk.java.net/~ghaug/webrevs/8200720.v5/
Following David's suggestion, _start_
Some of the tests were skipped on OSX due to stackwalking issues on OSX.
(Some were pstack related, and some for jstack on corefiles).
Thanks,
Jini.
On 6/25/2018 10:31 PM, Chris Plummer wrote:
Hi Goetz,
The changes look good. Just one question though. In places where you have:
42 * @requ
The exclude001 test times out on solaris sparc debug builds.
Basically, this test is all about tracing method calls and introduces
exclude filters to reduce the callbacks to a select set of packages.
The time spent tracing/filtering method callbacks is purely a function
of the number of methods t
Hi Gunter,
Changes look good to me.
thanks,
Chris
On 6/25/18 7:22 AM, Haug, Gunter wrote:
Hi all,
Thank you, David for taking the time to do the review. Here is hopefully the
last version of the change:
http://cr.openjdk.java.net/~ghaug/webrevs/8200720.v5/
Following David's suggestion, _s
Hi Goetz,
The changes look good. Just one question though. In places where you have:
42 * @requires vm.hasSAandCanAttach & os.family != "mac"
Do you know why these tests don't run on osx? I just wonder if it
related to attach not working unless root, and that is now covered by
hasSAandCanA
Thank you, Erik !
- Jini.
On 6/25/2018 9:23 PM, Erik Joelsson wrote:
Build changes look good.
/Erik
On 2018-06-24 10:37, Jini George wrote:
Hi Erik,
Thank you very much for looking into this. I have addressed your
comments. The latest webrev is at:
http://cr.openjdk.java.net/~jgeorge/81
Hi Goetz,
Your changes look good, though I feel that even for the tests that use
ClhsdbLauncher and which need an attach, an "@requires
vm.hasSAandCanAttach" could be used, and the Platform.shouldSAAttach()
calls can be removed from ClhsdbLauncher.
Some nits:
1. In VMProps.java,
servicabil
Build changes look good.
/Erik
On 2018-06-24 10:37, Jini George wrote:
Hi Erik,
Thank you very much for looking into this. I have addressed your
comments. The latest webrev is at:
http://cr.openjdk.java.net/~jgeorge/8189429/webrev.06/
Thank you,
Jini.
On 6/23/2018 3:31 AM, Erik Joelsson
Hi all,
Thank you, David for taking the time to do the review. Here is hopefully the
last version of the change:
http://cr.openjdk.java.net/~ghaug/webrevs/8200720.v5/
Following David's suggestion, _start_time_stamp is now constant and set by the
constructor and the setter has been removed. Thi
On 6/25/18 1:57 AM, David Holmes wrote:
Hi Dan,
On 21/06/2018 10:18 AM, Daniel D. Daugherty wrote:
Greetings,
I have a fix for a recent (very rare) Thread-SMR related test failure.
Since the fix is related to the ErrorHandling tests and affects
hs_err_pid
file generation, this code review i
On 25/06/2018 8:04 PM, Haug, Gunter wrote:
Hi David,
Thank you. You're right, the setter is not required, I'll remove it.
I've filed a CSR request: https://bugs.openjdk.java.net/browse/JDK-8205604
Is this what is expected? It's my first one.
Yes that's pretty much it. I added myself as a Revi
Thank you, Sharath. May I have a Reviewer to take a look at the
MacosxDebuggerLocal code?
Thanks,
Jini.
On 6/25/2018 1:52 PM, Sharath Ballal wrote:
Hi Jini,
Changes in MacosxDebuggerLocal.m looks good.
Thanks,
Sharath
-Original Message-
From: Jini George
Sent: Sunday, June 24, 2018
Hi David,
Thank you. You're right, the setter is not required, I'll remove it.
I've filed a CSR request: https://bugs.openjdk.java.net/browse/JDK-8205604
Is this what is expected? It's my first one.
Thank you,
Gunter
On 25.06.18, 10:38, "David Holmes" wrote:
Hi Gunter,
On 25/06/
Hi Gunter,
On 25/06/2018 6:26 PM, Haug, Gunter wrote:
Hi David,
Here is the updated webrev. I've included all the changes you suggested, except
for default parameter (see original mail).
http://cr.openjdk.java.net/~ghaug/webrevs/8200720.v4/
Are you OK with it now?
You don't need the setSta
Hi David,
Here is the updated webrev. I've included all the changes you suggested, except
for default parameter (see original mail).
http://cr.openjdk.java.net/~ghaug/webrevs/8200720.v4/
Are you OK with it now?
Thanks again,
Gunter
On 20.06.18, 17:40, "serviceability-dev on behalf of Haug, G
Hi Jini,
Changes in MacosxDebuggerLocal.m looks good.
Thanks,
Sharath
-Original Message-
From: Jini George
Sent: Sunday, June 24, 2018 11:07 PM
To: Erik Joelsson; serviceability-dev@openjdk.java.net;
build-...@openjdk.java.net; hotspot-runtime-...@openjdk.java.net
Subject: Re: RFR: JD
After internal discussions, we have decided to proceed with the current fix.
Thank you Mandy, Daniel, Dan and David for the review.
Harsha
On Friday 22 June 2018 10:07 AM, Harsha Wardhana B wrote:
Hi Dan,
The utility function Utils.getFreePort gets free port by creating
server socket with po
26 matches
Mail list logo
