Hi Jini,
There are quite a few changes to digest in this - it may have been
better to break them up individually:
- sudo use
- refactor to use ClshdbLauncher
- changes to use regex matching
Focusing on the main sudo change the assumption is that on OSX you can
run sudo without needing to prov
Thank you, David. My answers inline:
On 7/11/2018 1:54 PM, David Holmes wrote:
Hi Jini,
There are quite a few changes to digest in this - it may have been
better to break them up individually:
- sudo use
- refactor to use ClshdbLauncher
- changes to use regex matching
Focusing on the main su
Hi all,
I filed bugzilla for small fix to improvement of `jhsdb debugd` to set
a port of UnicastRemoteObject aka
sun.jvm.hotspot.debugger.remote.RemoteDebuggerServer by
`sun.jvm.hotspot.rmi.debugger.port`.
Issue: https://bugs.openjdk.java.net/browse/JDK-8207048
Webrev: http://cr.openjdk.java.net/
Hi Yasumasa,
This looks good to me except for one nit. And some more comments would
help. For e.g., it would help to say that NSPidMap is to map the host to
container lwpids.
The nit:
*
http://cr.openjdk.java.net/~ysuenaga/JDK-8205992/webrev.00/src/jdk.hotspot.agent/linux/native/libsaproc/L
Hi all,
please review a fix for
https://bugs.openjdk.java.net/browse/JDK-8201513
webrev:
http://cr.openjdk.java.net/~amenkov/IterateThroughHeap/webrev/
summary:
The tests had a error which was fixed during open-sourcing.
After that the tests started to fail. Root cause of the failures is
wrong
Hi Alex,
The fix looks good.
Thank you for fixing the typos!
Thanks,
Serguei
On 7/11/18 11:39, Alex Menkov wrote:
Hi all,
please review a fix for
https://bugs.openjdk.java.net/browse/JDK-8201513
webrev:
http://cr.openjdk.java.net/~amenkov/IterateThroughHeap/webrev/
summary:
The tests had a
Hi Jc,
The fix looks good.
I'll sponsor a push once it has been reviewed.
Thanks,
Serguei
On 7/11/18 10:04, JC Beyler wrote:
Hi all,
Could someone review the small-ish webrev for the bug:
On 11/07/2018 8:00 PM, Jini George wrote:
Thank you, David. My answers inline:
On 7/11/2018 1:54 PM, David Holmes wrote:
Hi Jini,
There are quite a few changes to digest in this - it may have been
better to break them up individually:
- sudo use
- refactor to use ClshdbLauncher
- changes to
Hi Yuji,
I can't comment on the actual change proposed in this enhancement
request, but it will need to have a CSR request created and approved due
to the use of a new system property.
Thanks,
David
On 11/07/2018 11:55 PM, KUBOTA Yuji wrote:
Hi all,
I filed bugzilla for small fix to impr
Hi David,
Thank you for comment and updating JBS. I'll create a CSR request
after getting comments whether this change is welcomed by community.
Thanks,
Yuji
2018-07-12 10:21 GMT+09:00 David Holmes :
> Hi Yuji,
>
> I can't comment on the actual change proposed in this enhancement request,
> but
Thanks Jini,
I uploaded new webrev. It contains some comments and removing extra space.
http://cr.openjdk.java.net/~ysuenaga/JDK-8205992/webrev.01/
Yasumasa
2018-07-12 2:32 GMT+09:00 Jini George :
> Hi Yasumasa,
>
> This looks good to me except for one nit. And some more comments would help.
Looks good to me.
Thanks!
Jini (Not a Reviewer).
On 7/12/2018 10:12 AM, Yasumasa Suenaga wrote:
Thanks Jini,
I uploaded new webrev. It contains some comments and removing extra space.
http://cr.openjdk.java.net/~ysuenaga/JDK-8205992/webrev.01/
Yasumasa
2018-07-12 2:32 GMT+09:00 Jini Geor
Please review the changes that fix jdb issue with evaluation of
multidimensional arrays of primitives.
The problem here is that for N-dimensional arrays of the primitives with N
greater then 2, JDI fails to find its component type (which is an array of
dimension N-1) assuming that it is a boot
Hi Daniil,
It looks good.
Thanks,
Serguei
On 7/11/18 22:23, Daniil Titov wrote:
Please review the changes that fix jdb issue with evaluation of
multidimensional arrays of primitives.
The problem here is that for N-dimensional arrays of the primitives with N
greater then 2, JDI fails to fin
Thanks Jini!
I'm waiting for Reviewer.
Yasumasa
2018-07-12 14:09 GMT+09:00 Jini George :
> Looks good to me.
>
> Thanks!
> Jini (Not a Reviewer).
>
>
> On 7/12/2018 10:12 AM, Yasumasa Suenaga wrote:
>>
>> Thanks Jini,
>>
>> I uploaded new webrev. It contains some comments and removing extra s
15 matches
Mail list logo