Hi Alex,
On 22/08/2018 5:36 AM, Alex Menkov wrote:
Hi David,
Updated fix:
http://cr.openjdk.java.net/~amenkov/sh2java/step1_zgc/webrev.01
I used "catch (Throwable)" instead suggested "catch (Error |
RuntimeException ex)" (we want to catch anything can be thrown)
Interesting that it worked.
Hi guys,
Updated webrev:
http://cr.openjdk.java.net/~amenkov/sh2java/step2/webrev.01/
changes (vs initial fix):
- Eval*.java tests are updated, common methods are moved into JdbTest;
- $classname substitution is dropped in EvalArgs.java;
- comment are reintroduced;
- line separator logic was dro
Hi Calvin,
Thanks for the review.
I found that hotspot/share/include is already specified in the include
path for libsaproc.so, so I changed all the 3 includes to
include "cds.h"
I am running mach5 tier1 again to make sure it builds for all supported
platforms.
Thanks
- Ioi
On
On 8/21/18 1:21 PM, serguei.spit...@oracle.com wrote:
Hi Ioi,
Thank you for the update!
It looks good to me.
The following declarations can be aligned (no need in new webrev):
169 bool _file_open;
170 int _fd;
171 size_t _file_offset;
Hi Serguei,
Thanks for the review. I've fixed the inden
Thank you, Serguei and Alex, for reviewing this change.
Best regards,
Daniil
On 8/21/18, 2:18 PM, "Alex Menkov" wrote:
+1
--alex
On 08/20/2018 20:06, serguei.spit...@oracle.com wrote:
> Hi Daniil,
>
> Looks good.
>
> Thanks,
> Serguei
>
+1
--alex
On 08/20/2018 20:06, serguei.spit...@oracle.com wrote:
Hi Daniil,
Looks good.
Thanks,
Serguei
On 8/16/18 19:04, Daniil Titov wrote:
Please review the change that fix the test failure when running with
Graal.
There are 2 problems here. The first one is that when running with
G
Hi Jc,
It looks pretty good to me.
One minor comment:
http://cr.openjdk.java.net/%7Ejcbeyler/8201224/webrev.03/test/hotspot/jtreg/vmTestbase/vm/mlvm/indy/func/jvmti/share/IndyRedefineClass.c.udiff.html
locStr = locationToString(jvmti_env, metho
Hi Ioi,
Thank you for the update!
It looks good to me.
The following declarations can be aligned (no need in new webrev):
169 bool _file_open;
170 int _fd;
171 size_t _file_offset;
Thank you for the explanation on the typedef FileM
Hi Alex,
Thank you for the update!
It looks good to me.
Thanks,
Serguei
On 8/21/18 12:36, Alex Menkov wrote:
Hi David,
Updated fix:
http://cr.openjdk.java.net/~amenkov/sh2java/step1_zgc/webrev.01
I used "catch (Throwable)" instead suggested "catch (Error |
RuntimeException ex)" (we want to
Hi David,
Updated fix:
http://cr.openjdk.java.net/~amenkov/sh2java/step1_zgc/webrev.01
I used "catch (Throwable)" instead suggested "catch (Error |
RuntimeException ex)" (we want to catch anything can be thrown)
Also I updated String.split to use \\R for the line-separators as you
suggested
Hi Ioi,
This is a very nice cleanup and looks good.
In the SA native code, I'm wondering instead of:
#include "../../../../hotspot/share/include/cds.h"
is it possible to omit the relative path and just have the following?
#include "cds.h"
I think it probably involves some makefile changes.
I
Hi Serguei,
Thanks for the review. Updated webrev at
http://cr.openjdk.java.net/~iklam/jdk12/8209657-shared-FileMapHeader-decl.v03/
On 8/21/18 1:28 AM, serguei.spit...@oracle.com wrote:
Hi Ioi,
A couple of quick minor comments...
http://cr.openjdk.java.net/~iklam/jdk12/8209657-shared-FileM
Thanks, Sharath!
On 21-Aug-18 14:46, Sharath Ballal wrote:
Hi Egor,
For JDK 9 and above try this.
1. Run the debuggee and get the
2. \bin\jhsdb debugd (you may need sudo on some platforms)
3. \bin\java -Dsun.jvm.hotspot.runtime.VM.disableVersionCheck -m
jdk.hotspot.agent/sun.jvm.hotspo
Hi Egor,
For JDK 9 and above try this.
1. Run the debuggee and get the
2. \bin\jhsdb debugd (you may need sudo on some platforms)
3. \bin\java -Dsun.jvm.hotspot.runtime.VM.disableVersionCheck -m
jdk.hotspot.agent/sun.jvm.hotspot.tools.HeapDumper localhost (sudo may be
needed on some
Yes that’s needs a separate bug. I will open one for it.
Thanks,
Sharath
-Original Message-
From: Egor Ushakov [mailto:egor.usha...@jetbrains.com]
Sent: Tuesday, August 21, 2018 3:49 PM
To: Sharath Ballal; David Holmes; serviceability-dev@openjdk.java.net
serviceability-dev@openjdk.j
You're probably looking for /jdk.hotspot.agent.jmod ?
- Kris
On Tue, Aug 21, 2018 at 3:18 AM, Egor Ushakov
wrote:
> Thank you all! It is much better now.
>
> Related question: documentation for java 10 https://docs.oracle.com/javase
> /10/docs/specs/jpda/conninv.html#sa-pid-attaching-connector
Thank you all! It is much better now.
Related question: documentation for java 10
https://docs.oracle.com/javase/10/docs/specs/jpda/conninv.html#sa-pid-attaching-connector
still states that the debug server should be launched with sa-jdi.jar in
classpath, though there's no such jar in the jdk a
Hi David,
I opened https://bugs.openjdk.java.net/browse/JDK-8209781 for it.
Thanks,
Sharath
-Original Message-
From: David Holmes
Sent: Tuesday, August 21, 2018 7:47 AM
To: Sharath Ballal; Egor Ushakov; serviceability-dev@openjdk.java.net
serviceability-dev@openjdk.java.net
Subject: R
Hi Ioi,
A couple of quick minor comments...
http://cr.openjdk.java.net/~iklam/jdk12/8209657-shared-FileMapHeader-decl.v02/src/hotspot/share/include/cds.h.html
31 // We should use only standard C types. Do bot use custom types such as bool, intx,
19 matches
Mail list logo
