Thank you very much, Leonid.
- Jini.
On 1/4/2019 12:18 PM, Leonid Mesnik wrote:
Looks good.
Leonid
On Jan 3, 2019, at 5:51 PM, Jini George wrote:
The modified webrev is at:
http://cr.openjdk.java.net/~jgeorge/8213457/webrev.01/
I will address the moving the test out of tier1 as a separat
Looks good.
Leonid
> On Jan 3, 2019, at 5:51 PM, Jini George wrote:
>
> The modified webrev is at:
>
> http://cr.openjdk.java.net/~jgeorge/8213457/webrev.01/
>
> I will address the moving the test out of tier1 as a separate defect.
>
> Thank you,
> Jini.
>
> On 1/4/2019 2:38 AM, Chris Plumm
The modified webrev is at:
http://cr.openjdk.java.net/~jgeorge/8213457/webrev.01/
I will address the moving the test out of tier1 as a separate defect.
Thank you,
Jini.
On 1/4/2019 2:38 AM, Chris Plummer wrote:
On 1/3/19 11:37 AM, Leonid Mesnik wrote:
On Jan 3, 2019, at 10:26 AM, Jini Geor
On 1/3/19 11:37 AM, Leonid Mesnik wrote:
On Jan 3, 2019, at 10:26 AM, Jini George wrote:
Thank you very much, Chris, for taking a look. I will modify the timeout value to be
480 ==> 8 minutes ==> 32 minutes for tier1. Sounds good ?
I think it makes a sense to move this test out of tier1. I
> On Jan 3, 2019, at 10:26 AM, Jini George wrote:
>
> Thank you very much, Chris, for taking a look. I will modify the timeout
> value to be 480 ==> 8 minutes ==> 32 minutes for tier1. Sounds good ?
>
I think it makes a sense to move this test out of tier1. It takes too long time
for tier1.
+1
Thanks,
Serguei
On 1/3/19 02:06, Volker Simonis wrote:
OK, still looks good!
Thanks,
Volker
On Thu, Jan 3, 2019 at 10:16 AM Lindenmaier,
+1
Thanks,
Serguei
On 1/3/19 07:31, Chris Plummer wrote:
Looks good.
Chris
On 1/3/19 4:58 AM, Gary Adams wrote:
The test/hotspot/jtreg/vmTestbase/vm/mlvm tests were missed when the
parser was updated for
JDK-8211343. Those tests use tilde (~) as an option separator.
Here's a quick fix to
Missed mentioning that I think this should be a good number considering
that the max I have seen for this test is about 12 minutes and there is
a safe buffer of about 20 more minutes.
Thanks!
Jini.
On 1/3/2019 11:56 PM, Jini George wrote:
Thank you very much, Chris, for taking a look. I will m
Thank you very much, Chris, for taking a look. I will modify the timeout
value to be 480 ==> 8 minutes ==> 32 minutes for tier1. Sounds good ?
Thanks!
Jini.
On 1/3/2019 9:54 PM, Chris Plummer wrote:
Hi Jini,
2400 seems excessive. That's 40 minutes, which translates to 160 minutes
for our tes
Hello!
Requesting reviews for:
https://bugs.openjdk.java.net/browse/JDK-8215544
Webrev: http://cr.openjdk.java.net/~jgeorge/8215544/webrev.03/index.html
The changes here are primarily for modifying the ClhsdbLauncher used for
SA tests to check if 'sudo' privileges can be added for executing Ma
On Thu, 3 Jan 2019 at 12:01, Andrew Haley wrote:
>
> On 1/3/19 11:24 AM, Severin Gehwolf wrote:
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8216058
> > webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8216058/webrev.01/
> >
> > Testing: Failing VersionCheck.java prior the patch, pass
Hi Jini,
2400 seems excessive. That's 40 minutes, which translates to 160 minutes
for our test runs. Did you mean timeout=240? It looks like a few of the
Clhsdb tests were given large timeouts that are probably much more than
is needed.
thanks,
Chris
On 1/2/19 6:51 PM, Jini George wrote:
Looks good.
Chris
On 1/3/19 4:58 AM, Gary Adams wrote:
The test/hotspot/jtreg/vmTestbase/vm/mlvm tests were missed when the
parser was updated for
JDK-8211343. Those tests use tilde (~) as an option separator.
Here's a quick fix to add tilde back as an option separator. Testing
is in progres
The test/hotspot/jtreg/vmTestbase/vm/mlvm tests were missed when the
parser was updated for
JDK-8211343. Those tests use tilde (~) as an option separator.
Here's a quick fix to add tilde back as an option separator. Testing is
in progress.
diff --git
a/test/hotspot/jtreg/vmTestbase/nsk/share
Thank you very much for the review, Serguei. Yes, I noticed it failing
intermittently without the fix -- once it took 9m 13s to execute and
failed, and in one of my post fix test executions, I had noticed it
taking about 11+ min (which would have caused a failure without the fix).
Thanks,
Jini
On 1/3/19 11:24 AM, Severin Gehwolf wrote:
> Bug: https://bugs.openjdk.java.net/browse/JDK-8216058
> webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8216058/webrev.01/
>
> Testing: Failing VersionCheck.java prior the patch, passing after.
>
> Thoughts?
Yes, that looks like the obvious f
Hi,
Could I please get a review for this 8u-only fix? Latest jdk8u-dev
forest contains new launchers for SA tools, clhsdb and hsdb. The latter
is a GUI app and when launched will block until the user closes the
GUI. This results in a timout in tools/launcher/VersionCheck.java which
launches all to
Thanks Serguei!
Best regards,
Goetz.
> -Original Message-
> From: serguei.spit...@oracle.com
> Sent: Donnerstag, 3. Januar 2019 10:13
> To: Volker Simonis ; Lindenmaier, Goetz
>
> Cc: serviceability-dev (serviceability-dev@openjdk.java.net) d...@openjdk.java.net>
> Subject: Re: RFR(S
OK, still looks good!
Thanks,
Volker
On Thu, Jan 3, 2019 at 10:16 AM Lindenmaier, Goetz <
goetz.lindenma...@sap.com> wrote:
> Hi Volker,
>
> thanks for looking at this.
>
> ... I just came up with another single line I'd like to add here:
>
> http://cr.openjdk.java.net/~goetz/wr18/8215975-nskTe
Hi Volker,
thanks for looking at this.
... I just came up with another single line I'd like to add here:
http://cr.openjdk.java.net/~goetz/wr18/8215975-nskTests/03/test/hotspot/jtreg/vmTestbase/nsk/jvmti/Allocate/alloc001/TestDescription.java.udiff.html
I'd like to exclude this test as Aix does
Hi Goetz,
++LGTM
Thanks,
Serguei
On 1/3/19 00:49, Volker Simonis wrote:
Looks good to me.
Thanks,
Volker
On Wed, Jan 2, 2019 at 4:
Looks good to me.
Thanks,
Volker
On Wed, Jan 2, 2019 at 4:48 PM Lindenmaier, Goetz
wrote:
> Hi Gary,
>
> as promised, I'll do a follow up fixing all these.
> But all the tests you mention are either not configured for aix (@requires
> linux etc)
> or are passing currently. So no need for acti
22 matches
Mail list logo