Hi Paul,
Thanks, fixed all of the above in my local branch :-),
Jc
On Fri, Jan 11, 2019 at 5:07 PM Hohensee, Paul wrote:
> Nits:
>
>
>
> memAllocator.cpp:
>
>
>
> Copyright line should read
>
>
>
> * Copyright (c) 2018, 2019, Oracle and/or its affiliates. All rights
> reserved.
>
>
>
> The comm
A more generic approach that doesn’t check for a specific platform in
ClhsdbLauncher.java would be nice, e.g., add a checkForPrivileges() method to
Platform, but if OSX is the only platform that needs the check, I'm ok with
this patch.
Thanks,
Paul
On 1/10/19, 8:16 PM, "serviceability-dev on
Hi Gary,
As I mentioned earlier there are two versions of InstallSDE.java in the
tests, so both should be updated.
Your strategy to avoid the windows delete issue seems reasonable.
David
On 12/01/2019 4:53 am, Gary Adams wrote:
Here's a webrev for review purposes.
No failures after ~1000 te
Here's a webrev for review purposes.
No failures after ~1000 testruns.
Webrev: http://cr.openjdk.java.net/~gadams/8158066/webrev.00/
Issue: https://bugs.openjdk.java.net/browse/JDK-8158066
On 1/11/19, 11:01 AM, Gary Adams wrote:
I've been reading recently that Windows delete file operations
I've been reading recently that Windows delete file operations
can be delayed, if there are open handles against the file.
Others have reported virus checkers or other indexing
programs may hold a handle on a file preventing the
deletion being completed.
The basic logic in InstallSDE is
A + B
Hi Gary,
On 11/01/2019 9:22 pm, gary.ad...@oracle.com wrote:
After ~1000 testruns I hit a failure in MangleTest and a jtreg agent
communication issue with SourceDebugExtension.
https://java.se.oracle.com:10065/mdash/builds/2019-01-10-1159535.gary.adams.jdk-jdb/results?search=status%3Afailed%20
After ~1000 testruns I hit a failure in MangleTest and a jtreg agent
communication
issue with SourceDebugExtension.
https://java.se.oracle.com:10065/mdash/builds/2019-01-10-1159535.gary.adams.jdk-jdb/results?search=status%3Afailed%20AND%20-state%3Ainvalid
*java.io.IOException: tmpFile.renameTo
Hi Jc, Paul and All,
Here is webrev03 http://cr.openjdk.java.net/~xiaofeya/8215622/webrev.03/
would you like to help review?
Thanks,
Lin
From: 臧琳
Sent: Friday, January 11, 2019 10:25:27 AM
To: JC Beyler
Cc: Hohensee, Paul; serviceability-dev@openj
