Re: RFR(S): 8218941: jdb should support a dbgtrace command that acts the same as the dbgtrace command line option

Hi Chris, It looks good to me. Thanks, Serguei On 2/13/19 18:43, Chris Plummer wrote: Hi, Please review the following: http://cr.openjdk.java.net/~cjplummer/8218941/webrev https://bugs.openjdk.java.net/browse/JDK-8218941 Tested by running the following on all supported platforms: open/tes

Re: RFR(XS): 8218947: jdb threads command should print threadID in decimal, not hex

Hi David, I can update the man page. Can you point me to where it is in the source? I haven't been able to find it. It seems to be out of date in other ways also. This is what the output looks like (with my fix). main[1] threads Group system:   (java.lang.ref.Reference$ReferenceHandler)908 Re

Re: RFR(XS): 8218947: jdb threads command should print threadID in decimal, not hex

Ok. I'll fix. thanks, Chris On 2/13/19 8:36 PM, David Holmes wrote: PS.  return MessageOutput.format("object description and hex id", Need to change the message too! David On 14/02/2019 2:32 pm, David Holmes wrote: Hi Chris, On 14/02/2019 1:37 pm, Chris Plummer wrote: Hi, Please review

Re: RFR(XS): 8218947: jdb threads command should print threadID in decimal, not hex

On 2/13/19 8:32 PM, David Holmes wrote: Hi Chris, On 14/02/2019 1:37 pm, Chris Plummer wrote: Hi, Please review the following: http://cr.openjdk.java.net/~cjplummer/8218947/webrev https://bugs.openjdk.java.net/browse/JDK-8218947 Are there times you may want to correlate those thread ids wit

Re: RFR(S): 8218941: jdb should support a dbgtrace command that acts the same as the dbgtrace command line option

Hi Chris, It looks good to me. Thanks, Serguei On 2/13/19 18:43, Chris Plummer wrote: Hi, Please review the following: http://cr.openjdk.java.net/~cjplummer/8218941/webrev https://bugs.openjdk.java.net/browse/JDK-8218941 Tested by running the following on all supported platforms: open/tes

Re: RFR(XS): 8218947: jdb threads command should print threadID in decimal, not hex

On 14/02/2019 2:53 pm, David Holmes wrote: oops! Okay on-list then. No big deal :) David pps. You'll also need to update the man page as it has an example showing the hex: threads   List the threads that are currently running. For each thread, its name and current stat

Re: RFR(XS): 8218947: jdb threads command should print threadID in decimal, not hex

pps. You'll also need to update the man page as it has an example showing the hex: threads List the threads that are currently running. For each thread, its name and current status are printed and an index that can be used in other commands. In this example,

Re: RFR(XS): 8218947: jdb threads command should print threadID in decimal, not hex

PS. return MessageOutput.format("object description and hex id", Need to change the message too! David On 14/02/2019 2:32 pm, David Holmes wrote: Hi Chris, On 14/02/2019 1:37 pm, Chris Plummer wrote: Hi, Please review the following: http://cr.openjdk.java.net/~cjplummer/8218947/webrev ht

Re: RFR(XS): 8218947: jdb threads command should print threadID in decimal, not hex

Hi Chris, On 14/02/2019 1:37 pm, Chris Plummer wrote: Hi, Please review the following: http://cr.openjdk.java.net/~cjplummer/8218947/webrev https://bugs.openjdk.java.net/browse/JDK-8218947 Are there times you may want to correlate those thread ids with ones in other logs/tools that are in h

RFR(XS): 8218947: jdb threads command should print threadID in decimal, not hex

Hi, Please review the following: http://cr.openjdk.java.net/~cjplummer/8218947/webrev https://bugs.openjdk.java.net/browse/JDK-8218947 Tested by running the following on all supported platforms: open/test/hotspot/jtreg/vmTestbase/nsk/jdb open/test/jdk/com/sun/jdi thanks, Chris

RFR(S): 8218941: jdb should support a dbgtrace command that acts the same as the dbgtrace command line option

Hi, Please review the following: http://cr.openjdk.java.net/~cjplummer/8218941/webrev https://bugs.openjdk.java.net/browse/JDK-8218941 Tested by running the following on all supported platforms: open/test/hotspot/jtreg/vmTestbase/nsk/jdb open/test/jdk/com/sun/jdi thanks, Chris

Re: [aarch64-port-dev ] RFR: 8209413: AArch64: NPE in clhsdb jstack command

On 12/02/2019 23:32, Andrew Haley wrote: > What's the status of this? Are you still looking at it? > Apologies, I was on holiday until today so haven't done anything on it. I'll send an updated patch shortly... Nick

Re: RFR(T) : 8209455 : [error-prone] JdkObsolete in jdk.management.agent

Hi Igor, Looks good to me :) Jc On Wed, Feb 13, 2019 at 11:24 AM Igor Ignatyev wrote: > Hi Alan, > > actually, String::join is enough in this case, uploaded webrev.01 -- > http://cr.openjdk.java.net/~iignatyev//8209455/webrev.01 > > Thanks, > -- Igor > > On Feb 12, 2019, at 11:04 PM, Alan Batem

Re: RFR: JDK-8066993: nsk.jdi.EventRequest.setEnabled.setenabled003 fails: event IS NOT a breakpoint

Right now I'm proposing we use the bug number that matches the entry in the ProblemList to remove the test from the ProblemList. The other matching rules that were added for connection closed and the other bugs with connection closed had no valid reason for attaching to a bug with a specific err

Re: RFR: JDK-8066993: nsk.jdi.EventRequest.setEnabled.setenabled003 fails: event IS NOT a breakpoint

Hi Gary, Looks good. What are your plans for bug management? I think the CR should actually be closed as CNR and removal from the problemlist be done as a subtask. Also, there are a lot of other failures reported with other tests under this bug. Kind of became a dumping ground, but none of t

Re: RFR(T) : 8209455 : [error-prone] JdkObsolete in jdk.management.agent

Hi Alan, actually, String::join is enough in this case, uploaded webrev.01 -- http://cr.openjdk.java.net/~iignatyev//8209455/webrev.01 Thanks, -- Igor > On Feb 12, 2019, at 11:04 PM, Alan Bateman wrote: > > On 13/02/2019 00:01, Igor

Re: RFR JDK-8218702: [TESTBUG] com/sun/jdi/RepStep.java does not report debuggee errors

Ok On 2/12/19 4:45 PM, Alex Menkov wrote: Hi Chris, Most of JDI tests use helper classes (VMConnection or Debuggee) which redirect debuggee outputs. LaunchingConnector is used only by RepStep, SunBootClassPathEmptyTest and DebugUsingCustomConnector and only RepStep really performs debugging

Re: RFR: 8218734: SA: Incorrect and raw loads of OopHandles

On 2019-02-13 17:12, coleen.phillim...@oracle.com wrote: On 2/13/19 10:40 AM, Stefan Karlsson wrote: On 2019-02-13 14:40, coleen.phillim...@oracle.com wrote: On 2/11/19 3:39 AM, Stefan Karlsson wrote: Hi all, Please review this patch to fix the resolving of oops inside the (VM) OopHandle

RFR: JDK-8066993: nsk.jdi.EventRequest.setEnabled.setenabled003 fails: event IS NOT a breakpoint

The setenabled003 test has been on the ProblemList since it was first moved to the open repos. After 1000 test runs on {solaris, macosx, windows, linux} for the test/hotspot/jtreg/vmTestbase/nsk/jdi/EventRequest/setEnabled tests, the problem does not currently reproduce. My recommendation is th

RFR/C: 8218922: SA: Enable best-effort implementation of live regions iteration for ZGC

Hi all, Please review / comment on this patch to enable a best-effort live heap region iteration implementation in ZGC. http://cr.openjdk.java.net/~stefank/8218922/webrev.01/ https://bugs.openjdk.java.net/browse/JDK-8218922 The SA has functionally that relies on live heap region information f

Re: RFR(S) 8212127: Cleanup TLAB fast refill statistics, perf counters and etc.

Thanks, Per. > > Thanks for cleaning this up. GC changes look good. Just one minor > > thing, > > please align the assignment here: > > > > @@ -147,8 +145,7 @@ > > > > void ThreadLocalAllocBuffer::reset_statistics() { > > _number_of_refills = 0; > > - _fast_refill_waste = 0; > > - _slow_

Re: RFR(S) 8218751 Do not store original classfiles inside the CDS archive

Hi Calvin Thanks for the review. On 2/12/19 11:29 AM, Calvin Cheung wrote: Hi Ioi, The following call is probably slower than before because it involves reading from a jar file. cfs = FileMapInfo::open_stream_for_jvmti(ik, CHECK_NULL); It is probably ok since the above is called under the fo

Re: RFR: 8218743: SA: Add support for large bitmaps

Hi Jini, On 2019-02-13 05:53, Jini George wrote: Hi Stefan, Looks good to me. Nits: pls do change the copyright year. Thanks for reviewing. I'll update the copyright years. Thanks, StefanK Thanks, Jini. On 2/11/2019 6:06 PM, Stefan Karlsson wrote: Hi all, Please review this patch to ad