Hi Alan, actually, String::join is enough in this case, uploaded webrev.01 -- http://cr.openjdk.java.net/~iignatyev//8209455/webrev.01 <http://cr.openjdk.java.net/~iignatyev//8209455/webrev.01>
Thanks, -- Igor > On Feb 12, 2019, at 11:04 PM, Alan Bateman <alan.bate...@oracle.com> wrote: > > On 13/02/2019 00:01, Igor Ignatyev wrote: >> http://cr.openjdk.java.net/~iignatyev//8209455/webrev.00 >>> 2 lines changed: 0 ins; 0 del; 2 mod; >> >> Hi all, >> >> could you please review this trivial cleanup which replaces StringBuffer by >> StringBuilder in jdk.management.agent module? >> >> webrev: http://cr.openjdk.java.net/~iignatyev/8209455/webrev.00/ >> JBS: https://bugs.openjdk.java.net/browse/JDK-8209455 >> > Looks okay but StringJoiner might be better here. > > -Alan
