On 2/18/19 9:17 PM, David Holmes wrote:
Hi Chris,
On 16/02/2019 11:08 am, Chris Plummer wrote:
Hi,
Please review the updated webrev:
http://cr.openjdk.java.net/~cjplummer/8218947/webrev.02/
https://bugs.openjdk.java.net/browse/JDK-8218947
Seems fine.
I removed "hex" from "object descriptio
On 18/02/2019 17:22, Andrew Haley wrote:
>>
>> Should we do this now? There's only two places I can see:
>> StubGenerator::generate_throw_exception and the set_last_Java_frame
>> overload that takes a Label.
>
> I hate cruft like this, but it's not actually a bug, and any change in this
> delicate
Hi Chris,
On 16/02/2019 11:08 am, Chris Plummer wrote:
Hi,
Please review the updated webrev:
http://cr.openjdk.java.net/~cjplummer/8218947/webrev.02/
https://bugs.openjdk.java.net/browse/JDK-8218947
Seems fine.
I removed "hex" from "object description and hex id" and removed the
java.lang.
Looks good. Imo "-histo:" should be valid because it's backward compatible.
Serguei, if you concur I'll push the patch for Lin.
Thanks,
Paul
On 2/17/19, 7:28 PM, "臧琳" wrote:
Dear All,
Thanks a lot for your reviewing.
Here I refined the patch to fix a minor bug tha
Great, thanks Stefan, that collection of changes builds for me and I've
seem the histogram from a live process using ZGC, and a core of the
same. Fantastic. 8-)
On 15/02/2019 19:06, Stefan Karlsson wrote:
Hi Kevin,
On 2019-02-15 13:14, Kevin Walls wrote:
Hi Stefan,
This is great - if I
Thanks, Erik.
StefanK
On 2019-02-18 10:35, Erik Österlund wrote:
Hi Stefan,
Looks good!
Thanks,
/Erik
On 2019-02-15 20:25, Stefan Karlsson wrote:
Testing showed that the re-enabling of the retiring of TLABs was
broken. This has been fixed with this patch:
http://cr.openjdk.java.net/~stefa
Hi Stefan,
Looks good!
Thanks,
/Erik
On 2019-02-15 20:25, Stefan Karlsson wrote:
Testing showed that the re-enabling of the retiring of TLABs was
broken. This has been fixed with this patch:
http://cr.openjdk.java.net/~stefank/8218922/webrev.03.delta
http://cr.openjdk.java.net/~stefank/82189
On 2/18/19 7:36 AM, Nick Gasson (Arm Technology China) wrote:
> http://cr.openjdk.java.net/~ngasson/8209413/webrev.03/
>
> It contains your suggested change below, as well as an extra check in
> the AARCH64Frame two-argument constructor that the PC from SP[-1] is
> valid. Also changed SharedRunt
