Hi Coleen,
+1
Thank you for taking care about it!
-Serguei
On 3/15/19 5:42 PM, Chris Plummer wrote:
+1
On 3/15/19 5:29 PM, Daniel D. Daugherty wrote:
Thumbs up.
Dan
On 3/15/19 8:25 PM, coleen.phillim...@oracle.com wrote:
Hi, Okay I see how it works now. I was wondering how to tell it
I'm not sure of the history of tier1_serviceability. It might be that
only a couple of subdirs were initially included, so it was easier to do
the included dirs rather than the excluded ones.
Chris
On 3/15/19 5:14 PM, Daniel D. Daugherty wrote:
Yikes. I missed that. Here's the beginning of ti
+1
On 3/15/19 5:29 PM, Daniel D. Daugherty wrote:
Thumbs up.
Dan
On 3/15/19 8:25 PM, coleen.phillim...@oracle.com wrote:
Hi, Okay I see how it works now. I was wondering how to tell it to
ever run the tests.
I fixed it so that the serviceability RedefineClasses tests are run
in tier1 a
Thanks Dan and Chris too.
Coleen
On 3/15/19 8:29 PM, Daniel D. Daugherty wrote:
Thumbs up.
Dan
On 3/15/19 8:25 PM, coleen.phillim...@oracle.com wrote:
Hi, Okay I see how it works now. I was wondering how to tell it to
ever run the tests.
I fixed it so that the serviceability RedefineC
Thumbs up.
Dan
On 3/15/19 8:25 PM, coleen.phillim...@oracle.com wrote:
Hi, Okay I see how it works now. I was wondering how to tell it to
ever run the tests.
I fixed it so that the serviceability RedefineClasses tests are run in
tier1 and I'll rerun tier1.
http://cr.openjdk.java.net/~c
Hi, Okay I see how it works now. I was wondering how to tell it to ever
run the tests.
I fixed it so that the serviceability RedefineClasses tests are run in
tier1 and I'll rerun tier1.
http://cr.openjdk.java.net/~coleenp/2019/8220744.02/webrev
Coleen
On 3/15/19 8:14 PM, Daniel D. Daugh
Yikes. I missed that. Here's the beginning of tier1_runtime:
L261: tier1_runtime = \
L262: runtime/ \
and here's the beginning of tier1_serviceability:
L324 tier1_serviceability = \
L325 serviceability/dcmd/compiler \
I should not have assumed. Does anyone know why tier1_serviceabi
Hi Coleen,
I think in TEST.groups you need to add
serviceability/jvmti/RedefineClasses to tier1_serviceability. Otherwise
the removes of specific tests isn't doing anything, and
tier1_serviceability won't run the other tests you moved from tier1_runtime.
thanks,
Chris
On 3/15/19 4:14 PM,
On 3/15/19 7:14 PM, coleen.phillim...@oracle.com wrote:
Summary: move tests out of runtime to jvmti/RedefineClasses
These always belonged in serviceability/jvmti. Also, moved a couple
tests within serviceability/jvmti to RedefineClasses also.
open webrev at http://cr.openjdk.java.net/~coleen
Hi Daniil,
Is it not possible that the VMDeath would happen later in the case of:
http://cr.openjdk.java.net/~dtitov/8218401/webrev.01/test/hotspot/jtreg/vmTestbase/nsk/jvmti/FramePop/framepop002/framepop002.cpp.html
For example, that callbacks are not yet disabled when we pass the new test:
+
Thanks Misha!
Coleen
On 3/15/19 7:29 PM, mikhailo.seledt...@oracle.com wrote:
Looks good to me,
(I am not a Reviewer though)
Misha
On 3/15/19 4:14 PM, coleen.phillim...@oracle.com wrote:
Summary: move tests out of runtime to jvmti/RedefineClasses
These always belonged in serviceability/jvm
Looks good to me,
(I am not a Reviewer though)
Misha
On 3/15/19 4:14 PM, coleen.phillim...@oracle.com wrote:
Summary: move tests out of runtime to jvmti/RedefineClasses
These always belonged in serviceability/jvmti. Also, moved a couple
tests within serviceability/jvmti to RedefineClasses
Summary: move tests out of runtime to jvmti/RedefineClasses
These always belonged in serviceability/jvmti. Also, moved a couple
tests within serviceability/jvmti to RedefineClasses also.
open webrev at http://cr.openjdk.java.net/~coleenp/2019/8220744.01/webrev
bug link https://bugs.openjdk.ja
Please review the change that fixes 3 tests that intermittently fail with
JVMTI_ERROR_WRONG_PHASE error.
The problem here is that the callbacks these tests enable keep processing
events and perform JVMTI calls after VM is terminated. The fix makes these test
listen for VMDeath event and quick
> Webrev: http://cr.openjdk.java.net/~dtitov/8218812/webrev.02
test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/jvmti_tools.cpp
L604: if ((strlen(threadinfo.name) > prefixLength) &&
nit - you have an extra '(' ')' pair that's not needed.
Thumbs up! No need for another webrev if you
On 3/13/19 11:54 AM, Gary Adams wrote:
One last set of diffs ...
- added comments on the ignored exceptions
- commented out excessive diagnostic print out
(this will remove the jtreg truncated output)
Ok to use dan, dean and jc as reveiwers?
diff --git a/test/jdk/com/sun/jdi/SimulResum
Hi,
I ran into a few additional test issues, one exposing a crash in jmap
-histo:live in a test that seems to have been problem listed when I
ran tests earlier.
Also filtering out archived-but-not-yet-loaded classes in
KlassInfoBucket::lookup makes tests exercising jmap etc work as intended
in t
Thank you Erik!
Coleen
On 3/15/19 11:02 AM, Erik Österlund wrote:
Hi Coleen,
Looks good. Thanks for doing this!
/Erik
On 2019-03-15 15:58, coleen.phillim...@oracle.com wrote:
From some offline feedback, I changed the name of has_evol_ics =>
has_evol_metadata and a couple of other small thi
Hi Nick,
Fix looks good. How have you tested it ?
Thanks,
Sharath
-Original Message-
From: Nick Gasson [mailto:nick.gas...@arm.com]
Sent: Friday, March 15, 2019 1:02 PM
To: serviceability-dev@openjdk.java.net
Subject: RFR(XS): 8220707: [TESTBUG]
serviceability/sa/TestHeapDumpForLarg
Hi Jc,
On 2019-03-15 15:55, Jean Christophe Beyler wrote:
Hi Claes,
Looks good to me.
thanks!
/Claes
For those who would want to see the patch change done
in the serviceability-agent:
http://hg.openjdk.java.net/jdk/jdk/rev/91f06b86c0da
Hi Coleen,
Looks good. Thanks for doing this!
/Erik
On 2019-03-15 15:58, coleen.phillim...@oracle.com wrote:
From some offline feedback, I changed the name of has_evol_ics =>
has_evol_metadata and a couple of other small things. I reran this
though builds and tier1 tests.
Incremental:
h
From some offline feedback, I changed the name of has_evol_ics =>
has_evol_metadata and a couple of other small things. I reran this
though builds and tier1 tests.
Incremental:
http://cr.openjdk.java.net/~coleenp/2019/8220512.02.incr/webrev/index.html
Full: http://cr.openjdk.java.net/~col
Hi Claes,
Looks good to me. For those who would want to see the patch change done in
the serviceability-agent:
http://hg.openjdk.java.net/jdk/jdk/rev/91f06b86c0da
Thanks,
Jc
On Fri, Mar 15, 2019 at 5:10 AM Claes Redestad
wrote:
> Hi,
>
> to allow for archiving objects in CDS that might not be
Hi Nick,
Not a reviewer but looks good to me :) I would perhaps put a comment above
the argument creation to note that the order is important, ie something
like:
"// Need to add the default arguments first to have explicit -Xmx8g last,
otherwise test will fail."
Thanks,
Jc
On Fri, Mar 15, 2019
Hi,
to allow for archiving objects in CDS that might not be loaded (e.g.,
JDK-8214712), we need to ignore objects at heap dump time that haven't
actually been loaded. This patch fixes the VM heapDumper implementation,
and is a mirror of a fix already done in the serviceability-agent heap
dumper[1
Hello, please review the following change .
It enhances the error messages in libinstrument in case initialization fails .
( I found the enhanced error messages helpful when analyzing jtreg
failures on one of our platforms in the
java/lang/instrument/PremainClass/PremainClassTest.java
Hi,
Please review this very small test fix to
serviceability/sa/TestHeapDumpForLargeArray.java:
Bug: https://bugs.openjdk.java.net/browse/JDK-8220707
Webrev: http://cr.openjdk.java.net/~ngasson/8220707/webrev.0/
If you run this test with jtreg option -vmoption:-Xmx512m (or any value
< 8g) th
27 matches
Mail list logo
