Re: [RFR]8215623: Add incremental dump for jmap histo

Dear All, I have created a CSR at https://bugs.openjdk.java.net/browse/JDK-8222319. May I ask your help to review it? Thanks! BRs, Lin 在 2019年4月11日，上午11:22，臧琳 mailto:zangl...@jd.com>> 写道： Sorry, it should be CSR ticket Thanks， Lin 在 2019年4月11日，上午11:16，臧琳 mailto:zangl...@jd.com>> 写道：

Re: [RFR]8215623: Add incremental dump for jmap histo

Sorry, it should be CSR ticket Thanks， Lin 在 2019年4月11日，上午11:16，臧琳 mailto:zangl...@jd.com>> 写道： Also realized it requires a JCP ticket, I will create it. Cheers, Lin 在 2019年4月11日，上午10:26，臧琳 mailto:zangl...@jd.com>> 写道： Dear JC, Thanks so much, I suddenly realized your way is exactly what

Re: [RFR]8215623: Add incremental dump for jmap histo

Also realized it requires a JCP ticket, I will create it. Cheers, Lin 在 2019年4月11日，上午10:26，臧琳 mailto:zangl...@jd.com>> 写道： Dear JC, Thanks so much, I suddenly realized your way is exactly what I want. And here is new wehbrev. http://cr.openjdk.java.net/~lzang/jmap-8214535/8215623/webrev

Re: [RFR]8215623: Add incremental dump for jmap histo

Dear JC, Thanks so much, I suddenly realized your way is exactly what I want. And here is new wehbrev. http://cr.openjdk.java.net/~lzang/jmap-8214535/8215623/webrev.06/ BRs, Lin 在 2019年4月11日，上午4:40，Jean Christophe Beyler mailto:jcbey...@google.com>> 写道： Hi Lin, What I meant about the

Re: 8222224: vmTestbase/nsk/jvmti/SingleStep/singlestep001/TestDescription.java fails

Thank you, Serguei, JC, and Alex, for reviewing this change. Best regards, Daniil On 4/10/19, 9:58 AM, "serviceability-dev on behalf of Alex Menkov" wrote: +1 --alex On 04/09/2019 19:38, Jean Christophe Beyler wrote: > Hi Daniil, > > Looks good to me too :-)

Re: [RFR]8215623: Add incremental dump for jmap histo

Hi Lin, What I meant about the helper method was to not do this: +private static String add_option(String cmd, String opt) { + if (opt.equals("")) { +return cmd; + } + return cmd + opt + ","; +} + but to do this: +private static String add_option(String cmd,

Re: RFR: 8222224: vmTestbase/nsk/jvmti/SingleStep/singlestep001/TestDescription.java fails

+1 --alex On 04/09/2019 19:38, Jean Christophe Beyler wrote: Hi Daniil, Looks good to me too :-) Jc On Tue, Apr 9, 2019 at 7:01 PM > wrote: Hi Daniil, It looks good. Thanks, Serguei On 4/9/19 4:37 PM, Daniil Titov wrote: > Plea

Re: RFR(MS): 8222072: JVMTI GenerateEvents() sends CompiledMethodLoad events to wrong jvmtiEnv

Much simpler and cleaner! LGTM. --alex On 04/09/2019 18:56, serguei.spit...@oracle.com wrote: Hi Alex, New webrev version with refactoring: http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8222072-jvmti-GenerateEvents.3/ I will also re-submit mach5 jobs for jvmti tests and new test. Than

Re: [RFR]8215623: Add incremental dump for jmap histo

Dear Jc, Thanks a lot for your comments, here is the refined webrev. May I ask your help to review again? http://cr.openjdk.java.net/~lzang/jmap-8214535/8215623/webrev.05/ BRs, Lin 在 2019年4月4日，上午4:57，Jean Christophe Beyler mailto:jcbey...@google.com>> 写道： Hi Lin, Just a few nits to be ho