Re: RFR (M) 8223040: Add a AGCT test

Hi Serguei, Here is an updated webrev with the fixes from your and Dan's comments: Webrev: http://cr.openjdk.java.net/~jcbeyler/8223040/webrev.02/ Bug: https://bugs.openjdk.java.net/browse/JDK-8223040 Below are the inlined answers to your comments. On Fri, May 3, 2019 at 3:53 PM wrote: > Hi J

Re: RFR: JDK-8184770: JDWP support for IPv6

Hi Alex, Thank you for creating the CSR! I've added myself as a reviewer and corrected a couple of places. Feel free to change my changes if necessary. :) It would be nice to get one more CSR review if possible, so I've added the net-dev mailing list. I hope to finish the webrev review soon.

Re: RFR (M) 8223040: Add a AGCT test

On 5/3/19 7:59 AM, Daniel D. Daugherty wrote: On 5/2/19 8:28 PM, Jean Christophe Beyler wrote: :) Sounds good to me and here is the new webrev with that naming scheme: Webrev: http://cr.openjdk.java.net/~jcbeyler/8223040/webrev.01/

Re: RFR (M) 8223040: Add a AGCT test

Hi Jc, Thank you a lot for taking care about this! It is the first test, and, probably, you will add more. So, I want to know about the naming approach for AsyncGetCallTrace**tests. Name suffixes will be needed for new tests. So, you can keep generic name for this one or name it as AsyncGetCal

Re: RFR: JDK-8223319: Add copyright footer to specs and man pages

On 5/3/19 2:00 PM, Erik Joelsson wrote: I posted the diff for jdwp-protocol.html below too (but I forgot the dot in the filename). That file currently does not have any copyright visible in html, but the new footer looks the same (except for having a different relative path in the link to co

Re: RFR: JDK-8223319: Add copyright footer to specs and man pages

I posted the diff for jdwp-protocol.html below too (but I forgot the dot in the filename). That file currently does not have any copyright visible in html, but the new footer looks the same (except for having a different relative path in the link to copyright.html). /Erik On 2019-05-03 13:35,

Re: RFR: JDK-8223319: Add copyright footer to specs and man pages

Thank you, Erik. Is it the same with the jdwp-protocol.html? If so then I'm Okay with the fix. Thanks, Serguei On 5/3/19 11:50 AM, Erik Joelsson wrote: The new footer looks exactly like on the api docs today. jvmti.html: 36481,36484c36481 < < Copyright (c) 2002, 2018, Oracle and

RE: RFR: JDK-8223319: Add copyright footer to specs and man pages

Hi, Erik. > New webrev: http://cr.openjdk.java.net/~erikj/8223319/webrev.02/ The revised webrev looks good. Thank you! Iris

Re: RFR: JDK-8223319: Add copyright footer to specs and man pages

The new footer looks exactly like on the api docs today. jvmti.html: 36481,36484c36481 < < Copyright (c) 2002, 2018, Oracle and/or its affiliates. All rights reserved. <   < --- > Copyright © 1993, 2019, Oracle and/or its affiliates, 500 Oracle Parkway, Redwood Shores,

Re: RFR: JDK-8223319: Add copyright footer to specs and man pages

Hi Erik, Could you, please, show a simple diff for jvmti.html and jdwp-protocol.html? Thanks, Serguei On 5/3/19 09:37, Erik Joelsson wrote: The (optional) specs and man pages should have the same copyright footer as the generated API docs. This patch adds the logic to add such footers. It al

Re: RFR: JDK-8223319: Add copyright footer to specs and man pages

Thanks Iris! I did not think about jvmti.xsl, but have removed those lines as well now. New webrev: http://cr.openjdk.java.net/~erikj/8223319/webrev.02/ /Erik On 2019-05-03 09:53, Iris Clark wrote: Hi, Erik. I'm happy to see this change go in. It looks good. Just one comment. When removin

RE: RFR: JDK-8223319: Add copyright footer to specs and man pages

Hi, Erik. I'm happy to see this change go in. It looks good. Just one comment. When removing the footer in jvmit.html, I suspect that you also need to make changes to jvmti.xsl, which was also modified when the copyright footer was inserted in this changeset: http://hg.openjdk.java.net/j

Re: 8222667: vmTestbase/nsk/jdi/ThreadStartRequest/addThreadFilter/addthreadfilter002/TestDescription.java failed with "event IS NOT a breakpoint"

Thank you, Serguei, Chris, JC, and Gary, for reviewing this change. Best regards, Daniil On 5/2/19, 6:13 PM, "serguei.spit...@oracle.com" wrote: Hi Daniil, Looks good. Thank you for the update. Sorry, I forgot to tell no new webrev is needed if you fix this. :) T

RFR: JDK-8223319: Add copyright footer to specs and man pages

The (optional) specs and man pages should have the same copyright footer as the generated API docs. This patch adds the logic to add such footers. It also removes the existing footer in jvmti.html. Bug: https://bugs.openjdk.java.net/browse/JDK-8223319 Webrev: http://cr.openjdk.java.net/~erikj/

Re: RFR (M) 8223040: Add a AGCT test

On 5/2/19 8:28 PM, Jean Christophe Beyler wrote: :) Sounds good to me and here is the new webrev with that naming scheme: Webrev: http://cr.openjdk.java.net/~jcbeyler/8223040/webrev.01/ make/test/JtregNativeHotspot.gmk     No comments. test/hotspot/jtreg/serviceability/AsyncGetCallTrace/MyPac

Re: [11u] RFR: 8204308: SA: serviceability/sa/TestInstanceKlassSize*.java fails when running in CDS mode

On 5/3/19 2:56 PM, Severin Gehwolf wrote: > Hi, > > Could I please get reviews for this JDK 11 backport? The JDK 12 change > does not apply cleanly unfortunately. One hunk in ProblemList.txt > didn't apply because of changed context lines. That's the only > difference. > > Bug: https://bugs.openj

[11u] RFR: 8204308: SA: serviceability/sa/TestInstanceKlassSize*.java fails when running in CDS mode

Hi, Could I please get reviews for this JDK 11 backport? The JDK 12 change does not apply cleanly unfortunately. One hunk in ProblemList.txt didn't apply because of changed context lines. That's the only difference. Bug: https://bugs.openjdk.java.net/browse/JDK-8204308 webrev: http://cr.openjdk.j

Re: 8157947: SA: Javascript engine can't access internal packages of jdk.hotspot.agent

On 02/05/2019 09:35, Yasumasa Suenaga wrote: > Would it be possible re-outline the problem and/or include the exception that is being observed? We can see TypeError thrown by Nashorn when we attach CLHSDB. It means JS in jdk.hotspot.agent (sa.js) could not call sun.jvm.hotspot.runtime.VM::getV