Re: RFR JDK-8225474: JDI connector accept fails "Address already in use" with concurrent listeners

2019-06-10 Thread Andrew Leonard
Thanks for the feedback everyone. Hi Alan, yes I can put some cycles into digging deeper with this one, as you point out there's probably more that needs doing. As Alex found running the new testcase 400 times it failed once still, interestingly during initial startListening() rather than the ac

Re: RFR JDK-8225474: JDI connector accept fails "Address already in use" with concurrent listeners

2019-06-10 Thread Andrew Leonard
Hi Alex, Thanks for trying this out, it's possible this failure is an issue with my testcase, as I repeat the 10 thread test loop 10 times and I have a 30 second timeout which potentially might overrun if a connection takes time to terminate. I could avoid that simply by using different ports fo

Re: RFR JDK-8225474: JDI connector accept fails "Address already in use" with concurrent listeners

2019-06-10 Thread Andrew Leonard
Hi Alan, So I have done some research and analysis, and I have come to some conclusions over the key stop/start/accept methods in GenericListeningConnector: stopListening() { (1)TransportService.ListenKey listener = listenMap.get(args); if (listener == null) { throw new Il

Re: 8222828: vmTestbase/nsk/jdi/BScenarios/multithrd/tc02x004/TestDescription.java failed

2019-06-10 Thread Daniil Titov
Thank you, Chris, JC, and Gary, for reviewing this change! Best regards, Daniil On 6/7/19, 12:31 PM, "Chris Plummer" wrote: Looks good. Chris On 6/7/19 11:47 AM, Daniil Titov wrote: > Please review the change that fixes an intermittent failure of the test when it is

Re: RFR JDK-8225474: JDI connector accept fails "Address already in use" with concurrent listeners

2019-06-10 Thread Robert Field
Thanks Andrew! If you want more data points on failure modes, this and the linked issues might be a rich source: https://bugs.openjdk.java.net/browse/JDK-8184445 JShell is built on JDI and these various forms of intermittent attach failures have been a continual pain point. -Robert On 6/

Re: RFR JDK-8225474: JDI connector accept fails "Address already in use" with concurrent listeners

2019-06-10 Thread Alex Menkov
On 06/10/2019 02:07, Andrew Leonard wrote: Hi Alex, Thanks for trying this out, it's possible this failure is an issue with my testcase, as I repeat the 10 thread test loop 10 times and I have a 30 second timeout which potentially might overrun if a connection takes time to terminate. I cou

RFR: 8225543: Jcmd fails to attach to the Java process on Linux using the main class name if whitespace options were used to launch the process

2019-06-10 Thread Daniil Titov
Please review the change that fixes jcmd process name matching on Linux platform. After changes [3] , on Linux platform the proc filesystem is used to find a Java process, however, sun.tools.ProcessHelper class, introduced in that change, didn't take into account the presence of module whites