Re: RFR: 8170299: Debugger does not stop inside the low memory notifications code

Hi Daniil, I've not finished my review but it looks good in general. A couple of quick comments. https://cr.openjdk.java.net/~dtitov/8170299/webrev.01/src/hotspot/share/runtime/notificationThread.hpp.html  I wonder if this function is also needed:    static bool

Re: RFR(XXS): 8227117: normal interpreter table is not restored after single stepping with TLH

Hi Dan, Thank you and Robbin for discovering and fixing this! The fix looks good to me. It is nice to have this new logging. Should we fix this bug in 13 first, or you consider it risky? Thanks, Serguei On 7/3/19 7:04 PM, Daniel D. Daugherty wrote: Greetings, Robbin recently discovered

RFR: 8170299: Debugger does not stop inside the low memory notifications code

Please review the change the fixes the problem with the debugger not stopping in the low memory notification code. The problem here is that the ServiceThread that calls these MXBean listeners is hidden from the external view that prevents the debugger from stopping in it. The fix introduces

RFR(XXS): 8227117: normal interpreter table is not restored after single stepping with TLH

Greetings, Robbin recently discovered this issue with Thread Local Handshakes. Since he's not available at the moment, I'm handling the issue:     JDK-8227117 normal interpreter table is not restored after single stepping with TLH     https://bugs.openjdk.java.net/browse/JDK-8227117 When

Re: RFR: JDK-8227124: "could not open pipe" error does not report error details

On 7/3/19 4:38 PM, Alex Menkov wrote: Hi Chris, On 07/03/2019 15:16, Chris Plummer wrote: Hi Alex, I think the calls to GetLastError() should be in the else clauses, just before or as part of the log_error() statements. Otherwise you are making the GetLastError() calls even when there is no

Re: RFR: JDK-8227124: "could not open pipe" error does not report error details

Hi Chris, On 07/03/2019 15:16, Chris Plummer wrote: Hi Alex, I think the calls to GetLastError() should be in the else clauses, just before or as part of the log_error() statements. Otherwise you are making the GetLastError() calls even when there is no error. It can be done this way for

Re: PING: RFR: 8209790: SA tools not providing option to connect to debug server

Hi Yasumasa, Overall these changes look good, but I think there is a bit of cleanup still needed. You've changed the indentation of the help to always have a few spaces before the /t. If you are going to do this, then perhaps you don't need

Re: RFR: JDK-8227124: "could not open pipe" error does not report error details

Hi Alex, I think the calls to GetLastError() should be in the else clauses, just before or as part of the log_error() statements. Otherwise you are making the GetLastError() calls even when there is no error. thanks, Chris On 7/3/19 1:59 PM, Alex Menkov wrote: Hi all, Please review a fix

Re: RFR: JDK-8227124: "could not open pipe" error does not report error details

Hi Alex, It looks good to me. It is nice to have this extra information about failures. Thanks, Serguei On 7/3/19 1:59 PM, Alex Menkov wrote: Hi all, Please review a fix for https://bugs.openjdk.java.net/browse/JDK-8227124 This is subtask of JDK-8221512: Failed to complete jcmd operation

RFR: JDK-8227124: "could not open pipe" error does not report error details

Hi all, Please review a fix for https://bugs.openjdk.java.net/browse/JDK-8227124 This is subtask of JDK-8221512: Failed to complete jcmd operation '[error][attach] could not open pipe \\.\pipe\javatool-708501419 to send result of operation jcmd' To fix issues with "could not open pipe"

Re: RFR 8227178: Backout of 8215523

Hi, On Wed, 2019-07-03 at 07:24 -0700, Poonam Parhar wrote: > Hello, > > Please review the changeset that reverses the changes done with > JDK-8215523 . > > JDK-8227178 : > Backout > of 8215523

RFR 8227178: Backout of 8215523

Hello, Please review the changeset that reverses the changes done with JDK-8215523 . JDK-8227178 : Backout of 8215523 webrev: http://cr.openjdk.java.net/~poonam/8227178/webrev.00/ The fix

Re: RFR: 8227086: Use AS_NO_KEEPALIVE loads in HeapDumper

Thanks, Serguei. StefanK On 2019-07-02 17:57, serguei.spit...@oracle.com wrote: Hi Stefan, It looks good. Thanks, Serguei On 7/2/19 06:53, Stefan Karlsson wrote: Hi all, Please review this patch to read objects with AS_NO_KEEPALIVE in the HeapDumper.

Re: RFR: 8227086: Use AS_NO_KEEPALIVE loads in HeapDumper

Thanks, Kim. StefanK On 2019-07-03 00:11, Kim Barrett wrote: On Jul 2, 2019, at 9:53 AM, Stefan Karlsson wrote: Hi all, Please review this patch to read objects with AS_NO_KEEPALIVE in the HeapDumper. http://cr.openjdk.java.net/~stefank/8227086/webrev.01/

Re: (13) RFR(XS): 8226596: Accessibility errors in jdwp-protocol.html

On 7/2/19 10:12 PM, David Holmes wrote: On 3/07/2019 2:27 pm, serguei.spit...@oracle.com wrote: On 7/2/19 8:57 PM, David Holmes wrote: On 2/07/2019 7:53 pm, serguei.spit...@oracle.com wrote: On 7/2/19 01:06, David Holmes wrote: Hi Serguei, On 2/07/2019 6:01 pm, David Holmes wrote: Hi