Re: RFR (M): 8231595 [TEST] develop a test case for SuspendThreadList including current thread

Hi Serguei, On 28/09/2019 11:25 am, serguei.spit...@oracle.com wrote: Please, review fix for test enhancement:   https://bugs.openjdk.java.net/browse/JDK-8231595 Webrev: http://cr.openjdk.java.net/~sspitsyn/webrevs/2019/8231595-jvmti-susp-tlist.1/ Sorry but I could barely follow the logic o

Re: RFR (M): 8231595 [TEST] develop a test case for SuspendThreadList including current thread

Hi Serguei, Overall looks good. A few questions: I don't understand the need for all the 'i' and 'n' theatrics in the shouldFinish loop. Can you explain and also add a comment? Is this comment right?  193 // set thread is not ready again  194 public void setAllThreadsReady() {  195  

Re: RFR (XS): 8231600: Avoid GCC 8 strncpy error in jdk.jdwp.agent

Fix looks good. thanks, Chris On 9/28/19 2:09 AM, Florian Weimer wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8231600 Webrev: http://cr.openjdk.java.net/~fweimer/8231600/webrev.01/ We know the size of the string, so we can use memcpy instead of strncpy. Thanks, Florian

Re: RFR: 8231296: ZGC: vmTestbase/nsk/jvmti/Allocate/alloc001/ fails

Hi Per, if you decide to go w/ @requires, I'd encourage you to also put an explaining comment in the test descriptor using jtreg's tag @comment, so at least it will be easier for future readers to understand why the test can't / shouldn't be run w/ ZGC. Thanks, -- Igor > On Sep 27, 2019, at

RFR (XS): 8231600: Avoid GCC 8 strncpy error in jdk.jdwp.agent

Bug: https://bugs.openjdk.java.net/browse/JDK-8231600 Webrev: http://cr.openjdk.java.net/~fweimer/8231600/webrev.01/ We know the size of the string, so we can use memcpy instead of strncpy. Thanks, Florian