Hi Mandy,
I think in my previous reply I missed to answer one of the questions from your
email.
>> getFreeSwapSpaceSize retry for a few times. What special about this method
>> but not others like getFreeMemorySize?
The specific of method getFreeSwapSpaceSize is that MemoryAndSwapUsage and
Resending with the corrected subject. "RFR" was somehow stripped from it and
that breaks the sorting by subject...
Hi Mandy,
Thank you for your comments, please find my answers below.
>> src/java.base/linux/classes/jdk/internal/platform/cgroupv1/Metrics.java
>> this should wrap the
Resending with the corrected title, "RFR" was somehow stripped from it that
breaks the sorting by subject...
Hi Bob,
>>It’s too bad getCpuLoad can’t detect that the cpuset is identical to
the hosts in order to allow you to fallback to
>> getSystemCpuLoad0.
I think
Hi Coleen,
That all seems fine to me.
Thanks,
David
On 4/12/2019 4:21 am, coleen.phillim...@oracle.com wrote:
Summary: remove unnecessary nmethodLocker
See bug for more details. Tested with tier2-8.
open webrev at http://cr.openjdk.java.net/~coleenp/2019/8235273.01/webrev
bug link https://b
On 3/12/2019 11:35 pm, coleen.phillim...@oracle.com wrote:
On 12/3/19 8:31 AM, David Holmes wrote:
On 3/12/2019 11:08 pm, coleen.phillim...@oracle.com wrote:
On 12/2/19 11:52 PM, David Holmes wrote:
Hi Coleen,
On 3/12/2019 12:43 am, coleen.phillim...@oracle.com wrote:
On 11/26/19 7:
Thanks Serguei!
Chris
On 12/3/19 1:10 PM, serguei.spit...@oracle.com wrote:
Hi Chris,
It looks good.
Thanks,
Serguei
On 12/3/19 12:45 PM, Chris Plummer wrote:
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8234277
http://cr.openjdk.java.net/~cjplummer/8234277
Thanks Igor!
Chris
On 12/3/19 1:00 PM, Igor Ignatyev wrote:
LGTM,
-- Igor
On Dec 3, 2019, at 12:56 PM, Chris Plummer wrote:
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8235221
diff --git a/test/jdk/ProblemList.txt b/test/jdk/ProblemList.txt
--- a/test/jd
Hi Mandy,
Thank you for your comments, please find my answers below.
>> src/java.base/linux/classes/jdk/internal/platform/cgroupv1/Metrics.java
>> this should wrap the security-sensitive operations with doPrivileged.
>> jdk.management is trusted and it has all permissions.
I will include thi
Hi Bob,
>>It’s too bad getCpuLoad can’t detect that the cpuset is identical to the
>> hosts in order to allow you to fallback to
>> getSystemCpuLoad0.
I think we can detect that the cpuset is identical to the host's one by
comparing the length of the array containerMetrics.getEffectiveCpu
PING: Could you review it?
JBS: https://bugs.openjdk.java.net/browse/JDK-8234624
webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8234624/webrev.01/
This bug is targeted to JDK 14.
Thanks,
Yasumasa
On 2019/11/28 21:39, Yasumasa Suenaga wrote:
Hi,
I refactored LinuxAMD64CFrame.java . I
On 12/3/19 11:42 AM, Daniil Titov wrote:
Please review the change that makes OperatingSystemMXBean methods return
container specific informationrather than the host based data.
The webrev also takes into account the case when
java.security.AccessControlException exception is thrown
during th
Daniil,
Looks good to me.
If there are any management jtreg tests, I’d run these since your changes to
OperatingSystemMXBean will
alter the behavior of these methods even for Linux hosts since cgroups is
typically enabled causing the
container detection to report containerized.
It’s too bad g
Hi Chris,
It looks good.
I'm in favor to always run tests in verbose mode.
It is not a good idea in general to optimize on it.
Thanks,
Serguei
On 12/3/19 12:45 PM, Chris Plummer wrote:
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8234277
http://cr.openjdk.jav
Hi Chris,
It looks good.
Thanks,
Serguei
On 12/3/19 12:45 PM, Chris Plummer wrote:
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8234277
http://cr.openjdk.java.net/~cjplummer/8234277/webrev.00/
No longer redirect stderr for the jhsdb/clhsdb process. It results
LGTM,
-- Igor
> On Dec 3, 2019, at 12:56 PM, Chris Plummer wrote:
>
> Hello,
>
> Please review the following:
>
> https://bugs.openjdk.java.net/browse/JDK-8235221
>
> diff --git a/test/jdk/ProblemList.txt b/test/jdk/ProblemList.txt
> --- a/test/jdk/ProblemList.txt
> +++ b/test/jdk/ProblemLis
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8235221
diff --git a/test/jdk/ProblemList.txt b/test/jdk/ProblemList.txt
--- a/test/jdk/ProblemList.txt
+++ b/test/jdk/ProblemList.txt
@@ -914,8 +914,7 @@
sun/tools/jhsdb/BasicLauncherTest.java 8193639,8211767
solar
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8234277
http://cr.openjdk.java.net/~cjplummer/8234277/webrev.00/
No longer redirect stderr for the jhsdb/clhsdb process. It results in
not seeing attach failures in the output, so OutputAnalyer can't check
for them.
Please review the change that makes OperatingSystemMXBean methods return
container specific information
rather than the host based data.
The webrev [1] is based on the code Andrew and Severin initially provided with
some additional changes and combined
with the spec update David made [3].
The
Thanks, Igor!
Serguei
On 12/3/19 11:32 AM, Igor Ignatyev wrote:
LGTM
-- Igor
On Dec 3, 2019, at 11:29 AM, serguei.spit...@oracle.com wrote:
Please, review a trivial fix for sub-task:
https://bugs.openjdk.java.net/browse/JDK-8235280
The fix is to remove the test from the ProblemList.txt:
LGTM
-- Igor
> On Dec 3, 2019, at 11:29 AM, serguei.spit...@oracle.com wrote:
>
> Please, review a trivial fix for sub-task:
> https://bugs.openjdk.java.net/browse/JDK-8235280
>
> The fix is to remove the test from the ProblemList.txt:
>
> diff --git a/test/hotspot/jtreg/ProblemList.txt
> b/
Please, review a trivial fix for sub-task:
https://bugs.openjdk.java.net/browse/JDK-8235280
The fix is to remove the test from the ProblemList.txt:
diff --git a/test/hotspot/jtreg/ProblemList.txt
b/test/hotspot/jtreg/ProblemList.txt
--- a/test/hotspot/jtreg/ProblemList.txt
+++ b/test/hotspot
Summary: remove unnecessary nmethodLocker
See bug for more details. Tested with tier2-8.
open webrev at http://cr.openjdk.java.net/~coleenp/2019/8235273.01/webrev
bug link https://bugs.openjdk.java.net/browse/JDK-8235273
(Note, this has a trivial merge with the change for JDK-8212160).
Thanks
On 12/3/19 8:31 AM, David Holmes wrote:
On 3/12/2019 11:08 pm, coleen.phillim...@oracle.com wrote:
On 12/2/19 11:52 PM, David Holmes wrote:
Hi Coleen,
On 3/12/2019 12:43 am, coleen.phillim...@oracle.com wrote:
On 11/26/19 7:03 PM, David Holmes wrote:
(adding runtime as well)
Hi Colee
On 3/12/2019 11:08 pm, coleen.phillim...@oracle.com wrote:
On 12/2/19 11:52 PM, David Holmes wrote:
Hi Coleen,
On 3/12/2019 12:43 am, coleen.phillim...@oracle.com wrote:
On 11/26/19 7:03 PM, David Holmes wrote:
(adding runtime as well)
Hi Coleen,
On 27/11/2019 12:22 am, coleen.phillim..
Thanks Erik!
Coleen
On 12/3/19 7:48 AM, erik.osterl...@oracle.com wrote:
Hi Coleen,
This looks great. Thanks for sorting this out!
/Erik
On 12/2/19 3:43 PM, coleen.phillim...@oracle.com wrote:
On 11/26/19 7:03 PM, David Holmes wrote:
(adding runtime as well)
Hi Coleen,
On 27/11/2019 1
On 12/2/19 11:52 PM, David Holmes wrote:
Hi Coleen,
On 3/12/2019 12:43 am, coleen.phillim...@oracle.com wrote:
On 11/26/19 7:03 PM, David Holmes wrote:
(adding runtime as well)
Hi Coleen,
On 27/11/2019 12:22 am, coleen.phillim...@oracle.com wrote:
Summary: Add local deferred event list
Hi Coleen,
This looks great. Thanks for sorting this out!
/Erik
On 12/2/19 3:43 PM, coleen.phillim...@oracle.com wrote:
On 11/26/19 7:03 PM, David Holmes wrote:
(adding runtime as well)
Hi Coleen,
On 27/11/2019 12:22 am, coleen.phillim...@oracle.com wrote:
Summary: Add local deferred even
27 matches
Mail list logo
