Hi Igor,
I have added your update to our test system. I'll let you know the results by
tomorrow.
Best regards
Christoph
> -Original Message-
> From: serviceability-dev On
> Behalf Of Igor Ignatyev
> Sent: Donnerstag, 5. Dezember 2019 03:08
> To: Doerr, Martin ; Lindenmaier, Goetz
>
>
Thanks Dan. I moved the field. For some reason I thought that class
did more/different things than hold per-thread information.
I've retested this version with tiers 2-6.
incr webrev at
http://cr.openjdk.java.net/~coleenp/2019/8212160.03.incr/webrev
full webrev at http://cr.openjdk.java.
Hi Coleen,
On 5/12/2019 10:08 pm, coleen.phillim...@oracle.com wrote:
Thanks Dan. I moved the field. For some reason I thought that class
did more/different things than hold per-thread information.
I've retested this version with tiers 2-6.
incr webrev at
http://cr.openjdk.java.net/~cole
On 12/5/19 8:05 AM, David Holmes wrote:
Hi Coleen,
On 5/12/2019 10:08 pm, coleen.phillim...@oracle.com wrote:
Thanks Dan. I moved the field. For some reason I thought that class
did more/different things than hold per-thread information.
I've retested this version with tiers 2-6.
incr
Hi Ralf,
Not a complete review yet. But this looks good. The seeking before seemed
awkward.
Some remarks:
In DumpWriter, _current_entry_left and _entry_ended seem only to be needed
for asserting. Please enclose their definition in DEBUG_ONLY, and
initialize them in the ctor.
--
I like that Dum
Hi,
Please review this trivial change to add documentation about the Record
attribute to the JDWP, JDI, and Instrumentation specs.
The changed .html pages (best viewed as 'raw') are included in the
webrev but will not be pushed.
Open Webrev:
http://cr.openjdk.java.net/~hseigel/bug_8235360/
On 12/5/2019 9:28 AM, Harold Seigel wrote:
Hi,
Please review this trivial change to add documentation about the
Record attribute to the JDWP, JDI, and Instrumentation specs.
The changed .html pages (best viewed as 'raw') are included in the
webrev but will not be pushed.
Open Webrev:
http
Thanks Lois!
I'll fix the copyright before pushing.
Harold
On 12/5/2019 9:59 AM, Lois Foltan wrote:
On 12/5/2019 9:28 AM, Harold Seigel wrote:
Hi,
Please review this trivial change to add documentation about the
Record attribute to the JDWP, JDI, and Instrumentation specs.
The changed .ht
Hi Collen,
Thank you for making this update!
It looks good to me.
One nit:
http://cr.openjdk.java.net/~coleenp/2019/8212160.03/webrev/test/hotspot/jtreg/serviceability/jvmti/CompiledMethodLoad/libCompiledZombie.cpp.html
46 // Continuo
Do you plan to make JVM/TI spec changes also?
Dan
On 12/5/19 9:28 AM, Harold Seigel wrote:
Hi,
Please review this trivial change to add documentation about the
Record attribute to the JDWP, JDI, and Instrumentation specs.
The changed .html pages (best viewed as 'raw') are included in the
On 12/5/19 11:00 AM, serguei.spit...@oracle.com wrote:
Hi Collen,
Thank you for making this update!
It looks good to me.
One nit:
http://cr.openjdk.java.net/~coleenp/2019/8212160.03/webrev/test/hotspot/jtreg/serviceability/jvmti/CompiledMethodLoad/libCompiledZombie.cpp.html
46 // Continuo
The JVM/TI change for Record attrbute was in the big Records push. I
missed the other three until Serguei pointed it out.
Thanks, Harold
On 12/5/2019 11:15 AM, Daniel D. Daugherty wrote:
Do you plan to make JVM/TI spec changes also?
Dan
On 12/5/19 9:28 AM, Harold Seigel wrote:
Hi,
Please
Thanks for clarifying.
Dan
On 12/5/19 1:30 PM, Harold Seigel wrote:
The JVM/TI change for Record attrbute was in the big Records push. I
missed the other three until Serguei pointed it out.
Thanks, Harold
On 12/5/2019 11:15 AM, Daniel D. Daugherty wrote:
Do you plan to make JVM/TI spec ch
On 12/5/19 11:00 AM, serguei.spit...@oracle.com wrote:
Hi Collen,
Thank you for making this update!
It looks good to me.
One nit:
http://cr.openjdk.java.net/~coleenp/2019/8212160.03/webrev/test/hotspot/jtreg/serviceability/jvmti/CompiledMethodLoad/libCompiledZombie.cpp.html
46 // Continuo
On 12/5/19 10:36,
coleen.phillim...@oracle.com wrote:
On 12/5/19 11:00 AM, serguei.spit...@oracle.com wrote:
Hi Collen,
Thank you for making this update!
It looks good to me.
One nit:
On 12/5/19 1:41 PM, serguei.spit...@oracle.com wrote:
On 12/5/19 10:36, coleen.phillim...@oracle.com wrote:
On 12/5/19 11:00 AM, serguei.spit...@oracle.com wrote:
Hi Collen,
Thank you for making this update!
It looks good to me.
One nit:
http://cr.openjdk.java.net/~coleenp/2019/8212160.0
Hi Mandy and Bob,
Please review a new version of the webrev that addresses the most of these
issues:
1) The interface and spec [3] were updated to use default methods. CSR [3] was
re-approved.
2) Security-sensitive operations in j.i.p.cgroupv1.Metrics and in
j.i.p.cgroupv1. SubSystem
were
Hi all,
Recently JdwpListenTest.java and JdwpAttachTest.java have started to
fail on Windows2016 for unclear (yet) reason:
https://bugs.openjdk.java.net/browse/JDK-8234935
Until the issue is resolved need to problem list the tests.
jira: https://bugs.openjdk.java.net/browse/JDK-8235433
the fi
In
http://cr.openjdk.java.net/~dtitov/8226575/webrev.03/src/java.base/linux/classes/jdk/internal/platform/cgroupv1/SubSystem.java.sdiff.html
Shouldn’t you keep the IOException catch clauses in case the file is not found?
> On Dec 5, 2019, at 2:31 PM, Daniil Titov wrote:
>
> Hi Mandy and Bob,
On 12/5/19 12:50 PM, Bob Vandette wrote:
It may worth considering adding Metrics::getSwapLimit and
Metrics::getSwapUsage and move the computation to the implementation of
Metrics. Bob may have an opinion.
There was no any new input regarding this so I decided to leave it unchanged.
Sorry,
Got it, thanks!
Serguei
On 12/5/19 11:15, coleen.phillim...@oracle.com wrote:
On 12/5/19 1:41 PM, serguei.spit...@oracle.com wrote:
On 12/5/19 10:36, coleen.phillim...@oracle.com
wrote:
Thumbs up. This is a trivial change.
Dan
On 12/5/19 3:29 PM, Alex Menkov wrote:
Hi all,
Recently JdwpListenTest.java and JdwpAttachTest.java have started to
fail on Windows2016 for unclear (yet) reason:
https://bugs.openjdk.java.net/browse/JDK-8234935
Until the issue is resolved need to pro
Thanks Serguei!
Coleen
On 12/5/19 4:24 PM, serguei.spit...@oracle.com wrote:
Got it, thanks!
Serguei
On 12/5/19 11:15, coleen.phillim...@oracle.com wrote:
On 12/5/19 1:41 PM, serguei.spit...@oracle.com wrote:
On 12/5/19 10:36, coleen.phillim...@oracle.com wrote:
On 12/5/19 11:00 AM, ser
Looks good Harold!
If we get any more of these unmodifiable attributes we may have to look
at a way to refer to them more abstractly and only define them in one place.
Thanks,
David
On 6/12/2019 12:28 am, Harold Seigel wrote:
Hi,
Please review this trivial change to add documentation about
Hi David,
Agreed. I was thinking about the same.
Thanks,
Serguei
On 12/5/19 2:52 PM, David Holmes wrote:
Looks good Harold!
If we get any more of these unmodifiable attributes we may have to
look at a way to refer to them more abstractly and only define them in
one place.
Thanks,
David
O
Hi Mandy and Bob,
Thank you for your comments. Please review a new version of the fix [1] that
makes
OperatingSystemImpl methods return -1 if one of the metric has value 0.
As Mandy recommended I also updated the Javadoc for OperatingSystemMXBean
indicating that methods could return -1 if the
Hi Chris and Alex,
(I've also included Dan, David and Dean to the mailing list)
We have to reach a consensus about this.
We have 3 options:
Option #1:
The JIT optimization to delete a code which "looks useless"
has to be disabled if can_pop_frame capability is enabled.
Than this problem
Hi Serguei,
On 6/12/2019 11:31 am, serguei.spit...@oracle.com wrote:
Hi Chris and Alex,
(I've also included Dan, David and Dean to the mailing list)
We have to reach a consensus about this.
This is just part of a much broader issue with JVM TI that I tried to
have a discussion started based
Hi David,
Thank you for writing this down.
Totally agree with you here.
On 12/5/19 6:45 PM, David Holmes wrote:
Hi Serguei,
On 6/12/2019 11:31 am, serguei.spit...@oracle.com wrote:
Hi Chris and Alex,
(I've also included Dan, David and Dean to the mailing list)
We have to reach a consensus
Hi Daniil,
I'm not familiar with all the details of the various API's involved here
so just a few general comments in places. I do have one major issue
flagged below.
---
src/jdk.management/linux/native/libmanagement_ext/UnixOperatingSystem.c
! static int initialized=1;
Am I reading th
30 matches
Mail list logo
