Re: RFR: JDK-8215196: [Graal] vmTestbase/nsk/jvmti/PopFrame/popframe003/TestDescription.java fails with "changes for the arguments of the popped frame's method, did not remain current argument values"

2019-12-06 Thread Chris Plummer
On 12/6/19 6:12 PM, serguei.spit...@oracle.com wrote: On 12/6/19 17:24, Daniel D. Daugherty wrote: On 12/6/19 6:26 PM, serguei.spit...@oracle.com wrote: On 12/6/19 13:52, Chris Plummer wrote: On 12/6/19 1:18 PM, serguei.spit...@oracle.com wrote: On 12/6/19 11:07, Chris Plummer wrote: On

Re: RFR: JDK-8215196: [Graal] vmTestbase/nsk/jvmti/PopFrame/popframe003/TestDescription.java fails with "changes for the arguments of the popped frame's method, did not remain current argument values"

2019-12-06 Thread Chris Plummer
On 12/6/19 3:26 PM, serguei.spit...@oracle.com wrote: On 12/6/19 13:52, Chris Plummer wrote: On 12/6/19 1:18 PM, serguei.spit...@oracle.com wrote: On 12/6/19 11:07, Chris Plummer wrote: On 12/5/19 6:45 PM, David Holmes wrote: Hi Serguei, On 6/12/2019 11:31 am, serguei.spit...@oracle.com

Re: RFR: JDK-8215196: [Graal] vmTestbase/nsk/jvmti/PopFrame/popframe003/TestDescription.java fails with "changes for the arguments of the popped frame's method, did not remain current argument values"

2019-12-06 Thread serguei.spit...@oracle.com
On 12/6/19 17:24, Daniel D. Daugherty wrote: On 12/6/19 6:26 PM, serguei.spit...@oracle.com wrote: On 12/6/19 13:52, Chris Plummer wrote: On 12/6/19 1:18 PM, serguei.spit...@oracle.com wrote: On 12/6/19 11:07, Chris Plummer wrote: On 12/5/19 6:45 PM, David Holmes wrote: Hi Serguei, On

Re: RFR: 8226575: OperatingSystemMXBean should be made container aware

2019-12-06 Thread Daniil Titov
Hi David, Mandy, and Bob, Thank you for reviewing this fix. Please review a new version of the fix [1] that includes the following changes comparing to the previous version of the webrev ( webrev.04) 1. The changes in Javadoc made in the webrev.04 comparing to webrev.03 and to CSR [3] were

Re: RFR: JDK-8215196: [Graal] vmTestbase/nsk/jvmti/PopFrame/popframe003/TestDescription.java fails with "changes for the arguments of the popped frame's method, did not remain current argument values"

2019-12-06 Thread Daniel D. Daugherty
On 12/6/19 6:26 PM, serguei.spit...@oracle.com wrote: On 12/6/19 13:52, Chris Plummer wrote: On 12/6/19 1:18 PM, serguei.spit...@oracle.com wrote: On 12/6/19 11:07, Chris Plummer wrote: On 12/5/19 6:45 PM, David Holmes wrote: Hi Serguei, On 6/12/2019 11:31 am, serguei.spit...@oracle.com

Re: RFR: JDK-8215196: [Graal] vmTestbase/nsk/jvmti/PopFrame/popframe003/TestDescription.java fails with "changes for the arguments of the popped frame's method, did not remain current argument values"

2019-12-06 Thread serguei.spit...@oracle.com
The PopFrame together with RedefineClasses is a part of the JVM TI HotSwap feature. The use case is to hot patch the methods. If after class redefinition there are still some method frames then the PopFrame is an option to "refresh" such frames. I agree, this is unreliable and dangerous. But

Re: RFR: JDK-8215196: [Graal] vmTestbase/nsk/jvmti/PopFrame/popframe003/TestDescription.java fails with "changes for the arguments of the popped frame's method, did not remain current argument values"

2019-12-06 Thread serguei.spit...@oracle.com
On 12/6/19 13:52, Chris Plummer wrote: On 12/6/19 1:18 PM, serguei.spit...@oracle.com wrote: On 12/6/19 11:07, Chris Plummer wrote: On 12/5/19 6:45 PM, David Holmes wrote: Hi Serguei, On 6/12/2019 11:31 am, serguei.spit...@oracle.com wrote: Hi Chris and Alex, (I've also included Dan, David

Re: RFR: JDK-8215196: [Graal] vmTestbase/nsk/jvmti/PopFrame/popframe003/TestDescription.java fails with "changes for the arguments of the popped frame's method, did not remain current argument values"

2019-12-06 Thread Dean Long
This might be a dumb question, but how is PopFrame used in practice?  Re-invoking the method, especially with modified argument values seems dangerous. dl

Re: RFR: JDK-8215196: [Graal] vmTestbase/nsk/jvmti/PopFrame/popframe003/TestDescription.java fails with "changes for the arguments of the popped frame's method, did not remain current argument values"

2019-12-06 Thread Chris Plummer
On 12/6/19 1:18 PM, serguei.spit...@oracle.com wrote: On 12/6/19 11:07, Chris Plummer wrote: On 12/5/19 6:45 PM, David Holmes wrote: Hi Serguei, On 6/12/2019 11:31 am, serguei.spit...@oracle.com wrote: Hi Chris and Alex, (I've also included Dan, David and Dean to the mailing list) We have

Re: RFR: 8226575: OperatingSystemMXBean should be made container aware

2019-12-06 Thread Mandy Chung
On 12/6/19 5:59 AM, Bob Vandette wrote: On Dec 6, 2019, at 2:49 AM, David Holmes wrote: src/jdk.management/share/classes/com/sun/management/OperatingSystemMXBean.java The changes to allow for a return of -1 are somewhat more extensive than we have previously discussed. These methods

Re: RFR: JDK-8215196: [Graal] vmTestbase/nsk/jvmti/PopFrame/popframe003/TestDescription.java fails with "changes for the arguments of the popped frame's method, did not remain current argument values"

2019-12-06 Thread serguei.spit...@oracle.com
On 12/6/19 11:07, Chris Plummer wrote: On 12/5/19 6:45 PM, David Holmes wrote: Hi Serguei, On 6/12/2019 11:31 am, serguei.spit...@oracle.com wrote: Hi Chris and Alex, (I've also included Dan, David and Dean to the mailing list) We have to reach a consensus about this. This is just part of

Re: RFR 8235360: Update JDWP, JDI and Instrumentation specs for Record attribute

2019-12-06 Thread serguei.spit...@oracle.com
Thanks, Harold. Serguei On 12/6/19 10:29, Harold Seigel wrote: Hi Serguei, >> Is this new attribute for 14? No.  15, maybe? >>Will it also come from Amber? Yes. Harold On 12/6/2019 1:27 PM, serguei.spit...@oracle.com wrote: Forgot to ask. Is this new attribute for 14? Will it also come

Re: RFR: JDK-8215196: [Graal] vmTestbase/nsk/jvmti/PopFrame/popframe003/TestDescription.java fails with "changes for the arguments of the popped frame's method, did not remain current argument values"

2019-12-06 Thread Chris Plummer
On 12/5/19 6:45 PM, David Holmes wrote: Hi Serguei, On 6/12/2019 11:31 am, serguei.spit...@oracle.com wrote: Hi Chris and Alex, (I've also included Dan, David and Dean to the mailing list) We have to reach a consensus about this. This is just part of a much broader issue with JVM TI that I

Re: RFR 8235360: Update JDWP, JDI and Instrumentation specs for Record attribute

2019-12-06 Thread serguei.spit...@oracle.com
Forgot to ask. Is this new attribute for 14? Will it also come from Amber? Thanks, Serguei On 12/6/19 10:21, serguei.spit...@oracle.com wrote: Hi Harold, Okay, thanks! Thanks, Serguei On 12/6/19 05:16, Harold Seigel wrote: There will be another unmodifiable attribute with sealed types

Re: RFR 8235360: Update JDWP, JDI and Instrumentation specs for Record attribute

2019-12-06 Thread serguei.spit...@oracle.com
Hi Harold, Okay, thanks! Thanks, Serguei On 12/6/19 05:16, Harold Seigel wrote: There will be another unmodifiable attribute with sealed types called PermittedSubtypes. Harold On 12/5/2019 7:25 PM, serguei.spit...@oracle.com wrote: Hi David, Agreed. I was thinking about the same.

Re: RFR(T) : 8235353 : clean up hotspot problem lists

2019-12-06 Thread Igor Ignatyev
Martin, Christoph, thanks for verifying this. pushed. -- Igor > On Dec 6, 2019, at 2:51 AM, Doerr, Martin wrote: > > Hi Igor and Vladimir, > > the tests have passed on PPC64. Change is good. Thanks for checking with us. > > Best regards, > Martin > > >> -Original Message- >>

Re: RFR: 8226575: OperatingSystemMXBean should be made container aware

2019-12-06 Thread Laurence Cable
+1 On 12/6/19 5:59 AM, Bob Vandette wrote: On Dec 6, 2019, at 2:49 AM, David Holmes wrote: Hi Daniil, I'm not familiar with all the details of the various API's involved here so just a few general comments in places. I do have one major issue flagged below. ---

Re: RFR: 8226575: OperatingSystemMXBean should be made container aware

2019-12-06 Thread Bob Vandette
> On Dec 6, 2019, at 2:49 AM, David Holmes wrote: > > Hi Daniil, > > I'm not familiar with all the details of the various API's involved here so > just a few general comments in places. I do have one major issue flagged > below. > > --- > >

Re: RFR 8235360: Update JDWP, JDI and Instrumentation specs for Record attribute

2019-12-06 Thread Harold Seigel
There will be another unmodifiable attribute with sealed types called PermittedSubtypes. Harold On 12/5/2019 7:25 PM, serguei.spit...@oracle.com wrote: Hi David, Agreed. I was thinking about the same. Thanks, Serguei On 12/5/19 2:52 PM, David Holmes wrote: Looks good Harold! If we get

Re: RFR 8235360: Update JDWP, JDI and Instrumentation specs for Record attribute

2019-12-06 Thread Harold Seigel
Thanks David! Harold On 12/5/2019 5:52 PM, David Holmes wrote: Looks good Harold! If we get any more of these unmodifiable attributes we may have to look at a way to refer to them more abstractly and only define them in one place. Thanks, David On 6/12/2019 12:28 am, Harold Seigel wrote: